* linux-next: build warnings
@ 2017-05-02 6:05 Stephen Rothwell
2017-05-02 9:53 ` Michael Ellerman
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2017-05-02 6:05 UTC (permalink / raw)
To: Michael Ellerman, Benjamin Herrenschmidt, PowerPC, Paul Mackerras
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi all,
The linux-next build (powerpc allyesconfig) produced these warnings
(and have for a while):
arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_enter':
arch/powerpc/kvm/book3s_pr_papr.c:53:2: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
copy_from_user(pteg, (void __user *)pteg_addr, sizeof(pteg));
^
arch/powerpc/kvm/book3s_pr_papr.c:74:2: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result [-Wunused-result]
copy_to_user((void __user *)pteg_addr, hpte, HPTE_SIZE);
^
arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_remove':
arch/powerpc/kvm/book3s_pr_papr.c:96:2: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
copy_from_user(pte, (void __user *)pteg, sizeof(pte));
^
arch/powerpc/kvm/book3s_pr_papr.c:106:2: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result [-Wunused-result]
copy_to_user((void __user *)pteg, &v, sizeof(v));
^
arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_protect':
arch/powerpc/kvm/book3s_pr_papr.c:214:2: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
copy_from_user(pte, (void __user *)pteg, sizeof(pte));
^
arch/powerpc/kvm/book3s_pr_papr.c:237:2: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result [-Wunused-result]
copy_to_user((void __user *)pteg, pte, sizeof(pte));
^
arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_bulk_remove':
arch/powerpc/kvm/book3s_pr_papr.c:174:3: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
copy_from_user(pte, (void __user *)pteg, sizeof(pte));
^
arch/powerpc/kvm/book3s_pr_papr.c:187:4: warning: ignoring return value of 'copy_to_user', declared with attribute warn_unused_result [-Wunused-result]
copy_to_user((void __user *)pteg, &v, sizeof(v));
^
These calls have been there since about v3.1-rc8. I assume the
copy_to/from_user() work has pointed them out.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings
2017-05-02 6:05 linux-next: build warnings Stephen Rothwell
@ 2017-05-02 9:53 ` Michael Ellerman
2017-05-02 11:17 ` Stephen Rothwell
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2017-05-02 9:53 UTC (permalink / raw)
To: Stephen Rothwell, Benjamin Herrenschmidt, PowerPC, Paul Mackerras
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi all,
>
> The linux-next build (powerpc allyesconfig) produced these warnings
> (and have for a while):
>
> arch/powerpc/kvm/book3s_pr_papr.c: In function 'kvmppc_h_pr_enter':
> arch/powerpc/kvm/book3s_pr_papr.c:53:2: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result [-Wunused-result]
> copy_from_user(pteg, (void __user *)pteg_addr, sizeof(pteg));
> ^
Thanks, I had seen them, but they're KVM so I'll leave them to Paul to
fix up.
Though we are supposed to be building with -Werror, so those should be
breaking the build. I assume you have turned Werror off?
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings
2017-05-02 9:53 ` Michael Ellerman
@ 2017-05-02 11:17 ` Stephen Rothwell
2017-05-02 11:21 ` Stephen Rothwell
2017-05-02 12:46 ` Michael Ellerman
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Rothwell @ 2017-05-02 11:17 UTC (permalink / raw)
To: Michael Ellerman
Cc: Benjamin Herrenschmidt, PowerPC, Paul Mackerras,
Linux-Next Mailing List, Linux Kernel Mailing List
Hi Michael,
On Tue, 02 May 2017 19:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Though we are supposed to be building with -Werror, so those should be
> breaking the build. I assume you have turned Werror off?
I assume that allyesconfig turns on CONFIG_PPC_DISABLE_WERROR ...
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings
2017-05-02 11:17 ` Stephen Rothwell
@ 2017-05-02 11:21 ` Stephen Rothwell
2017-05-02 12:46 ` Michael Ellerman
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2017-05-02 11:21 UTC (permalink / raw)
To: Michael Ellerman
Cc: Benjamin Herrenschmidt, PowerPC, Paul Mackerras,
Linux-Next Mailing List, Linux Kernel Mailing List
Hi Michael,
On Tue, 2 May 2017 21:17:01 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 02 May 2017 19:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > Though we are supposed to be building with -Werror, so those should be
> > breaking the build. I assume you have turned Werror off?
>
> I assume that allyesconfig turns on CONFIG_PPC_DISABLE_WERROR ...
Also, how many configs (if any) turn on CONFIG_KVM_BOOK3S_64_PR?
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build warnings
2017-05-02 11:17 ` Stephen Rothwell
2017-05-02 11:21 ` Stephen Rothwell
@ 2017-05-02 12:46 ` Michael Ellerman
1 sibling, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2017-05-02 12:46 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Benjamin Herrenschmidt, PowerPC, Paul Mackerras,
Linux-Next Mailing List, Linux Kernel Mailing List
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> On Tue, 02 May 2017 19:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Though we are supposed to be building with -Werror, so those should be
>> breaking the build. I assume you have turned Werror off?
>
> I assume that allyesconfig turns on CONFIG_PPC_DISABLE_WERROR ...
Yep. Sorry you did mention it was allyesconfig in your original mail, zzzz!
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-02 12:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 6:05 linux-next: build warnings Stephen Rothwell
2017-05-02 9:53 ` Michael Ellerman
2017-05-02 11:17 ` Stephen Rothwell
2017-05-02 11:21 ` Stephen Rothwell
2017-05-02 12:46 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).