linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Zhang Rui <rui.zhang@intel.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Eduardo Valentin <edubezval@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amit.kucheria@verdurent.com>,
	qperret@google.com
Subject: Re: linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR)
Date: Wed, 4 Dec 2019 21:47:42 -0800	[thread overview]
Message-ID: <8895dbb7-dd48-1076-cef2-64d53a59c081@infradead.org> (raw)
In-Reply-To: <6d43c93a748872293df489d397f894b77b221bc9.camel@intel.com>

On 12/4/19 8:27 PM, Zhang Rui wrote:
> On Wed, 2019-12-04 at 08:25 -0800, Randy Dunlap wrote:
>> On 11/15/19 3:44 PM, Randy Dunlap wrote:
>>> On 11/15/19 12:05 AM, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20191114:
>>>>
>>>
>>> on i386:
>>>
>>> WARNING: unmet direct dependencies detected for
>>> THERMAL_GOV_POWER_ALLOCATOR
>>>   Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
>>>   Selected by [y]:
>>>   - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
>>>
>>>
>>> THERMAL_GOV_POWER_ALLOCATOR is selected by
>>> THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
>>> even though ENERGY_MODEL is not set/enabled.
>>>
>>>
>>
>> This Kconfig warning is still happening in linux-next of 20191204.
>>
> I overlooked the original report probably because I was not CCed.
> 
> This is introduced by commit a4e893e802e6("thermal: cpu_cooling:
> Migrate to using the EM framework") which adds the dependency of
> ENERGY_MODEL for THERMAL_GOV_POWER_ALLOCATOR.
> 
> To fix this, it's better to make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> depends on THERMAL_GOV_POWER_ALLOCATOR instead.
> 
> Please confirm the problem is fixed by below patch.
> 
> thanks,
> rui
> 
> From c9429f6e28ea2219686a4294d39f015ba373774b Mon Sep 17 00:00:00 2001
> From: Zhang Rui <rui.zhang@intel.com>
> Date: Thu, 5 Dec 2019 12:17:07 +0800
> Subject: [PATCH] thermal: fix a Kconfig warning
> 
> Currently, THERMAL_GOV_POWER_ALLOCATOR is selected by
> THERMAL_DEFAULT_GOV_POWER_ALLOCATOR even if it has some unmet
> dependencies.
> 
> This causes the Kconfig warning
>    WARNING: unmet direct dependencies detected for
>       THERMAL_GOV_POWER_ALLOCATOR
>       Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
>       Selected by [y]:
>       - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
> 
> Fix the problem by making THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depends on
> THERMAL_GOV_POWER_ALLOCATOR instead.
> 
> Fixes: a4e893e802e6("thermal: cpu_cooling: Migrate to using the EM framework")
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>  drivers/thermal/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 59b79fc48266..79b27865c6f4 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
>  
>  config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
>  	bool "power_allocator"
> -	select THERMAL_GOV_POWER_ALLOCATOR
> +	depends on THERMAL_GOV_POWER_ALLOCATOR
>  	help
>  	  Select this if you want to control temperature based on
>  	  system and device power allocation. This governor can only
> 


-- 
~Randy


      parent reply	other threads:[~2019-12-05  5:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15  8:05 linux-next: Tree for Nov 15 Stephen Rothwell
2019-11-15 16:02 ` linux-next: Tree for Nov 15 (objtool) Randy Dunlap
2019-11-15 16:38   ` Josh Poimboeuf
2020-01-20 15:37     ` Josh Poimboeuf
2019-11-15 16:11 ` linux-next: Tree for Nov 15 Naresh Kamboju
2019-11-15 16:17 ` linux-next: Tree for Nov 15 (drivers/md/dm-integrity) Randy Dunlap
2019-11-15 16:19   ` Randy Dunlap
2019-11-15 19:27     ` Mike Snitzer
2019-11-18 16:32     ` Alasdair G Kergon
2019-11-15 22:46   ` Stephen Rothwell
2019-11-15 23:10     ` Mike Snitzer
2019-11-15 23:32       ` Stephen Rothwell
2019-11-15 16:35 ` linux-next: Tree for Nov 15 (sound/soc/codecs/rt5677) Randy Dunlap
2019-11-15 23:44 ` linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) Randy Dunlap
2019-12-04 16:25   ` Randy Dunlap
2019-12-05  4:27     ` Zhang Rui
2019-12-05  4:36       ` Quentin Perret
2019-12-05  5:50         ` Zhang Rui
2019-12-05  5:47       ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8895dbb7-dd48-1076-cef2-64d53a59c081@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=amit.kucheria@verdurent.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=qperret@google.com \
    --cc=rui.zhang@intel.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).