From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB32C432C0 for ; Mon, 25 Nov 2019 23:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 922A420740 for ; Mon, 25 Nov 2019 23:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725946AbfKYXnU (ORCPT ); Mon, 25 Nov 2019 18:43:20 -0500 Received: from www62.your-server.de ([213.133.104.62]:44712 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfKYXnT (ORCPT ); Mon, 25 Nov 2019 18:43:19 -0500 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iZO0e-0001rZ-CG; Tue, 26 Nov 2019 00:43:12 +0100 Received: from [178.197.248.11] (helo=pc-9.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1iZO0d-0007fK-T3; Tue, 26 Nov 2019 00:43:11 +0100 Subject: Re: [PATCH] bpf: fix a no-mmu build failure by providing a stub allocator To: John Hubbard , Andrii Nakryiko Cc: Song Liu , John Fastabend , Johannes Weiner , Linux Next Mailing List , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML , kbuild test robot References: <20191125234103.1699950-1-jhubbard@nvidia.com> <20191125234103.1699950-2-jhubbard@nvidia.com> From: Daniel Borkmann Message-ID: <8c4d892a-73b5-b4d5-be15-bc81e8297de9@iogearbox.net> Date: Tue, 26 Nov 2019 00:43:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191125234103.1699950-2-jhubbard@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25644/Mon Nov 25 10:54:22 2019) Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 11/26/19 12:41 AM, John Hubbard wrote: > Commit fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY") > added code that calls vmalloc_user_node_flags() and therefore requires > mm/vmalloc.c. However, that file is not built for the !CONFIG_MMU case. > This leads to a build failure when using ARM with the config provided > by at least one particular kbuild test robot report [1]. > > [1] https://lore/kernel.org/r/201911251639.UWS3hE3Y%lkp@intel.com > > Fix the build by providing a stub function for __bpf_map_area_alloc(). > > Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY") > Reported-by: kbuild test robot > Cc: Andrii Nakryiko > Cc: Daniel Borkmann > Cc: Song Liu > Cc: John Fastabend > Cc: Johannes Weiner > Signed-off-by: John Hubbard Thanks for the patch, already fixed via: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=ed81745a4c96841937f1da35c0eb66ac312e1480