From: Hans de Goede <hdegoede@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Subject: Re: linux-next: Tree for Oct 25 (drivers/platform/x86/amd-pmc.c)
Date: Mon, 25 Oct 2021 23:29:25 +0200 [thread overview]
Message-ID: <92c26aee-d3eb-258c-a0dd-e09783db6a20@redhat.com> (raw)
In-Reply-To: <af7d7b8f-45fd-53c5-a8c4-1f594a16111e@infradead.org>
Hi,
On 10/25/21 22:50, Randy Dunlap wrote:
> On 10/25/21 2:49 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> There seems to be something amiss with cnosole output in today's release
>> (at least on my ppc qemu boot tests).
>>
>> Changes since 20211022:
>>
>
> on x86_64:
>
> ../drivers/platform/x86/amd-pmc.c: In function ‘amd_pmc_verify_czn_rtc’:
> ../drivers/platform/x86/amd-pmc.c:428:30: error: ‘CONFIG_RTC_SYSTOHC_DEVICE’ undeclared (first use in this function); did you mean ‘CONFIG_RTC_HCTOSYS_DEVICE’?
> rtc_device = rtc_class_open(CONFIG_RTC_SYSTOHC_DEVICE);
> ^~~~~~~~~~~~~~~~~~~~~~~~~
> CONFIG_RTC_HCTOSYS_DEVICE
Hmm, yes using either CONFIG setting is a problem since it is not always
defined. Both simply default to "rtc0" though and this is also which
standard distro configs use.
Mario, can we just replace CONFIG_RTC_SYSTOHC_DEVICE with "rtc0"
here to fix this ?
Regards,
Hans
next prev parent reply other threads:[~2021-10-25 21:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 9:49 linux-next: Tree for Oct 25 Stephen Rothwell
2021-10-25 20:50 ` linux-next: Tree for Oct 25 (drivers/platform/x86/amd-pmc.c) Randy Dunlap
2021-10-25 21:29 ` Hans de Goede [this message]
2021-10-25 21:32 ` Limonciello, Mario
2021-10-26 7:55 ` Hans de Goede
2021-10-25 22:11 ` linux-next: Tree for Oct 25 Dmitry Osipenko
2021-10-26 1:28 ` Ming Lei
2021-10-26 8:40 ` Dmitry Osipenko
2021-10-26 3:20 ` linux-next: Tree for Oct 25 (bootconfig: xbc_alloc_mem()) Randy Dunlap
2021-10-26 5:11 ` Stephen Rothwell
2021-10-27 11:42 ` linux-next: Tree for Oct 25 Stephen Rothwell
2021-10-27 12:54 ` Greg Kroah-Hartman
2021-10-28 1:51 ` Xianting Tian
2021-10-28 4:51 ` Stephen Rothwell
2021-10-28 7:59 ` Xianting Tian
2021-10-28 12:48 ` Stephen Rothwell
2021-10-28 12:54 ` Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92c26aee-d3eb-258c-a0dd-e09783db6a20@redhat.com \
--to=hdegoede@redhat.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).