Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the block tree
@ 2020-07-29 22:08 Stephen Rothwell
  2020-07-29 22:12 ` Stephen Rothwell
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2020-07-29 22:08 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi all,

In commit

  64d452b3560b ("nvme-loop: set ctrl state connecting after init")

Fixes tag

  Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")

has these problem(s):

  - Target SHA1 does not exist

I can't easily find what commit is meant :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-07-29 22:08 linux-next: Fixes tag needs some work in the block tree Stephen Rothwell
@ 2020-07-29 22:12 ` Stephen Rothwell
  2020-07-30 15:04   ` Jens Axboe
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2020-07-29 22:12 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Chaitanya Kulkarni, Christoph Hellwig


[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi all,

[Just adding cc's]

On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   64d452b3560b ("nvme-loop: set ctrl state connecting after init")
> 
> Fixes tag
> 
>   Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> I can't easily find what commit is meant :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-07-29 22:12 ` Stephen Rothwell
@ 2020-07-30 15:04   ` Jens Axboe
  0 siblings, 0 replies; 27+ messages in thread
From: Jens Axboe @ 2020-07-30 15:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Chaitanya Kulkarni, Christoph Hellwig

On 7/29/20 4:12 PM, Stephen Rothwell wrote:
> Hi all,
> 
> [Just adding cc's]
> 
> On Thu, 30 Jul 2020 08:08:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> In commit
>>
>>   64d452b3560b ("nvme-loop: set ctrl state connecting after init")
>>
>> Fixes tag
>>
>>   Fixes: aa63fa6776a7 ("nvme-fabrics: allow to queue requests for live queues")
>>
>> has these problem(s):
>>
>>   - Target SHA1 does not exist
>>
>> I can't easily find what commit is meant :-(

Yeah, it's obviously garbage, the commit doesn't even exist, let alone the sha.

Chaitanya, where's this from??

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-29 22:36     ` Stephen Rothwell
@ 2020-06-29 22:45       ` Jens Axboe
  0 siblings, 0 replies; 27+ messages in thread
From: Jens Axboe @ 2020-06-29 22:45 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Pavel Begunkov, Linux Next Mailing List, Linux Kernel Mailing List

On 6/29/20 4:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
>>> On 29/06/2020 01:05, Stephen Rothwell wrote:  
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")  
>>>
>>> Jens, could you please fix this up after me?
>>> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a  
>>
>> I don't think that's a grave enough concern to rebase, it's just "missing" a
>> single digit of the sha.
> 
> Yeah, its more of a "please fix your git config". :-)

Agree! But I'm guessing that Pavel did this manually, which I end up
doing a lot too... And then mistakes happen.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-29 16:25   ` Jens Axboe
@ 2020-06-29 22:36     ` Stephen Rothwell
  2020-06-29 22:45       ` Jens Axboe
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2020-06-29 22:36 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Pavel Begunkov, Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Hi all,

On Mon, 29 Jun 2020 10:25:01 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> > On 29/06/2020 01:05, Stephen Rothwell wrote:  
> >> Hi all,
> >>
> >> In commit
> >>
> >>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
> >>
> >> Fixes tag
> >>
> >>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")  
> > 
> > Jens, could you please fix this up after me?
> > full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a  
> 
> I don't think that's a grave enough concern to rebase, it's just "missing" a
> single digit of the sha.

Yeah, its more of a "please fix your git config". :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-29 16:21 ` Pavel Begunkov
@ 2020-06-29 16:25   ` Jens Axboe
  2020-06-29 22:36     ` Stephen Rothwell
  0 siblings, 1 reply; 27+ messages in thread
From: Jens Axboe @ 2020-06-29 16:25 UTC (permalink / raw)
  To: Pavel Begunkov, Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 6/29/20 10:21 AM, Pavel Begunkov wrote:
> On 29/06/2020 01:05, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
>>
>> Fixes tag
>>
>>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")
> 
> Jens, could you please fix this up after me?
> full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a

I don't think that's a grave enough concern to rebase, it's just "missing" a
single digit of the sha.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-28 22:05 Stephen Rothwell
@ 2020-06-29 16:21 ` Pavel Begunkov
  2020-06-29 16:25   ` Jens Axboe
  0 siblings, 1 reply; 27+ messages in thread
From: Pavel Begunkov @ 2020-06-29 16:21 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 29/06/2020 01:05, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")
> 
> Fixes tag
> 
>   Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")

Jens, could you please fix this up after me?
full hash: a1d7c393c4711a9ce6c239c3ab053a50dc96505a

> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 

-- 
Pavel Begunkov

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-06-28 22:05 Stephen Rothwell
  2020-06-29 16:21 ` Pavel Begunkov
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2020-06-28 22:05 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Pavel Begunkov


[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  8c9cb6cd9a46 ("io_uring: fix refs underflow in io_iopoll_queue()")

Fixes tag

  Fixes: a1d7c393c47 ("io_uring: enable READ/WRITE to use deferred completions")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  5:12       ` Stephen Rothwell
@ 2020-06-28 13:38         ` Jens Axboe
  0 siblings, 0 replies; 27+ messages in thread
From: Jens Axboe @ 2020-06-28 13:38 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Konstantin Ryabitsev, Linux Next Mailing List,
	Linux Kernel Mailing List, Pavel Begunkov

On 6/26/20 11:12 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Right, but that's what git format-patch does when the line is long.
> 
> I just tested, and "git format-patch" (for me) does *not* split those lines.

Huh, I could have sworn it's done that for me in the past, just like it
splits the Subject: line into multiple lines as well (that I just did
verify that it still does).

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  5:01     ` Stephen Rothwell
@ 2020-06-27 11:18       ` Pavel Begunkov
  0 siblings, 0 replies; 27+ messages in thread
From: Pavel Begunkov @ 2020-06-27 11:18 UTC (permalink / raw)
  To: Stephen Rothwell, Konstantin Ryabitsev
  Cc: Jens Axboe, Linux Next Mailing List, Linux Kernel Mailing List

On 27/06/2020 08:01, Stephen Rothwell wrote:
> Hi Konstantin,
> 
> On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>>
>> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:  
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>>
>>>> has these problem(s):
>>>>
>>>>   - Subject has leading but no trailing parentheses
>>>>   - Subject has leading but no trailing quotes
>>>>
>>>> Please do not split Fixes tags over more than one line.  
>>>
>>> Gah, that's b4 messing it up. I've actually seen this before, but
>>> I caught it. If you look at the actual commit, this is what the b4
>>> output ends up being for the fixes line:
>>>
>>> [snip]
>>> io_kiocb's result and iopoll_completed")
>>>
>>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> even though it's correct in the email. I'm guessing some issue having to
>>> do with the longer line?  
>>
>> Yeah, I'll try to see if there's something I can do here, but it's going 
>> to be largely guesswork. Here's the original email:
>>
>> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
>>
>> The Fixes: footer really does get split into two. It's not that hard to 
>> add logic just for the Fixes tag (since it conveniently follows a set 
>> pattern), but finding a universal fix for split footers will be more 
>> difficult.
>>
>> I'll see what I can do.
> 
> But (what am I missing?) the Fixes: tag has been split over 2 lines in
> the original message ... on lore and my copy.  There is nothing for b4
> to do here, the author needs to do this right.

Yes, it was split from the beginning. It's really a shame it can't handle
multi-line tags, but well, I'll keep that in mind.

Though, it's curious how

```
Fixes ("line1
line2")
```

became 
```
line2")

Fixes ("line1
```

And that's what the rest of the thread is about.

-- 
Pavel Begunkov

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  2:25     ` Jens Axboe
@ 2020-06-27  5:12       ` Stephen Rothwell
  2020-06-28 13:38         ` Jens Axboe
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2020-06-27  5:12 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Konstantin Ryabitsev, Linux Next Mailing List,
	Linux Kernel Mailing List, Pavel Begunkov


[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

Hi Jens,

On Fri, 26 Jun 2020 20:25:31 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> Right, but that's what git format-patch does when the line is long.

I just tested, and "git format-patch" (for me) does *not* split those lines.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  1:56   ` Konstantin Ryabitsev
  2020-06-27  2:25     ` Jens Axboe
@ 2020-06-27  5:01     ` Stephen Rothwell
  2020-06-27 11:18       ` Pavel Begunkov
  1 sibling, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2020-06-27  5:01 UTC (permalink / raw)
  To: Konstantin Ryabitsev
  Cc: Jens Axboe, Linux Next Mailing List, Linux Kernel Mailing List,
	Pavel Begunkov


[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

Hi Konstantin,

On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> > On 6/26/20 5:07 PM, Stephen Rothwell wrote:  
> > > Hi all,
> > > 
> > > In commit
> > > 
> > >   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > > 
> > > has these problem(s):
> > > 
> > >   - Subject has leading but no trailing parentheses
> > >   - Subject has leading but no trailing quotes
> > > 
> > > Please do not split Fixes tags over more than one line.  
> > 
> > Gah, that's b4 messing it up. I've actually seen this before, but
> > I caught it. If you look at the actual commit, this is what the b4
> > output ends up being for the fixes line:
> > 
> > [snip]
> > io_kiocb's result and iopoll_completed")
> > 
> > Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > 
> > even though it's correct in the email. I'm guessing some issue having to
> > do with the longer line?  
> 
> Yeah, I'll try to see if there's something I can do here, but it's going 
> to be largely guesswork. Here's the original email:
> 
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
> 
> The Fixes: footer really does get split into two. It's not that hard to 
> add logic just for the Fixes tag (since it conveniently follows a set 
> pattern), but finding a universal fix for split footers will be more 
> difficult.
> 
> I'll see what I can do.

But (what am I missing?) the Fixes: tag has been split over 2 lines in
the original message ... on lore and my copy.  There is nothing for b4
to do here, the author needs to do this right.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  1:56   ` Konstantin Ryabitsev
@ 2020-06-27  2:25     ` Jens Axboe
  2020-06-27  5:12       ` Stephen Rothwell
  2020-06-27  5:01     ` Stephen Rothwell
  1 sibling, 1 reply; 27+ messages in thread
From: Jens Axboe @ 2020-06-27  2:25 UTC (permalink / raw)
  To: Konstantin Ryabitsev
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Pavel Begunkov

On 6/26/20 7:56 PM, Konstantin Ryabitsev wrote:
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>>>
>>> Fixes tag
>>>
>>>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> has these problem(s):
>>>
>>>   - Subject has leading but no trailing parentheses
>>>   - Subject has leading but no trailing quotes
>>>
>>> Please do not split Fixes tags over more than one line.
>>
>> Gah, that's b4 messing it up. I've actually seen this before, but
>> I caught it. If you look at the actual commit, this is what the b4
>> output ends up being for the fixes line:
>>
>> [snip]
>> io_kiocb's result and iopoll_completed")
>>
>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>
>> even though it's correct in the email. I'm guessing some issue having to
>> do with the longer line?
> 
> Yeah, I'll try to see if there's something I can do here, but it's going 
> to be largely guesswork. Here's the original email:
> 
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
> 
> The Fixes: footer really does get split into two. It's not that hard to 
> add logic just for the Fixes tag (since it conveniently follows a set 
> pattern), but finding a universal fix for split footers will be more 
> difficult.

Right, but that's what git format-patch does when the line is long. Do
we have other tags where that's a concern? If not, then the fix should
be solid I think.

> I'll see what I can do.

Thanks!

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-27  1:32 ` Jens Axboe
@ 2020-06-27  1:56   ` Konstantin Ryabitsev
  2020-06-27  2:25     ` Jens Axboe
  2020-06-27  5:01     ` Stephen Rothwell
  0 siblings, 2 replies; 27+ messages in thread
From: Konstantin Ryabitsev @ 2020-06-27  1:56 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Pavel Begunkov

On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> > 
> > Fixes tag
> > 
> >   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > 
> > has these problem(s):
> > 
> >   - Subject has leading but no trailing parentheses
> >   - Subject has leading but no trailing quotes
> > 
> > Please do not split Fixes tags over more than one line.
> 
> Gah, that's b4 messing it up. I've actually seen this before, but
> I caught it. If you look at the actual commit, this is what the b4
> output ends up being for the fixes line:
> 
> [snip]
> io_kiocb's result and iopoll_completed")
> 
> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> 
> even though it's correct in the email. I'm guessing some issue having to
> do with the longer line?

Yeah, I'll try to see if there's something I can do here, but it's going 
to be largely guesswork. Here's the original email:

https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw

The Fixes: footer really does get split into two. It's not that hard to 
add logic just for the Fixes tag (since it conveniently follows a set 
pattern), but finding a universal fix for split footers will be more 
difficult.

I'll see what I can do.

-K

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2020-06-26 23:07 Stephen Rothwell
@ 2020-06-27  1:32 ` Jens Axboe
  2020-06-27  1:56   ` Konstantin Ryabitsev
  0 siblings, 1 reply; 27+ messages in thread
From: Jens Axboe @ 2020-06-27  1:32 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Pavel Begunkov, Konstantin Ryabitsev

On 6/26/20 5:07 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> 
> Fixes tag
> 
>   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Gah, that's b4 messing it up. I've actually seen this before, but
I caught it. If you look at the actual commit, this is what the b4
output ends up being for the fixes line:

[snip]
io_kiocb's result and iopoll_completed")

Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize

even though it's correct in the email. I'm guessing some issue having to
do with the longer line?

CC Konstantin.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-06-26 23:07 Stephen Rothwell
  2020-06-27  1:32 ` Jens Axboe
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2020-06-26 23:07 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Pavel Begunkov


[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi all,

In commit

  cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")

Fixes tag

  Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-05-28 21:10 Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2020-05-28 21:10 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Christoph Hellwig


[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Hi all,

In commit

  dc35ada4251f ("block: fix a warning when blkdev.h is included for !CONFIG_BLOCK builds")

Fixes tag

  Fixes: 956d510ee78 ("block: add disk/bio-based accounting helpers")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2020-03-22 14:08 Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2020-03-22 14:08 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zhiqiang Liu,
	Feilong Lin


[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Hi all,

In commit

  2f95fa5c955d ("block, bfq: fix use-after-free in bfq_idle_slice_timer_body")

Fixes tag

  Fixes: aee69d78d ("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-10-24  6:16 Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2019-10-24  6:16 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jackie Liu


[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi all,

In commit

  f131f240623a ("io_uring: cq entries should be equal to (or greater) than sq entries")

Fixes tag

  Fixes: 95d8765bd9f2 ("io_uring: allow application controlled CQ ring size")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: f3cbc97703c5 ("io_uring: allow application controlled CQ ring size")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-10-10 17:36 ` Bart Van Assche
@ 2019-10-11  0:42   ` Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2019-10-11  0:42 UTC (permalink / raw)
  To: Bart Van Assche
  Cc: Jens Axboe, Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Hi Bart,

On Thu, 10 Oct 2019 10:36:36 -0700 Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> > 
> >    Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
> 
> The above fixes tag follows the recommended format except that it is 
> followed by a kernel version number. Is there a recommended format for 
> embedding the kernel version number in a Fixes: tag? I think that 
> information is useful. I haven't found any recommendations for how to do 
> that in Documentation/process/submitting-patches.rst.

I have not seen any recommended way to do that, but there is no
necessity to embed the version as it can easily be derived:

$ git describe --contains e34cbd307477
v4.10-rc1~153^2~94

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-10-07 20:16 Stephen Rothwell
@ 2019-10-10 17:36 ` Bart Van Assche
  2019-10-11  0:42   ` Stephen Rothwell
  0 siblings, 1 reply; 27+ messages in thread
From: Bart Van Assche @ 2019-10-10 17:36 UTC (permalink / raw)
  To: Stephen Rothwell, Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

On 10/7/19 1:16 PM, Stephen Rothwell wrote:
> In commit
> 
>    1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")
> 
> Fixes tag
> 
>    Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).
> 
> has these problem(s):
> 
>    - Subject has leading but no trailing quotes
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Hi Stephen,

The above fixes tag follows the recommended format except that it is 
followed by a kernel version number. Is there a recommended format for 
embedding the kernel version number in a Fixes: tag? I think that 
information is useful. I haven't found any recommendations for how to do 
that in Documentation/process/submitting-patches.rst.

Thanks,

Bart.



^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-10-07 20:16 Stephen Rothwell
  2019-10-10 17:36 ` Bart Van Assche
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2019-10-07 20:16 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bart Van Assche


[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Hi all,

In commit

  1d200e9d6f63 ("block: Fix writeback throttling W=1 compiler warnings")

Fixes tag

  Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism"; v4.10).

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-09-10 14:57 Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2019-09-10 14:57 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jackie Liu


[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi all,

In commit

  8776f3fa15a5 ("io_uring: fix wrong sequence setting logic")

Fixes tag

  Fixes: de0617e4671 ("io_uring: add support for marking commands as draining")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-07-11 22:03 ` Jens Axboe
@ 2019-07-12  8:47   ` Minwoo Im
  0 siblings, 0 replies; 27+ messages in thread
From: Minwoo Im @ 2019-07-12  8:47 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

On 19-07-11 16:03:22, Jens Axboe wrote:
> On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >    8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> > 
> > Fixes tag
> > 
> >    Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> > 
> > has these problem(s):
> > 
> >    - SHA1 should be at least 12 digits long
> >      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >      or later) just making sure it is not set (or set to "auto").
> >    - Subject has leading but no trailing parentheses
> >    - Subject has leading but no trailing quotes
> > 
> > Please do not split Fixes tags over more than one line.  Also do not
> > include blank lines among the tags.

I'm sorry for noises here.  I will keep that in mind.

Thanks Stephen,

> 
> I should have caught that. Since it's top-of-tree and recent, I'll
> amend it.

Jens,  I will do it from the next time.  Thanks for ammend.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: linux-next: Fixes tag needs some work in the block tree
  2019-07-11 21:35 Stephen Rothwell
@ 2019-07-11 22:03 ` Jens Axboe
  2019-07-12  8:47   ` Minwoo Im
  0 siblings, 1 reply; 27+ messages in thread
From: Jens Axboe @ 2019-07-11 22:03 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Minwoo Im

On 7/11/19 3:35 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    8f3858763d33 ("nvme: fix NULL deref for fabrics options")
> 
> Fixes tag
> 
>    Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests
> 
> has these problem(s):
> 
>    - SHA1 should be at least 12 digits long
>      Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>      or later) just making sure it is not set (or set to "auto").
>    - Subject has leading but no trailing parentheses
>    - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.  Also do not
> include blank lines among the tags.

I should have caught that. Since it's top-of-tree and recent, I'll
amend it.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-07-11 21:35 Stephen Rothwell
  2019-07-11 22:03 ` Jens Axboe
  0 siblings, 1 reply; 27+ messages in thread
From: Stephen Rothwell @ 2019-07-11 21:35 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Minwoo Im


[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi all,

In commit

  8f3858763d33 ("nvme: fix NULL deref for fabrics options")

Fixes tag

  Fixes: 958f2a0f8 ("nvme-tcp: set the STABLE_WRITES flag when data digests

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also do not
include blank lines among the tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* linux-next: Fixes tag needs some work in the block tree
@ 2019-02-21 20:39 Stephen Rothwell
  0 siblings, 0 replies; 27+ messages in thread
From: Stephen Rothwell @ 2019-02-21 20:39 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ming Lei


[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi Jens,

In commit

  8f4e80da764e ("block: bounce: make sure that bvec table is updated")

Fixes tag

  Fixes: 6dc4f100c ("block: allow bio_for_each_segment_all() to iterate over multi-page bvec")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, back to index

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 22:08 linux-next: Fixes tag needs some work in the block tree Stephen Rothwell
2020-07-29 22:12 ` Stephen Rothwell
2020-07-30 15:04   ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2020-06-28 22:05 Stephen Rothwell
2020-06-29 16:21 ` Pavel Begunkov
2020-06-29 16:25   ` Jens Axboe
2020-06-29 22:36     ` Stephen Rothwell
2020-06-29 22:45       ` Jens Axboe
2020-06-26 23:07 Stephen Rothwell
2020-06-27  1:32 ` Jens Axboe
2020-06-27  1:56   ` Konstantin Ryabitsev
2020-06-27  2:25     ` Jens Axboe
2020-06-27  5:12       ` Stephen Rothwell
2020-06-28 13:38         ` Jens Axboe
2020-06-27  5:01     ` Stephen Rothwell
2020-06-27 11:18       ` Pavel Begunkov
2020-05-28 21:10 Stephen Rothwell
2020-03-22 14:08 Stephen Rothwell
2019-10-24  6:16 Stephen Rothwell
2019-10-07 20:16 Stephen Rothwell
2019-10-10 17:36 ` Bart Van Assche
2019-10-11  0:42   ` Stephen Rothwell
2019-09-10 14:57 Stephen Rothwell
2019-07-11 21:35 Stephen Rothwell
2019-07-11 22:03 ` Jens Axboe
2019-07-12  8:47   ` Minwoo Im
2019-02-21 20:39 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git