From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: linux-next: Tree for Aug 1 Date: Thu, 2 Aug 2018 16:40:10 +0000 Message-ID: <9329f50c734eec5fa994ea652890f017a88625c2.camel@wdc.com> References: <20180801175852.36549130@canb.auug.org.au> <20180801224813.GA13074@roeck-us.net> <1533163965.3158.1.camel@HansenPartnership.com> <20180801234727.GA3762@roeck-us.net> <1533168205.3158.12.camel@HansenPartnership.com> <171b2cdc-2e74-2b3c-e5f5-c656a196601a@roeck-us.net> <20180802162654.GA8928@ming.t460p> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-7" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20180802162654.GA8928@ming.t460p> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: "linux@roeck-us.net" , "ming.lei@redhat.com" Cc: "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tom.leiming@gmail.com" , "hch@lst.de" , "axboe@kernel.dk" , "linux-scsi@vger.kernel.org" , "sfr@canb.auug.org.au" , "linux-next@vger.kernel.org" , "James.Bottomley@hansenpartnership.com" , "josef@toxicpanda.com" , "tj@kernel.org" List-Id: linux-next.vger.kernel.org On Fri, 2018-08-03 at 00:27 +-0800, Ming Lei wrote: +AD4- This issue can be fixed by reverting d250bf4e776ff09d5 (+ACI-blk-mq: = only iterate over +AD4- inflight requests in blk+AF8-mq+AF8-tagset+AF8-busy+AF8-iter+ACI-). +AD4-=20 +AD4- This patch looks wrong, because 'blk+AF8-mq+AF8-rq+AF8-state(rq) +AD0= APQ- MQ+AF8-RQ+AF8-IN+AF8-FLIGHT' +AD4- isn't completely same with 'blk+AF8-mq+AF8-request+AF8-started(req)'. Please test the following change instead of reverting the commit mentioned above: diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index 09b2ee6694fb..25a0583d8b4c 100644 --- a/block/blk-mq-tag.c +-+-+- b/block/blk-mq-tag.c +AEAAQA- -271,7 +-271,7 +AEAAQA- static bool bt+AF8-tags+AF8-iter(struct sb= itmap +ACo-bitmap, unsigned int bitnr, void +ACo-data) +ACo- test and set the bit before assining -+AD4-rqs+AFsAXQ-. +ACo-/ rq +AD0- tags-+AD4-rqs+AFs-bitnr+AF0AOw- - if (rq +ACYAJg- blk+AF8-mq+AF8-rq+AF8-state(rq) +AD0APQ- MQ+AF8-RQ+AF8-IN= +AF8-FLIGHT) +- if (rq +ACYAJg- blk+AF8-mq+AF8-rq+AF8-state(rq) +ACEAPQ- MQ+AF8-RQ+AF8-I= DLE) iter+AF8-data-+AD4-fn(rq, iter+AF8-data-+AD4-data, reserved)+ADs- =20 return true+ADs- Thanks, Bart.