Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the pm tree
Date: Wed, 29 Oct 2014 16:56:31 +0100
Message-ID: <9916235.6HBFDgl0sY@vostro.rjw.lan> (raw)
In-Reply-To: <20141029152338.GA9571@wfg-t540p.sh.intel.com>

On Wednesday, October 29, 2014 11:23:38 PM Fengguang Wu wrote:
> On Wed, Oct 29, 2014 at 03:55:19PM +0100, Rafael J. Wysocki wrote:
> > On Wednesday, October 29, 2014 01:51:29 PM Stephen Rothwell wrote:
> > > Hi Rafael,
> > 
> > Hi,
> > 
> > > After merging the pm tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced this warning:
> > > 
> > > drivers/of/base.c: In function 'of_property_read_string_array':
> > > drivers/of/base.c:1472:1: warning: control reaches end of non-void function [-Wreturn-type]
> > >  }
> > >  ^
> > > 
> > > Introduced by commit ef23586751cd ("Driver core: Unified device
> > > properties interface for platform firmware").
> > 
> > Thanks for reporting this!
> > 
> > > Please don't ignore new warnings ...
> > 
> > I don't as a rule.  I'm not sure why I haven't seen that before (and the kbuild
> > robot reports BUILD SUCCESS for that branch).
> 
> I do find the build error id:
> 
> -rw-rw-r-- 1 kbuild kbuild  272 2014-10-29 23:11 /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
> 
> However there happens to be an old one half year ago. Since I never
> delete old warnings, it prevents the reporting of the new warning on
> your tree..
> 
> % cat /kbuild-tests/build-error/drivers-of-base.c:warning:control-reaches-end-of-non-void-function
> drivers/of/base.c:1147:1: warning: control reaches end of non-void function [-Wreturn-type]
> 
> 2014-04-17 02:59:49 lkp-ib04 socfpga-nex:socfpga_for_next_dts_overlays:bdb1f0c2cbe39db8f4a2ac4794001ba2e99cb65b i386-randconfig-i001-0414 f11752c03ccfd747a1f0740955682a
> 304933361c                         
> 
> The easiest way to fix it is to delete any old error/warnings that
> have been *inactive* for more than 2 months (which means they are
> likely fixed).

That could be done more aggressively even in my view.  If something is inactive
for two weeks, then it probably has been fixed (this way or another).

Kind regards,
Rafael

  reply index

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29  2:51 Stephen Rothwell
2014-10-29 14:55 ` Rafael J. Wysocki
2014-10-29 15:23   ` Fengguang Wu
2014-10-29 15:56     ` Rafael J. Wysocki [this message]
2014-11-17  2:44 Stephen Rothwell
2014-11-17 11:31 ` Paul Bolle
2014-11-17 23:14   ` Rafael J. Wysocki
2014-11-17 23:45     ` Paul Bolle
2014-11-18  0:34       ` Rafael J. Wysocki
2016-11-13 23:40 Stephen Rothwell
2016-11-14  0:03 ` Rafael J. Wysocki
2016-11-14  8:49   ` Akshay Adiga
2018-04-09  1:24 Stephen Rothwell
2018-04-10  7:05 ` Rafael J. Wysocki
2018-06-08  0:30 Stephen Rothwell
2018-06-08  9:14 ` Rafael J. Wysocki
2018-07-30  2:00 Stephen Rothwell
2018-07-30  7:24 ` Sakari Ailus
2018-07-30  7:30   ` jacopo mondi
2018-07-31  0:39   ` Stephen Rothwell
2019-01-23 23:45 Stephen Rothwell
2019-07-11  1:31 Stephen Rothwell
     [not found] <201907111346291954773@zte.com.cn>
2019-07-11 12:26 ` Rafael J. Wysocki
2019-10-14 23:08 Stephen Rothwell
2019-10-15  8:23 ` Andy Shevchenko
2019-10-15  9:41   ` Rafael J. Wysocki
2020-01-19 23:40 Stephen Rothwell

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9916235.6HBFDgl0sY@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git