* linux-next: build failure after merge of the hwmon-staging tree
@ 2020-04-28 6:36 Stephen Rothwell
2020-04-28 13:19 ` Guenter Roeck
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2020-04-28 6:36 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andrej Picej
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/hwmon/lm70.c: In function 'lm70_probe':
drivers/hwmon/lm70.c:186:34: error: 'lm70_acpi_ids' undeclared (first use in this function); did you mean 'lm70_of_ids'?
186 | acpi_match = acpi_match_device(lm70_acpi_ids, &spi->dev);
| ^~~~~~~~~~~~~
| lm70_of_ids
Caused by commit
02b925a9104d ("hwmon: (lm70) Add support for ACPI")
CONFIG_ACPI is not set.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build failure after merge of the hwmon-staging tree
2020-04-28 6:36 linux-next: build failure after merge of the hwmon-staging tree Stephen Rothwell
@ 2020-04-28 13:19 ` Guenter Roeck
0 siblings, 0 replies; 17+ messages in thread
From: Guenter Roeck @ 2020-04-28 13:19 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andrej Picej
[-- Attachment #1.1: Type: text/plain, Size: 785 bytes --]
On 4/27/20 11:36 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/hwmon/lm70.c: In function 'lm70_probe':
> drivers/hwmon/lm70.c:186:34: error: 'lm70_acpi_ids' undeclared (first use in this function); did you mean 'lm70_of_ids'?
> 186 | acpi_match = acpi_match_device(lm70_acpi_ids, &spi->dev);
> | ^~~~~~~~~~~~~
> | lm70_of_ids
>
> Caused by commit
>
> 02b925a9104d ("hwmon: (lm70) Add support for ACPI")
>
> CONFIG_ACPI is not set.
>
> I have reverted that commit for today.
>
I fixed it up. And I'll have to add test builds with CONFIG_ACPI=n.
Guenter
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2023-07-27 5:41 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2023-07-27 5:41 UTC (permalink / raw)
To: Guenter Roeck
Cc: Andre Werner, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (htmldocs)
failed like this:
Sphinx parallel build error:
docutils.utils.SystemMessage: /home/sfr/next/next/Documentation/hwmon/hs3001.rst:34: (SEVERE/4) Missing matching underline for section title overline.
===============================================================================
temp1_input: temperature input
humidity1_input: humidity input
Caused by commit
33faa6fcc93f ("hwmon: Add driver for Renesas HS3001")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build failure after merge of the hwmon-staging tree
2023-01-24 22:24 Stephen Rothwell
@ 2023-01-24 22:27 ` Guenter Roeck
0 siblings, 0 replies; 17+ messages in thread
From: Guenter Roeck @ 2023-01-24 22:27 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mario Kicherer, Linux Kernel Mailing List, Linux Next Mailing List
On 1/24/23 14:24, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/mc34vr500: struct of_device_id is 200 bytes. The last of 1 is:
> 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x6e 0x78 0x70 0x2c 0x6d 0x63 0x33 0x34 0x76 0x72 0x35 0x30 0x30 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
> FATAL: modpost: drivers/hwmon/mc34vr500: struct of_device_id is not terminated with a NULL entry!
>
> Caused by commit
>
> d4a6ae044045 ("hwmon: add initial NXP MC34VR500 PMIC monitoring support")
>
> I have used the hwmon-staging tree from next-20230124 for today.
>
Already fixed. Sorry for the trouble.
Guenter
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2023-01-24 22:24 Stephen Rothwell
2023-01-24 22:27 ` Guenter Roeck
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2023-01-24 22:24 UTC (permalink / raw)
To: Guenter Roeck
Cc: Mario Kicherer, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/mc34vr500: struct of_device_id is 200 bytes. The last of 1 is:
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x6e 0x78 0x70 0x2c 0x6d 0x63 0x33 0x34 0x76 0x72 0x35 0x30 0x30 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
FATAL: modpost: drivers/hwmon/mc34vr500: struct of_device_id is not terminated with a NULL entry!
Caused by commit
d4a6ae044045 ("hwmon: add initial NXP MC34VR500 PMIC monitoring support")
I have used the hwmon-staging tree from next-20230124 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: linux-next: build failure after merge of the hwmon-staging tree
2022-08-30 23:30 Stephen Rothwell
@ 2022-08-31 12:03 ` Michael Shych
0 siblings, 0 replies; 17+ messages in thread
From: Michael Shych @ 2022-08-31 12:03 UTC (permalink / raw)
To: Stephen Rothwell, Guenter Roeck
Cc: Uwe Kleine-König, Wolfram Sang, Linux Kernel Mailing List,
Linux Next Mailing List
> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Wednesday, August 31, 2022 2:30 AM
> To: Guenter Roeck <linux@roeck-us.net>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>; Wolfram Sang
> <wsa@kernel.org>; Michael Shych <michaelsh@nvidia.com>; Linux Kernel
> Mailing List <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-
> next@vger.kernel.org>
> Subject: linux-next: build failure after merge of the hwmon-staging tree
>
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/emc2305.c:615:21: error: initialization of 'void (*)(struct
> i2c_client *)' from incompatible pointer type 'int (*)(struct i2c_client *)' [-
> Werror=incompatible-pointer-types]
> 615 | .remove = emc2305_remove,
> | ^~~~~~~~~~~~~~
> drivers/hwmon/emc2305.c:615:21: note: (near initialization for
> 'emc2305_driver.remove')
>
> Caused by commit
>
> 324745b64626 ("hwmon: (emc2305) add support for EMC2301/2/3/5 RPM-
> based PWM Fan Speed Controller.")
>
> interacting with commit
>
> ed5c2f5fd10d ("i2c: Make remove callback return void")
>
> from the i2c tree.
>
> From Uwe:
>
> > There is an immutable tag that can be merged into your tree to resolve
> > the conflict before you send your changes to Linux at
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
> >i2c/make_remove_callback_void-immutable
>
> I have applied the following merge fix patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 31 Aug 2022 09:22:50 +1000
> Subject: [PATCH] hwmon: (emc2305) fix up for "i2c: Make remove callback
> return void"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Michael Shych <michaelsh@nvidia.com>
> ---
> drivers/hwmon/emc2305.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/emc2305.c b/drivers/hwmon/emc2305.c index
> 9f6546ea3d69..df4c5816f661 100644
> --- a/drivers/hwmon/emc2305.c
> +++ b/drivers/hwmon/emc2305.c
> @@ -597,13 +597,12 @@ static int emc2305_probe(struct i2c_client *client,
> const struct i2c_device_id *
> return 0;
> }
>
> -static int emc2305_remove(struct i2c_client *client)
> +static void emc2305_remove(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
>
> if (IS_REACHABLE(CONFIG_THERMAL))
> emc2305_unset_tz(dev);
> - return 0;
> }
>
> static struct i2c_driver emc2305_driver = {
> --
> 2.35.1
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2022-08-30 23:30 Stephen Rothwell
2022-08-31 12:03 ` Michael Shych
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2022-08-30 23:30 UTC (permalink / raw)
To: Guenter Roeck
Cc: Uwe Kleine-König, Wolfram Sang, Michael Shych,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/emc2305.c:615:21: error: initialization of 'void (*)(struct i2c_client *)' from incompatible pointer type 'int (*)(struct i2c_client *)' [-Werror=incompatible-pointer-types]
615 | .remove = emc2305_remove,
| ^~~~~~~~~~~~~~
drivers/hwmon/emc2305.c:615:21: note: (near initialization for 'emc2305_driver.remove')
Caused by commit
324745b64626 ("hwmon: (emc2305) add support for EMC2301/2/3/5 RPM-based PWM Fan Speed Controller.")
interacting with commit
ed5c2f5fd10d ("i2c: Make remove callback return void")
from the i2c tree.
From Uwe:
> There is an immutable tag that can be merged into your tree to
> resolve the conflict before you send your changes to Linux at
>
> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/make_remove_callback_void-immutable
I have applied the following merge fix patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 31 Aug 2022 09:22:50 +1000
Subject: [PATCH] hwmon: (emc2305) fix up for "i2c: Make remove callback return void"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/hwmon/emc2305.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hwmon/emc2305.c b/drivers/hwmon/emc2305.c
index 9f6546ea3d69..df4c5816f661 100644
--- a/drivers/hwmon/emc2305.c
+++ b/drivers/hwmon/emc2305.c
@@ -597,13 +597,12 @@ static int emc2305_probe(struct i2c_client *client, const struct i2c_device_id *
return 0;
}
-static int emc2305_remove(struct i2c_client *client)
+static void emc2305_remove(struct i2c_client *client)
{
struct device *dev = &client->dev;
if (IS_REACHABLE(CONFIG_THERMAL))
emc2305_unset_tz(dev);
- return 0;
}
static struct i2c_driver emc2305_driver = {
--
2.35.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2022-05-10 12:26 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2022-05-10 12:26 UTC (permalink / raw)
To: Guenter Roeck
Cc: Zev Weiss, Denis Pauk, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2912 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (powerpc
allyesconfig) failed like this:
ld: drivers/hwmon/nct6775-platform.o: in function `.nct6775_wmi_reg_write':
nct6775-platform.c:(.text.nct6775_wmi_reg_write+0x38): undefined reference to `.nct6775_reg_is_word_sized'
ld: drivers/hwmon/nct6775-platform.o: in function `.nct6775_wmi_reg_read':
nct6775-platform.c:(.text.nct6775_wmi_reg_read+0x38): undefined reference to `.nct6775_reg_is_word_sized'
ld: drivers/hwmon/nct6775-platform.o: in function `.nct6775_resume':
nct6775-platform.c:(.text.nct6775_resume+0x61c): undefined reference to `.nct6775_reg_is_word_sized'
ld: drivers/hwmon/nct6775-platform.o: in function `.nct6775_platform_probe':
nct6775-platform.c:(.text.nct6775_platform_probe+0x14c): undefined reference to `.nct6775_probe'
ld: drivers/hwmon/nct6775-platform.o: in function `.nct6775_reg_read':
nct6775-platform.c:(.text.nct6775_reg_read+0x5c): undefined reference to `.nct6775_reg_is_word_sized'
ld: drivers/hwmon/nct6775-platform.o: in function `.nct6775_reg_write':
nct6775-platform.c:(.text.nct6775_reg_write+0x5c): undefined reference to `.nct6775_reg_is_word_sized'
ld: drivers/hwmon/nct6775-platform.o:(.data.rel.sensor_dev_attr_beep_enable+0x28): undefined reference to `nct6775_show_beep'
ld: drivers/hwmon/nct6775-platform.o:(.data.rel.sensor_dev_attr_beep_enable+0x30): undefined reference to `nct6775_store_beep'
ld: drivers/hwmon/nct6775-platform.o:(.data.rel.sensor_dev_attr_intrusion0_alarm+0x28): undefined reference to `nct6775_show_alarm'
ld: drivers/hwmon/nct6775-platform.o:(.data.rel.sensor_dev_attr_intrusion0_beep+0x28): undefined reference to `nct6775_show_beep'
ld: drivers/hwmon/nct6775-platform.o:(.data.rel.sensor_dev_attr_intrusion0_beep+0x30): undefined reference to `nct6775_store_beep'
ld: drivers/hwmon/nct6775-platform.o:(.data.rel.sensor_dev_attr_intrusion1_alarm+0x28): undefined reference to `nct6775_show_alarm'
ld: drivers/hwmon/nct6775-platform.o:(.data.rel.sensor_dev_attr_intrusion1_beep+0x28): undefined reference to `nct6775_show_beep'
ld: drivers/hwmon/nct6775-platform.o:(.data.rel.sensor_dev_attr_intrusion1_beep+0x30): undefined reference to `nct6775_store_beep'
ld: drivers/hwmon/nct6775-i2c.o: in function `.nct6775_i2c_read':
nct6775-i2c.c:(.text.nct6775_i2c_read+0x108): undefined reference to `.nct6775_reg_is_word_sized'
ld: drivers/hwmon/nct6775-i2c.o: in function `.nct6775_i2c_probe':
nct6775-i2c.c:(.text.nct6775_i2c_probe+0x134): undefined reference to `.nct6775_probe'
Probably caused by commit
a2105efee6e7 ("hwmon: (nct6775) Split core and platform driver")
I have reverted that commit for today - and the following commits
4dcbcf34a249 ("hwmon: (nct6775) add ASUS PRO H410T / PRIME H410M-R / ROG X570-E GAMING WIFI II")
58f1d9ebfce6 ("hwmon: (nct6775) Add i2c driver")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build failure after merge of the hwmon-staging tree
2020-10-01 2:53 Stephen Rothwell
@ 2020-10-01 15:09 ` Guenter Roeck
0 siblings, 0 replies; 17+ messages in thread
From: Guenter Roeck @ 2020-10-01 15:09 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Vadim Pasternak, Linux Next Mailing List, Linux Kernel Mailing List
On Thu, Oct 01, 2020 at 12:53:10PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/pmbus/mp2975.c: In function 'mp2975_probe':
> drivers/hwmon/pmbus/mp2975.c:740:32: error: passing argument 2 of 'pmbus_do_probe' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 740 | return pmbus_do_probe(client, id, info);
> | ^~
> | |
> | const struct i2c_device_id *
> In file included from drivers/hwmon/pmbus/mp2975.c:13:
> drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info *' but argument is of type 'const struct i2c_device_id *'
> 492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/hwmon/pmbus/mp2975.c:740:9: error: too many arguments to function 'pmbus_do_probe'
> 740 | return pmbus_do_probe(client, id, info);
> | ^~~~~~~~~~~~~~
> In file included from drivers/hwmon/pmbus/mp2975.c:13:
> drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
> 492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
> | ^~~~~~~~~~~~~~
>
> Caused by commit
>
> dd38ac315b23 ("hwmon: (pmbus) Add support for MPS Multi-phase mp2975 controller")
>
Oops, sorry, got caught in API changes. Fixed.
Guenter
> I have used the hwmon-staging tree from next-20200930 for today.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2020-10-01 2:53 Stephen Rothwell
2020-10-01 15:09 ` Guenter Roeck
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2020-10-01 2:53 UTC (permalink / raw)
To: Guenter Roeck
Cc: Vadim Pasternak, Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/pmbus/mp2975.c: In function 'mp2975_probe':
drivers/hwmon/pmbus/mp2975.c:740:32: error: passing argument 2 of 'pmbus_do_probe' from incompatible pointer type [-Werror=incompatible-pointer-types]
740 | return pmbus_do_probe(client, id, info);
| ^~
| |
| const struct i2c_device_id *
In file included from drivers/hwmon/pmbus/mp2975.c:13:
drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info *' but argument is of type 'const struct i2c_device_id *'
492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/hwmon/pmbus/mp2975.c:740:9: error: too many arguments to function 'pmbus_do_probe'
740 | return pmbus_do_probe(client, id, info);
| ^~~~~~~~~~~~~~
In file included from drivers/hwmon/pmbus/mp2975.c:13:
drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
| ^~~~~~~~~~~~~~
Caused by commit
dd38ac315b23 ("hwmon: (pmbus) Add support for MPS Multi-phase mp2975 controller")
I have used the hwmon-staging tree from next-20200930 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build failure after merge of the hwmon-staging tree
2020-08-24 0:28 Stephen Rothwell
@ 2020-08-24 7:01 ` Guenter Roeck
0 siblings, 0 replies; 17+ messages in thread
From: Guenter Roeck @ 2020-08-24 7:01 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Stephen Kitt,
Alexandru Tachici
[-- Attachment #1.1: Type: text/plain, Size: 1764 bytes --]
On 8/23/20 5:28 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/pmbus/adm1266.c: In function 'adm1266_probe':
> drivers/hwmon/pmbus/adm1266.c:478:31: error: passing argument 2 of 'pmbus_do_probe' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 478 | ret = pmbus_do_probe(client, id, &data->info);
> | ^~
> | |
> | const struct i2c_device_id *
> In file included from drivers/hwmon/pmbus/adm1266.c:20:
> drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info *' but argument is of type 'const struct i2c_device_id *'
> 492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/hwmon/pmbus/adm1266.c:478:8: error: too many arguments to function 'pmbus_do_probe'
> 478 | ret = pmbus_do_probe(client, id, &data->info);
> | ^~~~~~~~~~~~~~
> In file included from drivers/hwmon/pmbus/adm1266.c:20:
> drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
> 492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
> | ^~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Caused by commit
>
> 9832ecffd8f8 ("hwmon: (pmbus) Add support for ADM1266")
>
> interacting with commit
>
> d46dc459db38 ("hwmon (pmbus) use simple i2c probe function")
>
> I have used the hwmon-staging tree from next-20200821 for today.
>
Fixed. Sorry for the trouble.
Guenter
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2020-08-24 0:28 Stephen Rothwell
2020-08-24 7:01 ` Guenter Roeck
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2020-08-24 0:28 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Stephen Kitt,
Alexandru Tachici
[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/pmbus/adm1266.c: In function 'adm1266_probe':
drivers/hwmon/pmbus/adm1266.c:478:31: error: passing argument 2 of 'pmbus_do_probe' from incompatible pointer type [-Werror=incompatible-pointer-types]
478 | ret = pmbus_do_probe(client, id, &data->info);
| ^~
| |
| const struct i2c_device_id *
In file included from drivers/hwmon/pmbus/adm1266.c:20:
drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info *' but argument is of type 'const struct i2c_device_id *'
492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/hwmon/pmbus/adm1266.c:478:8: error: too many arguments to function 'pmbus_do_probe'
478 | ret = pmbus_do_probe(client, id, &data->info);
| ^~~~~~~~~~~~~~
In file included from drivers/hwmon/pmbus/adm1266.c:20:
drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Caused by commit
9832ecffd8f8 ("hwmon: (pmbus) Add support for ADM1266")
interacting with commit
d46dc459db38 ("hwmon (pmbus) use simple i2c probe function")
I have used the hwmon-staging tree from next-20200821 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build failure after merge of the hwmon-staging tree
2020-03-22 23:37 Stephen Rothwell
@ 2020-03-22 23:45 ` Guenter Roeck
0 siblings, 0 replies; 17+ messages in thread
From: Guenter Roeck @ 2020-03-22 23:45 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Grant Peltier
[-- Attachment #1.1: Type: text/plain, Size: 2264 bytes --]
On 3/22/20 4:37 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/pmbus/isl68137.c: In function 'raa_dmpvr2_read_word_data':
> drivers/hwmon/pmbus/isl68137.c:125:9: error: too few arguments to function 'pmbus_read_word_data'
> 125 | ret = pmbus_read_word_data(client, page, RAA_DMPVR2_READ_VMON);
> | ^~~~~~~~~~~~~~~~~~~~
> In file included from drivers/hwmon/pmbus/isl68137.c:19:
> drivers/hwmon/pmbus/pmbus.h:466:5: note: declared here
> 466 | int pmbus_read_word_data(struct i2c_client *client, int page, int phase,
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/hwmon/pmbus/isl68137.c: In function 'isl68137_probe':
> drivers/hwmon/pmbus/isl68137.c:199:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
> 199 | info->read_word_data = raa_dmpvr2_read_word_data;
> | ^
> drivers/hwmon/pmbus/isl68137.c:203:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
> 203 | info->read_word_data = raa_dmpvr2_read_word_data;
> | ^
> drivers/hwmon/pmbus/isl68137.c:206:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
> 206 | info->read_word_data = raa_dmpvr2_read_word_data;
> | ^
> drivers/hwmon/pmbus/isl68137.c:216:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
> 216 | info->read_word_data = raa_dmpvr2_read_word_data;
> | ^
>
> Caused by commit
>
> 96c72647bc37 ("hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase")
>
Weird, 0day reported build success. Or at least I thought so.
Anyway, fixed.
Guenter
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2020-03-22 23:37 Stephen Rothwell
2020-03-22 23:45 ` Guenter Roeck
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2020-03-22 23:37 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Grant Peltier
[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/pmbus/isl68137.c: In function 'raa_dmpvr2_read_word_data':
drivers/hwmon/pmbus/isl68137.c:125:9: error: too few arguments to function 'pmbus_read_word_data'
125 | ret = pmbus_read_word_data(client, page, RAA_DMPVR2_READ_VMON);
| ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/hwmon/pmbus/isl68137.c:19:
drivers/hwmon/pmbus/pmbus.h:466:5: note: declared here
466 | int pmbus_read_word_data(struct i2c_client *client, int page, int phase,
| ^~~~~~~~~~~~~~~~~~~~
drivers/hwmon/pmbus/isl68137.c: In function 'isl68137_probe':
drivers/hwmon/pmbus/isl68137.c:199:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
199 | info->read_word_data = raa_dmpvr2_read_word_data;
| ^
drivers/hwmon/pmbus/isl68137.c:203:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
203 | info->read_word_data = raa_dmpvr2_read_word_data;
| ^
drivers/hwmon/pmbus/isl68137.c:206:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
206 | info->read_word_data = raa_dmpvr2_read_word_data;
| ^
drivers/hwmon/pmbus/isl68137.c:216:24: error: assignment to 'int (*)(struct i2c_client *, int, int, int)' from incompatible pointer type 'int (*)(struct i2c_client *, int, int)' [-Werror=incompatible-pointer-types]
216 | info->read_word_data = raa_dmpvr2_read_word_data;
| ^
Caused by commit
96c72647bc37 ("hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase")
I have used the version of the hwmon-staging from next-20200320 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build failure after merge of the hwmon-staging tree
2019-02-25 23:55 Stephen Rothwell
@ 2019-02-26 0:11 ` Guenter Roeck
0 siblings, 0 replies; 17+ messages in thread
From: Guenter Roeck @ 2019-02-26 0:11 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Linus Walleij
On Tue, Feb 26, 2019 at 10:55:47AM +1100, Stephen Rothwell wrote:
> Hi Guenter,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
Ah, sorry for that. I had fixed this up, but forgot to push.
Guenter
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2019-02-25 23:55 Stephen Rothwell
2019-02-26 0:11 ` Guenter Roeck
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2019-02-25 23:55 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Linus Walleij
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
Hi Guenter,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/ad7418: struct of_device_id is 200 bytes. The last of 3 is:
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x61 0x64 0x69 0x2c 0x61 0x64 0x37 0x34 0x31 0x38 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x02 0x00 0x00 0x00 0x00 0x00 0x00 0x00
FATAL: drivers/hwmon/ad7418: struct of_device_id is not terminated with a NULL entry!
Caused by commit
08c95c6f6f95 ("hwmon: (ad7418) Add device tree probing")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build failure after merge of the hwmon-staging tree
@ 2018-12-16 23:00 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2018-12-16 23:00 UTC (permalink / raw)
To: Guenter Roeck, Masahiro Yamada
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Eddie James
[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]
Hi Guenter,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/hwmon/Kconfig:1298:warning: ignoring unsupported character '/'
drivers/hwmon/Kconfig:1299: syntax error
drivers/hwmon/Kconfig:1298:warning: ignoring unsupported character '/'
drivers/hwmon/Kconfig:1298:warning: ignoring unsupported character '/'
drivers/hwmon/Kconfig:1298: invalid statement
Caused by commit
de75c2156b2f ("hwmon: Add On-Chip Controller (OCC) hwmon driver")
interacting with updates to the kconfig system.
I have applied the following merge fix patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 17 Dec 2018 09:50:14 +1100
Subject: [PATCH] hwmon: quote the path in Kconfig source statements
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/hwmon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 62b68cd280dc..6f929bfa9fcd 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1295,7 +1295,7 @@ config SENSORS_NSA320
This driver can also be built as a module. If so, the module
will be called nsa320-hwmon.
-source drivers/hwmon/occ/Kconfig
+source "drivers/hwmon/occ/Kconfig"
config SENSORS_PCF8591
tristate "Philips PCF8591 ADC/DAC"
--
2.19.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2023-07-27 5:48 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 6:36 linux-next: build failure after merge of the hwmon-staging tree Stephen Rothwell
2020-04-28 13:19 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2023-07-27 5:41 Stephen Rothwell
2023-01-24 22:24 Stephen Rothwell
2023-01-24 22:27 ` Guenter Roeck
2022-08-30 23:30 Stephen Rothwell
2022-08-31 12:03 ` Michael Shych
2022-05-10 12:26 Stephen Rothwell
2020-10-01 2:53 Stephen Rothwell
2020-10-01 15:09 ` Guenter Roeck
2020-08-24 0:28 Stephen Rothwell
2020-08-24 7:01 ` Guenter Roeck
2020-03-22 23:37 Stephen Rothwell
2020-03-22 23:45 ` Guenter Roeck
2019-02-25 23:55 Stephen Rothwell
2019-02-26 0:11 ` Guenter Roeck
2018-12-16 23:00 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).