From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: linux-next: build failure after merge of the final tree Date: Fri, 20 May 2011 08:24:59 -0700 Message-ID: References: <20110520161210.81bbef3a.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:56855 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933263Ab1ETP1M (ORCPT ); Fri, 20 May 2011 11:27:12 -0400 In-Reply-To: <20110520161210.81bbef3a.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell , Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar Cc: David Miller , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org On Thu, May 19, 2011 at 11:12 PM, Stephen Rothwell wrote: > > After merging the final tree, today's linux-next build (sparc32 defconfig) > failed like this: Hmm. So I had actually done a "allyesconfig" build on x86, which annoys me. Because it means that the extra "let's compile everything to make sure I didn't break anything" was just almost totally worthless. What seems to be happening is that the x86 include ends up getting the . I have *no* idea why x86 does that, but x86 wants prefetch.h *so* much that it actually includes it first in and then *again* in each of the 32/64-bit specific header files. That seems a bit excessive. I don't think x86 should include at all, since (a) it doesn't actually use any of it, and (b) it ended up hiding this problem from me. Thomas, Ingo, Peter: would you be willing to just remove that stupid header file inclusion and fix up the fallout? Instead of having these one-by-one patches that come from Stephen testing out breakage on other architectures that x86 simply hid due to its odd include files? Linus