Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the block tree
Date: Wed, 24 Feb 2021 05:25:49 +0000
Message-ID: <BYAPR04MB49653608E4E792BCC8804616869F9@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20210224133140.5f02fa0e@canb.auug.org.au>

Stephen,

On 2/23/21 18:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
>
> kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs' not described in 'blk_fill_rwbs'`
>
> Introduced by commit
>
>   1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")
>
> -- Cheers, Stephen Rothwell
I've failed to understand this warning as rwbs is present in the doc header
and in the function parameter :-

/**                                                                                                   

 * blk_fill_rwbs - Fill the buffer rwbs by mapping op to character string.
 * @rwbs        buffer to be filled
 * @op:         REQ_OP_XXX for the tracepoint
 *
 * Description:
 *     Maps the REQ_OP_XXX to character and fills the buffer provided by the
 *     caller with resulting string.
 *
 **/
void blk_fill_rwbs(char *rwbs, unsigned int op)
{
        int i = 0;

        if (op & REQ_PREFLUSH)
                rwbs[i++] = 'F';

        switch (op & REQ_OP_MASK) {
        case REQ_OP_WRITE:
        case REQ_OP_WRITE_SAME:
                rwbs[i++] = 'W';
                break;
        case REQ_OP_DISCARD:
                rwbs[i++] = 'D';
                break;
        case REQ_OP_SECURE_ERASE:
                rwbs[i++] = 'D';
                rwbs[i++] = 'E';
                break;
        case REQ_OP_FLUSH:
                rwbs[i++] = 'F';
                break;
        case REQ_OP_READ:
                rwbs[i++] = 'R';
                break;
        default:
                rwbs[i++] = 'N';
        }

        if (op & REQ_FUA)
                rwbs[i++] = 'F';
        if (op & REQ_RAHEAD)
                rwbs[i++] = 'A';
        if (op & REQ_SYNC)
                rwbs[i++] = 'S';
        if (op & REQ_META)
                rwbs[i++] = 'M';

        rwbs[i] = '\0';
}
EXPORT_SYMBOL_GPL(blk_fill_rwbs);


  parent reply index

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  2:31 Stephen Rothwell
2021-02-24  2:40 ` Chaitanya Kulkarni
2021-02-24  5:25 ` Chaitanya Kulkarni [this message]
2021-02-24  5:33   ` Stephen Rothwell
2021-02-24  5:38     ` Chaitanya Kulkarni
2021-02-24 10:42       ` Stephen Rothwell
2021-02-24 21:41         ` Chaitanya Kulkarni
2021-02-24 21:45           ` Randy Dunlap
2021-02-24 21:51             ` Chaitanya Kulkarni
2021-02-24  7:16     ` Chaitanya Kulkarni
  -- strict thread matches above, loose matches on Subject: below --
2020-12-22 23:47 Stephen Rothwell
2020-12-23  0:13 ` Jens Axboe
2020-12-07  7:48 Stephen Rothwell
2020-12-03  7:39 Stephen Rothwell
2020-12-14 20:14 ` Stephen Rothwell
2020-12-21  1:30   ` Stephen Rothwell
2020-12-03  7:37 Stephen Rothwell
2020-12-14 20:13 ` Stephen Rothwell
2020-12-21  1:29   ` Stephen Rothwell
2020-11-12  4:32 Stephen Rothwell
2020-10-22 23:48 Stephen Rothwell
2020-10-23  0:30 ` Jens Axboe
2020-07-02  1:21 Stephen Rothwell
2020-07-02  4:07 ` Jens Axboe
2020-03-04  2:17 Stephen Rothwell
2020-03-04  3:01 ` Jens Axboe
2020-03-04 12:50   ` Pavel Begunkov
2020-01-31  0:16 Stephen Rothwell
2020-01-31  0:25 ` Jens Axboe
2020-01-16  0:54 Stephen Rothwell
2020-01-16  4:50 ` Jens Axboe
2019-10-18  0:51 Stephen Rothwell
2019-10-18  0:56 ` Jens Axboe
2019-10-18  0:59   ` Jens Axboe
2019-10-18  3:58   ` Stephen Rothwell
2019-08-29  3:51 Stephen Rothwell
2019-08-29  4:08 ` Stephen Rothwell
2019-08-29 15:41   ` Tejun Heo
2019-08-29 15:44     ` Jens Axboe
2019-08-09  4:00 Stephen Rothwell
2019-08-09  4:13 ` Jens Axboe
2019-08-09  6:15 ` Yuehaibing
2019-04-17  2:31 Stephen Rothwell
2019-04-17 10:05 ` Chao Yu
2019-04-17 14:03   ` Jaegeuk Kim
2019-04-18  0:57     ` Chao Yu
2019-04-18 14:01       ` Jaegeuk Kim
2019-04-19  1:14         ` Chao Yu
2018-11-08  3:31 Stephen Rothwell
2018-11-08  4:19 ` Jens Axboe
2018-09-28  1:11 Stephen Rothwell
2018-09-28  6:43 ` Omar Sandoval
2018-09-28 14:26   ` Jens Axboe
2018-05-31  3:49 Stephen Rothwell
2018-05-14  2:51 Stephen Rothwell
2018-05-14  8:29 ` Christoph Hellwig
2018-05-14 14:31   ` Jens Axboe
2017-05-10  1:24 Stephen Rothwell
2017-05-10  2:20 ` Markus Trippelsdorf
2017-05-10  3:00   ` Jens Axboe
2017-05-10  6:19     ` Markus Trippelsdorf
2017-05-10  3:26   ` Stephen Rothwell
2014-10-23  1:28 Stephen Rothwell
2014-10-23  2:14 ` Jens Axboe
2013-09-23  4:29 Stephen Rothwell
2011-05-09  3:49 Stephen Rothwell
2011-05-09  5:55 ` Tao Ma
2011-05-09  6:34   ` Jens Axboe
2010-12-20  4:31 Stephen Rothwell
2010-12-20  4:42 ` Stephen Rothwell
2010-12-20  8:12   ` Jens Axboe
2010-09-16  3:30 Stephen Rothwell
2010-04-29  6:14 Stephen Rothwell
2010-04-29  7:28 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB49653608E4E792BCC8804616869F9@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git