linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	linux-block <linux-block@vger.kernel.org>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	Hannes Reinecke <hare@suse.de>,
	Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function)
Date: Fri, 9 Apr 2021 05:31:02 +0000	[thread overview]
Message-ID: <BYAPR04MB4965A95A5131664085CDD8B786739@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: CA+G9fYtNAEwCk1WkA_25FVUrR0QJ2vt2Dh_w+m-QOSjb8f5TBQ@mail.gmail.com

On 4/8/21 22:21, Naresh Kamboju wrote:
> Linux next tag 20210408 architecture sh builds failed due to these errors.
>
> # to reproduce this build locally:
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=sh
> CROSS_COMPILE=sh4-linux-gnu- 'CC=sccache sh4-linux-gnu-gcc'
> 'HOSTCC=sccache gcc'
>
>
> In file included from /builds/linux/include/linux/scatterlist.h:9,
>                  from /builds/linux/include/linux/dma-mapping.h:10,
>                  from /builds/linux/drivers/cdrom/gdrom.c:16:
> /builds/linux/drivers/cdrom/gdrom.c: In function 'gdrom_readdisk_dma':
> /builds/linux/drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared
> (first use in this function)
>   586 |  __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
>       |                                                             ^~
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Regressions found on sh:
>   - build/gcc-9-dreamcast_defconfig
>   - build/gcc-10-dreamcast_defconfig
>   - build/gcc-8-dreamcast_defconfig
>
> --
> Linaro LKFT
> https://lkft.linaro.org
>

This can be fixed by following :-

diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index e7717d090868..742b4a0932e3 100644
--- a/drivers/cdrom/gdrom.c
+++ b/drivers/cdrom/gdrom.c
@@ -583,7 +583,7 @@ static blk_status_t gdrom_readdisk_dma(struct
request *req)
        read_command->cmd[1] = 0x20;
        block = blk_rq_pos(req)/GD_TO_BLK + GD_SESSION_OFFSET;
        block_cnt = blk_rq_sectors(req)/GD_TO_BLK;
-       __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
+       __raw_writel(page_to_phys(bio_page(req->bio)) +
bio_offset(req->bio),
                        GDROM_DMA_STARTADDR_REG);
        __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG);
        __raw_writel(1, GDROM_DMA_DIRECTION_REG);

  reply	other threads:[~2021-04-09  5:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  5:17 [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared (first use in this function) Naresh Kamboju
2021-04-09  5:31 ` Chaitanya Kulkarni [this message]
2021-04-09  5:33   ` Chaitanya Kulkarni
2021-04-09  6:23   ` Naresh Kamboju
2021-04-09  6:31     ` Chaitanya Kulkarni
2021-04-09  6:51       ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB4965A95A5131664085CDD8B786739@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=naresh.kamboju@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).