From: Linus Torvalds <torvalds@linux-foundation.org>
To: Doug Ledford <dledford@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Kaike Wan <kaike.wan@intel.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
John Fleck <john.fleck@intel.com>
Subject: Re: linux-next: Signed-off-by missing for commit in the rdma tree
Date: Sat, 2 Sep 2017 09:42:54 -0700 [thread overview]
Message-ID: <CA+55aFwhpVdMcNCVQfORYNxE=tknC=AUoTCsDasO-YdiJYYx7w@mail.gmail.com> (raw)
In-Reply-To: <78c70af4-21d0-94f2-6a2d-a832f24d23f4@redhat.com>
On Fri, Sep 1, 2017 at 5:06 AM, Doug Ledford <dledford@redhat.com> wrote:
> On 8/31/2017 5:50 PM, Stephen Rothwell wrote:
>> Hi Doug,
>>
>> Commit
>>
>> 4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
>>
>> is missing a Signed-off-by from its author.
>>
>
> What's the best way to fix this? I can rebase, but I know Linus hates
> that. What about git note?
We don't end up using (or forwarding) git notes, so that won't help.
Generally, the answer to missing sign-offs is "don't do that again" if
it's not something major and there isn't a _pattern_ of it happening.
In this case, it's a one-liner patch from a developer who has lots of
other sign-offs, from a company that is very aware of his work and the
GPL, and an active contributor. so it's not like it has any legal
implications.
If it was some big important patch from a more questionable source,
and we'd be worried about covering the legal side, it would be a
different issue. As it is, it falls under "mistakes happen, not a big
deal, try to avoid it in the future".
If it *was* a bigger issue and you really want to make sure that the
chain is there for new contributors etc, rebasing to fix sign-offs
ends up being the best (still bad) solution.
Linus
next prev parent reply other threads:[~2017-09-02 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 21:50 linux-next: Signed-off-by missing for commit in the rdma tree Stephen Rothwell
2017-09-01 12:06 ` Doug Ledford
2017-09-02 16:42 ` Linus Torvalds [this message]
2018-11-08 22:13 Stephen Rothwell
2021-04-08 22:00 Stephen Rothwell
2021-04-09 16:20 ` Dennis Dalessandro
2021-04-09 16:46 ` Jason Gunthorpe
2022-10-27 19:33 Stephen Rothwell
2022-10-28 16:16 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFwhpVdMcNCVQfORYNxE=tknC=AUoTCsDasO-YdiJYYx7w@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=john.fleck@intel.com \
--cc=kaike.wan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).