Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Willem de Bruijn <willemb@google.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Miller <davem@davemloft.net>,
	Network Development <netdev@vger.kernel.org>,
	linux-next@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warnings after merge of the net-next tree
Date: Thu, 14 May 2015 10:47:54 -0400
Message-ID: <CA+FuTSc9N6bwz5MOt51OuYsVpbqY4BrHM-anhh7aee=ZcQ47aw@mail.gmail.com> (raw)
In-Reply-To: <20150514171206.2fe660ec@canb.auug.org.au>

On Thu, May 14, 2015 at 3:12 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (sparc64 defconfig)
> produced these warnings:
>
> In file included from arch/sparc/include/asm/cmpxchg.h:4:0,
>                  from arch/sparc/include/asm/atomic_64.h:11,
>                  from arch/sparc/include/asm/atomic.h:4,
>                  from include/linux/atomic.h:4,
>                  from include/linux/spinlock.h:416,
>                  from include/linux/mmzone.h:7,
>                  from include/linux/gfp.h:5,
>                  from include/linux/mm.h:9,
>                  from net/packet/af_packet.c:56:
> net/packet/af_packet.c: In function 'packet_rcv_has_room':
> arch/sparc/include/asm/cmpxchg_64.h:43:22: warning: value computed is not used [-Wunused-value]
>  #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
>                       ^
> net/packet/af_packet.c:1314:3: note: in expansion of macro 'xchg'
>    xchg(&po->pressure, !has_room);
>    ^
> net/packet/af_packet.c: In function 'packet_poll':
> arch/sparc/include/asm/cmpxchg_64.h:43:22: warning: value computed is not used [-Wunused-value]
>  #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
>                       ^
> net/packet/af_packet.c:3817:3: note: in expansion of macro 'xchg'
>    xchg(&po->pressure, 0);
>    ^
>
> Introduced by commit 2ccdbaa6d55b ("packet: rollover lock contention
> avoidance").

I just sent http://patchwork.ozlabs.org/patch/472362/ to resolve
these. Thanks for the report.

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14  7:12 Stephen Rothwell
2015-05-14 14:47 ` Willem de Bruijn [this message]
2015-06-20 13:12 Stephen Rothwell
2015-06-20 17:40 ` Florian Westphal
2015-06-20 18:31   ` Pablo Neira Ayuso
2016-11-22  1:22 Stephen Rothwell
2016-11-22  1:28 ` Florian Fainelli
2016-11-22  8:23   ` Thomas Petazzoni
2017-01-18  0:37 Stephen Rothwell
2017-03-20  6:07 Stephen Rothwell
2019-11-05  1:45 Stephen Rothwell

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+FuTSc9N6bwz5MOt51OuYsVpbqY4BrHM-anhh7aee=ZcQ47aw@mail.gmail.com' \
    --to=willemb@google.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git