From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prabhakar Lad Subject: Re: [PATCH 3/3] [media] vpif: Fix compilation with allmodconfig Date: Tue, 9 Sep 2014 19:30:58 +0100 Message-ID: References: <20140909124306.2d5a0d76@canb.auug.org.au> <6cbd00c5f2d342b573aaf9c0e533778374dd2e1e.1410273306.git.m.chehab@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-media-owner@vger.kernel.org To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , dlos , linux-next@vger.kernel.org, LKML , Stephen Rothwell List-Id: linux-next.vger.kernel.org On Tue, Sep 9, 2014 at 3:38 PM, Mauro Carvalho Chehab wrote: > When vpif is compiled as module, those errors happen: > > ERROR: "vpif_lock" [drivers/media/platform/davinci/vpif_display.ko] undefined! > ERROR: "vpif_lock" [drivers/media/platform/davinci/vpif_capture.ko] undefined! > > That's because vpif_lock symbol is not exported. > Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > Reported-by: Stephen Rothwell > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c > index cd08e5248387..3dad5bd7fe0a 100644 > --- a/drivers/media/platform/davinci/vpif.c > +++ b/drivers/media/platform/davinci/vpif.c > @@ -38,6 +38,7 @@ MODULE_LICENSE("GPL"); > #define VPIF_CH3_MAX_MODES 2 > > spinlock_t vpif_lock; > +EXPORT_SYMBOL_GPL(vpif_lock); > > void __iomem *vpif_base; > EXPORT_SYMBOL_GPL(vpif_base); > -- > 1.9.3 >