From: Sedat Dilek <sedat.dilek@gmail.com>
To: Dmitry Kasatkin <d.kasatkin@samsung.com>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: linux-next: Tree for Aug 28 [ xhci build breakage ]
Date: Wed, 28 Aug 2013 19:39:14 +0200 [thread overview]
Message-ID: <CA+icZUUj-gyqmEFo54N_62KCgByAu1n9n=dHgg3aTC53zA9TRQ@mail.gmail.com> (raw)
In-Reply-To: <521E3259.6040201@samsung.com>
On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin <d.kasatkin@samsung.com> wrote:
> On 28/08/13 19:59, Sarah Sharp wrote:
>> Please trim your replies.
>>
>> On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote:
>>>>>> That change seems to cause the problems:
>>>>>>
>>>>>> commit 0730d52a86919300a39a2be37f6c140997dfb82f
>>>>>> "xhci:prevent "callbacks suppressed" when debug is not enabled"
>>>>>>
>>>>>> - Sedat -
>>>>>>
>>>>>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f
>>>>>>
>>>>> Hello,
>>>>>
>>>>> [PATCHv2 1/2] was not applied before.
>>>>> I pointed this out few hours ago...
>> So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent
>> "callbacks suppressed" when debug is not enabled' needed to be applied
>> after your first patch? And basically applying that patch alone breaks
>> the build?
>
> Right...
> May be I had to stress it somehow... sorry.
>
Still noone answered me why "drivers/usb/host/xhci-ring.c" does NOT
include <linux/device.h> (dev_info_ratelimited() and other defines).
I am expecting that... even I see...
drivers/usb/host/.xhci-ring.o.cmd:715: include/linux/device.h \
...where I don't know why this happens.
( For me this is a bit more important than """trimming""" my
responses, I keep the history... )
- Sedat -
P.S.: List of includes in xhci-ring.c
$ grep ^'#include' -nr drivers/usb/host/xhci-ring.c
67:#include <linux/scatterlist.h>
68:#include <linux/slab.h>
69:#include "xhci.h"
70:#include "xhci-trace.h"
>> Ugh. Sorry about this. Greg, how do you want to handle this?
>>
>> Sarah "needs a vacation" Sharp
>>
>
>
next prev parent reply other threads:[~2013-08-28 17:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 9:49 linux-next: Tree for Aug 28 [ xhci build breakage ] Sedat Dilek
2013-08-28 9:56 ` Sedat Dilek
2013-08-28 10:29 ` Sedat Dilek
[not found] ` <CA+icZUVTzMxS4f3kZnauDkrpf4vwMbS3zd7ECOhE37S_FF83UA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-28 10:38 ` Sedat Dilek
2013-08-28 10:43 ` Dmitry Kasatkin
2013-08-28 10:46 ` Sedat Dilek
2013-08-28 10:52 ` Sedat Dilek
2013-08-28 10:53 ` Dmitry Kasatkin
2013-08-28 10:58 ` Sedat Dilek
2013-08-28 11:19 ` Sedat Dilek
2013-08-28 15:17 ` Sedat Dilek
2013-08-28 16:59 ` Sarah Sharp
2013-08-28 17:18 ` Greg Kroah-Hartman
2013-08-28 17:37 ` Sarah Sharp
2013-08-28 17:24 ` Dmitry Kasatkin
2013-08-28 17:39 ` Sedat Dilek [this message]
2013-08-28 21:15 ` Sarah Sharp
2013-08-29 8:02 ` Sedat Dilek
2013-08-29 16:54 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+icZUUj-gyqmEFo54N_62KCgByAu1n9n=dHgg3aTC53zA9TRQ@mail.gmail.com' \
--to=sedat.dilek@gmail.com \
--cc=d.kasatkin@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).