From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C903C3A5A6 for ; Fri, 30 Aug 2019 04:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E9A32189D for ; Fri, 30 Aug 2019 04:11:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TCGMafDG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727351AbfH3ELL (ORCPT ); Fri, 30 Aug 2019 00:11:11 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36403 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfH3ELL (ORCPT ); Fri, 30 Aug 2019 00:11:11 -0400 Received: by mail-wm1-f66.google.com with SMTP id p13so5912075wmh.1; Thu, 29 Aug 2019 21:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=EzdpqBHFBURqZtpqMz86yppY6L9goi80pSe5/xSwXtU=; b=TCGMafDGV40KPc2+AkZEqcuDwEa7xEze4WiCa/yfEroGBVTaTVfSCrVhKhoM8S3wsD qBJF/mHmd4gGjBnB135iZLpABxCysDufVbbhyNyROpHJkRJflTokdXTPycQbsBM3FIpN Ln9AJ7Fc9Oa257XZ+rl4cmFElbTvE2Zyr+D/zJarSJ9vGtrMxZqY6mtl+pTn37vFzdzR AEbg30TX45+bcbH4xwbwsmo7YLf28EUUvv6b6s7sevLXkN+4kC58bSocwdesXEtYBYy+ tc9mvZWJmSxJn9eBqSEPBh+vBf6DGtIQxDJomPxdLKNXdZK8Sdk46dcKiI9cwCeEqihX hlIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=EzdpqBHFBURqZtpqMz86yppY6L9goi80pSe5/xSwXtU=; b=JV9VVVejbl3qQdTXjMFfMrolu2MKpZFa3kqhjcJnd9u6WpW4Tdcasxcc4dHz3BkUIr rwDWqA/G6u+Krn4370XBxoy+Sq/vZEPSkVtug7LUOA+jFfVT4wxV4w1KL2vDfxWSbsqE eGfKSRlXn8tDBHNXcBZ5ZnDXVF8HUqgWKzuWRMX+DRAOkPOX1t6hGQi6FLQJNKt7ii4o +Ep9VjWqrCBWYXOD/MlxrNiPTiRN0A5QAKnJ6pxI3AQEsZ+3zfiWId5w6vxryKnVABXv YvmMtMJjAX4oeeBQpNJVPpbh5OKwgxmLEne90tCfIoACeHiCiDoQccZMxEAJKBVW93Ca VDvA== X-Gm-Message-State: APjAAAX+zTiud87teYpJqrF6mgBk5ycNeeU404R0a/zYNbErjoPUkNO/ LxaUxXCUG380ZvZlIx+AI2Y7rie4rpRXzNIR6QY= X-Google-Smtp-Source: APXvYqzQODrGE115hX6AyOOjmhKJAZ5etXq0AxSfXgroo4468fZ3yfVGVy4BG2ukkYO8P4FUDTk9u4mSj4EBsbaVke4= X-Received: by 2002:a05:600c:225a:: with SMTP id a26mr16372285wmm.81.1567138268731; Thu, 29 Aug 2019 21:11:08 -0700 (PDT) MIME-Version: 1.0 References: <20190828034012.sBvm81sYK%akpm@linux-foundation.org> <8b09d93a-bc42-bd8e-29ee-cd37765f4899@infradead.org> <20190828171923.4sir3sxwsnc2pvjy@treble> <57d6ab2e-1bae-dca3-2544-4f6e6a936c3a@infradead.org> <20190828200134.d3lwgyunlpxc6cbn@treble> <20190829082445.GM2369@hirez.programming.kicks-ass.net> <20190829233735.yp3mwhg6er353qw5@treble> In-Reply-To: <20190829233735.yp3mwhg6er353qw5@treble> Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Fri, 30 Aug 2019 06:10:56 +0200 Message-ID: Subject: Re: mmotm 2019-08-27-20-39 uploaded (objtool: xen) To: Josh Poimboeuf Cc: Peter Zijlstra , Randy Dunlap , akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au Content-Type: text/plain; charset="UTF-8" Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Fri, Aug 30, 2019 at 1:38 AM Josh Poimboeuf wrote: > > On Thu, Aug 29, 2019 at 10:24:45AM +0200, Peter Zijlstra wrote: > > On Wed, Aug 28, 2019 at 03:01:34PM -0500, Josh Poimboeuf wrote: > > > On Wed, Aug 28, 2019 at 10:56:25AM -0700, Randy Dunlap wrote: > > > > >> drivers/xen/gntdev.o: warning: objtool: gntdev_copy()+0x229: call to __ubsan_handle_out_of_bounds() with UACCESS enabled > > > > > > > > > > Easy one :-) > > > > > > > > > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > > > > > index 0c8e17f946cd..6a935ab93149 100644 > > > > > --- a/tools/objtool/check.c > > > > > +++ b/tools/objtool/check.c > > > > > @@ -483,6 +483,7 @@ static const char *uaccess_safe_builtin[] = { > > > > > "ubsan_type_mismatch_common", > > > > > "__ubsan_handle_type_mismatch", > > > > > "__ubsan_handle_type_mismatch_v1", > > > > > + "__ubsan_handle_out_of_bounds", > > > > > /* misc */ > > > > > "csum_partial_copy_generic", > > > > > "__memcpy_mcsafe", > > > > > > > > > > > > > > > > > then I get this one: > > > > > > > > lib/ubsan.o: warning: objtool: __ubsan_handle_out_of_bounds()+0x5d: call to ubsan_prologue() with UACCESS enabled > > > > > > And of course I jinxed it by calling it easy. > > > > > > Peter, how do you want to handle this? > > > > > > Should we just disable UACCESS checking in lib/ubsan.c? > > > > No, that is actually unsafe and could break things (as would you patch > > above). > > Oops. -EFIXINGTOOMANYOBJTOOLISSUESATONCE > > > I'm thinking the below patch ought to cure things: > > > > --- > > Subject: x86/uaccess: Don't leak the AC flags into __get_user() argument evalidation > > s/evalidation/evaluation > > > Identical to __put_user(); the __get_user() argument evalution will too > > leak UBSAN crud into the __uaccess_begin() / __uaccess_end() region. > > While uncommon this was observed to happen for: > > > > drivers/xen/gntdev.c: if (__get_user(old_status, batch->status[i])) > > > > where UBSAN added array bound checking. > > > > This complements commit: > > > > 6ae865615fc4 ("x86/uaccess: Dont leak the AC flag into __put_user() argument evaluation") > > > > Reported-by: Randy Dunlap > > Signed-off-by: Peter Zijlstra (Intel) > > Cc: luto@kernel.org > > --- > > arch/x86/include/asm/uaccess.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h > > index 9c4435307ff8..35c225ede0e4 100644 > > --- a/arch/x86/include/asm/uaccess.h > > +++ b/arch/x86/include/asm/uaccess.h > > @@ -444,8 +444,10 @@ __pu_label: \ > > ({ \ > > int __gu_err; \ > > __inttype(*(ptr)) __gu_val; \ > > + __typeof__(ptr) __gu_ptr = (ptr); \ > > + __typeof__(size) __gu_size = (size); \ > > __uaccess_begin_nospec(); \ > > - __get_user_size(__gu_val, (ptr), (size), __gu_err, -EFAULT); \ > > + __get_user_size(__gu_val, __gu_ptr, __gu_size, __gu_err, -EFAULT); \ > > __uaccess_end(); \ > > (x) = (__force __typeof__(*(ptr)))__gu_val; \ > > __builtin_expect(__gu_err, 0); \ > > Reviewed-by: Josh Poimboeuf > Tested-by Sedat Dilek - Sedat -