From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sedat Dilek Subject: Re: linux-next: build failure after merge of the tty tree Date: Thu, 31 Oct 2013 11:35:23 +0100 Message-ID: References: <20131031184015.adc000259e9931fd0b5d5cf7@canb.auug.org.au> Reply-To: sedat.dilek@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20131031184015.adc000259e9931fd0b5d5cf7@canb.auug.org.au> Sender: linux-serial-owner@vger.kernel.org To: Stephen Rothwell , Philippe Proulx Cc: Greg KH , linux-next , LKML , linux-serial@vger.kernel.org List-Id: linux-next.vger.kernel.org On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')' before numeric constant > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d' expects a matching 'int' argument [-Wformat] > > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch > warnings"). There is a missing ',' in the dev_warn() ... > > I have used the version of the tty tree from next-20131030 for today. > [ Add CC to linux-serial ML ] Happy HelloWien and WelcomeBackStephen! That was only checkpatch-tested, eh :-)? @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct platform_device *pdev) up->port.uartclk = omap_up_info->uartclk; if (!up->port.uartclk) { up->port.uartclk = DEFAULT_CLK_SPEED; - dev_warn(&pdev->dev, "No clock speed specified: using default:" - "%d\n", DEFAULT_CLK_SPEED); + dev_warn(&pdev->dev, + "No clock speed specified: using default: %d\n" <--- Comma missing here! + DEFAULT_CLK_SPEED); } - Sedat -