Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

[Sedat Dilek <sedat.dilek@gmail.com>]

On Sat, Apr 13, 2013 at 12:51 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Friday, April 12, 2013 11:08:37 PM Sedat Dilek wrote:
>> On Fri, Apr 12, 2013 at 6:27 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> > On Fri, Apr 12, 2013 at 5:45 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> >> On Fri, Apr 12, 2013 at 4:24 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> >>> On Fri, Apr 12, 2013 at 10:23 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> >>>> On 10 April 2013 11:44, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> >>>>> I found this "[RFC PATCH] kbuild: Build linux-tools package with 'make
>> >>>>> deb-pkg'" from February 2012.
>> >>>>> Can't say what happened to it...
>> >>>>
>> >>>> Sedat,
>> >>>>
>> >>>> Sorry for being late. I am down with Fever and throat infection since few days.
>> >>>> Still struggling with it..
>> >>>>
>> >>>> There are few things i tried. Firstly the tag: next-20130326 is bad as there are
>> >>>> some bad commits in cpufreq core in it.
>> >>>>
>> >>>> I then tried latest linux-next/master on my Thinkpad (model name        : Intel(R)
>> >>>> Core(TM) i7-2640M CPU @ 2.80GHz) and couldn't boot it up. My ubuntu
>> >>>> just hanged.
>> >>>>
>> >>>> Then i tried Rafael's linux-next branch
>> >>>>
>> >>>> 079576f Merge branch 'pm-cpufreq-next' into linux-next
>> >>>>
>> >>>> And couldn't find any issues with it. I am easily able to remove/add cpus at
>> >>>> runtime..
>> >>>>
>> >>>> Can you give this branch a try?
>> >>>>
>> >>>
>> >>> OK, you seem to be well again, nice to hear.
>> >>>
>> >>> I was doing the whole week spring-cleaning in the apartment of my parents.
>> >>> Now, I have some minutes for a compilation run.
>> >>>
>> >>> I guess "cpufreq: Call __cpufreq_governor() with correct policy->cpus
>> >>> mask" could be the correct fix, but will try the GIT branch you have
>> >>> mentioned.
>> >>>
>> >>> - Sedat -
>> >>>
>> >>> [1] http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=e4969ebac83fdea78d89c779331396728a4e6199
>> >>>
>> >>
>> >> Both BROKEN here, specific pm-next commitid and pulling
>> >> pm.git#linux-next into next-20130411 (see attached files).
>> >>
>> >> Is "cpufreq: convert cpufreq_driver to using RCU" the root cause of this all?
>> >>
>> >
>> > [ CC Nathan ]
>> >
>> > NO, wrong assumption.
>> >
>> > 2013-04-12 18:04 Sedat Dilek        o [revert-cpufreq-rcu] Revert
>> > "cpufreq: convert cpufreq_driver to using RCU"
>> > 2013-04-12 18:04 Sedat Dilek        o Revert "cpufreq: Call
>> > __cpufreq_governor() with correct policy->cpus mask"
>> > 2013-04-11 23:24 Rafael J. Wysocki  M─┐ [pm-next-079576f] Merge branch
>> > 'pm-cpufreq-next' into linux-next
>> >
>> > - Sedat -
>> >
>> >
>> >> - Sedat -
>> >>
>> >> [1] http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=5800043b2488a1c4c6e859af860644d37419d58b
>> >>
>> >>>> --
>> >>>> viresh
>>
>> [ TO Dirk (Author of Intel pstate driver) ]
>>
>> With CONFIG_X86_INTEL_PSTATE=n (unset) I do not see the call-trace!
>>
>> My kernel-config and dmesg are attached.
>
> You're seeing a trouble with a new driver, then, so that's not a regression.
>

What do you mean by this?

What are the next steps to get this fixed?

- Sedat -

> Thanks for taking the time to debug this!
>
> Rafael
>
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.