From: Alexandre Courbot <gnurou@gmail.com>
To: Romain Naour <romain.naour@openwide.fr>, kgene.kim@samsung.com
Cc: linux-next <linux-next@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
tomasz.figa@gmail.com, heiko@sntech.de,
linux-samsung-soc@vger.kernel.org
Subject: Re: GENERIC_GPIO considered deprecated
Date: Sun, 31 Mar 2013 15:18:33 -0700 [thread overview]
Message-ID: <CAAVeFu++8YOOSxPbAaTudxSGcBomkGrakBjiVyD+XSee54TrWw@mail.gmail.com> (raw)
In-Reply-To: <51576214.8010307@openwide.fr>
Hi Romain,
On Sat, Mar 30, 2013 at 3:07 PM, Romain Naour <romain.naour@openwide.fr> wrote:
> Hi Alex,
>
> When I read your mail, I was surprised that you were speaking about GPIOs, my pathes for samsung CPUs are intended for timer sub-system.
>
> As you can see in this thread, when I send my patches "ARM: S3C24XX: Add samsung-time support for s3c24xx" and "Add samsung-time support for s5pc100". They didn't add "select GENERIC_GPIO".
> http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13432/focus=14980
> http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13432/focus=14982
>
> There is something wrong with the commit, I see that "select GENERIC_GPIO" was added in my patches by mistake.
>
> I recommend you to speak directly with samsung's kernel maintainer that I CC in this mail.
Indeed, it seems like these "select GENERIC_GPIO" have been added
during the merge of your patches, since I can see the line is here in
your patch (but not added by it). Kim, on the current next there are
two of these "select GENERIC_GPIO" that are added from your branch,
could you amend the patches that adds them such as they get changed
into "select ARCH_REQUIRE_GPIOLIB" instead? You can grep for "select
GENERIC_GPIO" in arch/arm to find the offending lines. We are removing
GENERIC_GPIO and this work cannot be merged until you do this since it
would break ARM builds. Thanks!
Alex.
next prev parent reply other threads:[~2013-03-31 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 2:15 GENERIC_GPIO considered deprecated Alexandre Courbot
2013-03-30 22:07 ` Romain Naour
2013-03-31 22:18 ` Alexandre Courbot [this message]
2013-04-04 0:35 ` Kukjin Kim
2013-04-04 18:12 ` Alexandre Courbot
2013-04-08 7:31 ` Kukjin Kim
2013-04-08 16:11 ` Stephen Warren
2013-04-08 19:36 ` Arnd Bergmann
2013-04-08 23:38 ` Stephen Rothwell
2013-04-09 0:07 ` Alexandre Courbot
2013-04-09 0:10 ` Stephen Rothwell
2013-04-09 1:45 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAVeFu++8YOOSxPbAaTudxSGcBomkGrakBjiVyD+XSee54TrWw@mail.gmail.com \
--to=gnurou@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=romain.naour@openwide.fr \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).