From: Karol Herbst <kherbst@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Jani Nikula <jani.nikula@intel.com>,
Lyude Paul <lyude@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org, Ilia Mirkin <imirkin@alum.mit.edu>,
Daniel Vetter <daniel@ffwll.ch>, Ben Skeggs <bskeggs@redhat.com>,
David Airlie <airlied@gmail.com>,
"Nathan E. Egge" <unlord@xiph.org>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
Dave Airlie <airlied@redhat.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: Coverity: nouveau_dp_irq(): Null pointer dereferences
Date: Fri, 11 Nov 2022 21:06:54 +0100 [thread overview]
Message-ID: <CACO55tt5KOgDYMEw=spDeoMaYuj2GQOuHU+BEgadr1nQiFOGhw@mail.gmail.com> (raw)
In-Reply-To: <202211111110.11B554B@keescook>
On Fri, Nov 11, 2022 at 8:21 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote:
> > On Thu, 10 Nov 2022, coverity-bot <keescook@chromium.org> wrote:
> > > Hello!
> > >
> > > This is an experimental semi-automated report about issues detected by
> > > Coverity from a scan of next-20221110 as part of the linux-next scan project:
> > > https://scan.coverity.com/projects/linux-next-weekly-scan
> > >
> > > You're getting this email because you were associated with the identified
> > > lines of code (noted below) that were touched by commits:
> > >
> > > Mon Aug 31 19:10:08 2020 -0400
> > > a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling")
> >
> > Hi Kees, this looks like a good idea, but maybe double check the Cc list
> > generation? I was Cc'd on four mails today that I thought were
> > irrelevant to me.
>
> Hi!
>
> Heh, I was recently asked to _expand_ the CC list. :)
>
> For these last pass of reports, I added a get_maintainers.pl run to the
> identified commit. In this instance, the commit touched:
>
> drivers/gpu/drm/nouveau/dispnv04/disp.c | 6 +
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 192 ++++++++++++++++++++++--------------------------
> drivers/gpu/drm/nouveau/nouveau_connector.c | 14 ---
> drivers/gpu/drm/nouveau/nouveau_display.c | 2
> drivers/gpu/drm/nouveau/nouveau_display.h | 2
> drivers/gpu/drm/nouveau/nouveau_dp.c | 132 ++++++++++++++++++++++++++++-----
> drivers/gpu/drm/nouveau/nouveau_encoder.h | 33 +++++++-
> 7 files changed, 244 insertions(+), 137 deletions(-)
>
> And the get_maintainers.pl rationale was:
>
> Ben Skeggs <bskeggs@redhat.com> (supporter:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS,commit_signer:1/1=100%,commit_signer:6/16=38%,authored:4/16=25%,added_lines:23/124=19%,removed_lines:36/152=24%)
> Karol Herbst <kherbst@redhat.com> (supporter:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS,commit_signer:2/1=100%)
> Lyude Paul <lyude@redhat.com> (supporter:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS,commit_signer:9/16=56%,authored:6/16=38%,added_lines:92/124=74%,removed_lines:107/152=70%)
> David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
> Daniel Vetter <daniel@ffwll.ch> (maintainer:DRM DRIVERS)
> Ilia Mirkin <imirkin@alum.mit.edu> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
> "Nathan E. Egge" <unlord@xiph.org> (commit_signer:1/1=100%)
> Jani Nikula <jani.nikula@intel.com> (commit_signer:6/16=38%)
> Dave Airlie <airlied@redhat.com> (commit_signer:5/16=31%)
> Thomas Zimmermann <tzimmermann@suse.de> (commit_signer:4/16=25%,authored:4/16=25%)
> dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS)
> nouveau@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS)
>
I'd say it's good enough to message supporters and the mailing lists
for at least Nouveau code, maybe even all drm drivers.
Not sure what to do about actual maintainers, but I doubt Dave and
Daniel want to be CCed on every Coverity report here either.
Karol
>
> --
> Kees Cook
>
next prev parent reply other threads:[~2022-11-11 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 16:50 Coverity: nouveau_dp_irq(): Null pointer dereferences coverity-bot
2022-11-11 9:13 ` Jani Nikula
2022-11-11 19:21 ` Kees Cook
2022-11-11 20:06 ` Karol Herbst [this message]
2022-11-11 20:16 ` Kees Cook
2022-11-11 20:38 ` Karol Herbst
2022-11-14 10:07 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACO55tt5KOgDYMEw=spDeoMaYuj2GQOuHU+BEgadr1nQiFOGhw@mail.gmail.com' \
--to=kherbst@redhat.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@embeddedor.com \
--cc=imirkin@alum.mit.edu \
--cc=jani.nikula@intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=unlord@xiph.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).