From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E126C433DF for ; Wed, 20 May 2020 07:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DC9E207ED for ; Wed, 20 May 2020 07:56:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="Hg+A7Gzg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726436AbgETH4u (ORCPT ); Wed, 20 May 2020 03:56:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726224AbgETH4u (ORCPT ); Wed, 20 May 2020 03:56:50 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8543FC061A0E; Wed, 20 May 2020 00:56:49 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id se13so2350236ejb.9; Wed, 20 May 2020 00:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TM96ZHCzhyp+IMhZ6Z75lYPm5gdlMX8BZHHPWt0v1GU=; b=Hg+A7Gzg/Q9IUJWAhYj6TttJDCfB71JAEvU9yzBrmtI6MQ4j9SdaK+8Cb0ueOvShUk ZeILkCdW14a69wCKx8GYO2pKAOx9NQEqQJs6NWj6WfR03GplnDe1ohP9uKBZHbS63JQi RCyeiMvnFFO6wKuundvxgbJVWBLr2u/W6XzSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TM96ZHCzhyp+IMhZ6Z75lYPm5gdlMX8BZHHPWt0v1GU=; b=Pg8u0cOj574ZZw2JFKtSxzvwpz2WbDFGYqVM8GZztcRpZwx7fWm99IZGlhvNi9kqKq RGUnLSKvbtHMnyNUvmGpQjMD95M4rNXS5QAIHE5/adLYMmVldMPFv9e9SnMBDN7vEJW6 j6ZAVZwueEJC43a42mhr+9FdrOcalcj55yGDyNMrYCLtX4aRKu4XToHEThgnn/T1O607 5MpEe/G0G+hJ3SRYMtMjHBLpD0M1ok9b9FFEes+aFJ9ZlLLEGyh25XNp+eGsrG0CSdpT mnn/R1wX0GXLNAKDTnn41bSWq8lbiQMlKFIDKea4ckDaSYlFZbSfgTYw0gc0abn55k/Q b7HA== X-Gm-Message-State: AOAM531MW/oYe6fYXxFgFrb1qS+ibCMfSazwpN/1A52unTGlNKGa/FAz xpy/2fgHVJ3CTR8tzIhL4kvVqXLZ2QpFQOmhiUc= X-Google-Smtp-Source: ABdhPJxJE6COXv9ebzHWeN3sR5bO6sS2ZHeZ6Q88KZKIN+0/qbeKCz5d2HqYeZYbtFX+I0QevihfOewUDj9RsAGt8fk= X-Received: by 2002:a17:906:ce39:: with SMTP id sd25mr2771415ejb.477.1589961408183; Wed, 20 May 2020 00:56:48 -0700 (PDT) MIME-Version: 1.0 References: <20200507091008.1bd38185@canb.auug.org.au> In-Reply-To: From: Joel Stanley Date: Wed, 20 May 2020 07:56:36 +0000 Message-ID: Subject: Re: linux-next: build warning after merge of the aspeed tree To: Rob Herring , Arnd Bergmann Cc: Stephen Rothwell , devicetree , Devicetree Compiler , Linux Next Mailing List , Linux Kernel Mailing List , Manikandan Elumalai , Andrew Jeffery , Vijay Khemka Content-Type: text/plain; charset="UTF-8" Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, 11 May 2020 at 15:19, Rob Herring wrote: > > On Fri, May 8, 2020 at 1:40 AM Joel Stanley wrote: > > > > On Wed, 6 May 2020 at 23:13, Joel Stanley wrote: > > > > > > Hi Rob, > > > > > > On Wed, 6 May 2020 at 23:10, Stephen Rothwell wrote: > > > > > > > > Hi all, > > > > > > > > After merging the aspeed tree, today's linux-next build (arm > > > > multi_v7_defconfig) produced this warning: > > > > > > Thanks Stephen. > > > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10: I2C bus unit address format error, expected "40000010" > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg: I2C address must be less than 10-bits, got "0x40000010" > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:137.11-141.4: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@100/ipmb3@10: I2C bus unit address format error, expected "40000010" > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:139.3-30: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@100/ipmb3@10:reg: I2C address must be less than 10-bits, got "0x40000010" > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:148.11-152.4: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@180/ipmb5@10: I2C bus unit address format error, expected "40000010" > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:150.3-30: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@180/ipmb5@10:reg: I2C address must be less than 10-bits, got "0x40000010" > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:159.11-163.4: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@300/ipmb7@10: I2C bus unit address format error, expected "40000010" > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:161.3-30: Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@300/ipmb7@10:reg: I2C address must be less than 10-bits, got "0x40000010" > > > > > > These are IPMB nodes with the SLAVE_ADDRESS bit set: > > > > > > +&i2c5 { > > > + //Host3 IPMB bus > > > + status = "okay"; > > > + multi-master; > > > + ipmb5@10 { > > > + compatible = "ipmb-dev"; > > > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > > > + i2c-protocol; > > > + }; > > > > > > This is a correct entry, so dtc should not warn about it. > > > > I sent a patch for dtc here: > > https://lore.kernel.org/lkml/20200508063904.60162-1-joel@jms.id.au/ > > Patches for dtc need to be against upstream dtc. There's already a > similar patch posted for it which I commented on and never saw a > respin. Can I suggest some instructions in scsripts/dtc explaining that you don't take patches in the kernel tree for this code? I've sent the patch so it applies to the dtc tree. It would be good to see that change propagate over to -next as others have reported this warning. Cheers, Joel