linux-next: Signed-off-by missing for commit in the pinctrl tree

linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

Hi Linus,

Commit

  f18fab4bcb4f ("pinctrl: sh-pfc: Add r8a77470 PFC support")

is missing a Signed-off-by from its comitter.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Geert Uytterhoeven]

On Tue, May 15, 2018 at 11:27 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Commit
>
>   f18fab4bcb4f ("pinctrl: sh-pfc: Add r8a77470 PFC support")
>
> is missing a Signed-off-by from its comitter.

Sorry, I forgot to add it.

Linus, as the merge of sh-pfc is your top commit, shall I fix it up
and send a new
pull request?
Please let me know how to proceed. Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

On Wed, May 16, 2018 at 9:16 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Tue, May 15, 2018 at 11:27 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Commit
>>
>>   f18fab4bcb4f ("pinctrl: sh-pfc: Add r8a77470 PFC support")
>>
>> is missing a Signed-off-by from its comitter.
>
> Sorry, I forgot to add it.
>
> Linus, as the merge of sh-pfc is your top commit, shall I fix it up
> and send a new
> pull request?
> Please let me know how to proceed. Thanks!

If it's just missing your SoB I can add it with your permission
I guess? That is less trouble.

Yours,
Linus Walleij

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Geert Uytterhoeven]

Hi Linus,

On Wed, May 16, 2018 at 1:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, May 16, 2018 at 9:16 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Tue, May 15, 2018 at 11:27 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>> Commit
>>>
>>>   f18fab4bcb4f ("pinctrl: sh-pfc: Add r8a77470 PFC support")
>>>
>>> is missing a Signed-off-by from its comitter.
>>
>> Sorry, I forgot to add it.
>>
>> Linus, as the merge of sh-pfc is your top commit, shall I fix it up
>> and send a new
>> pull request?
>> Please let me know how to proceed. Thanks!
>
> If it's just missing your SoB I can add it with your permission
> I guess? That is less trouble.

You have my permission.
But I'm afraid that won't help, as then you'll become the committer with your
SoB missing...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

On Wed, May 16, 2018 at 1:29 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Wed, May 16, 2018 at 1:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Wed, May 16, 2018 at 9:16 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>> On Tue, May 15, 2018 at 11:27 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>> Commit
>>>>
>>>>   f18fab4bcb4f ("pinctrl: sh-pfc: Add r8a77470 PFC support")
>>>>
>>>> is missing a Signed-off-by from its comitter.
>>>
>>> Sorry, I forgot to add it.
>>>
>>> Linus, as the merge of sh-pfc is your top commit, shall I fix it up
>>> and send a new
>>> pull request?
>>> Please let me know how to proceed. Thanks!
>>
>> If it's just missing your SoB I can add it with your permission
>> I guess? That is less trouble.
>
> You have my permission.
> But I'm afraid that won't help, as then you'll become the committer with your
> SoB missing...

Bah I just sign them all off then. It's still quicker.

Done!

Yours,
Linus Walleij

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Geert Uytterhoeven]

Hi Linus,

On Wed, May 16, 2018 at 1:33 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, May 16, 2018 at 1:29 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Wed, May 16, 2018 at 1:24 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>>> On Wed, May 16, 2018 at 9:16 AM, Geert Uytterhoeven
>>> <geert@linux-m68k.org> wrote:
>>>> On Tue, May 15, 2018 at 11:27 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>>> Commit
>>>>>
>>>>>   f18fab4bcb4f ("pinctrl: sh-pfc: Add r8a77470 PFC support")
>>>>>
>>>>> is missing a Signed-off-by from its comitter.
>>>>
>>>> Sorry, I forgot to add it.
>>>>
>>>> Linus, as the merge of sh-pfc is your top commit, shall I fix it up
>>>> and send a new
>>>> pull request?
>>>> Please let me know how to proceed. Thanks!
>>>
>>> If it's just missing your SoB I can add it with your permission
>>> I guess? That is less trouble.
>>
>> You have my permission.
>> But I'm afraid that won't help, as then you'll become the committer with your
>> SoB missing...
>
> Bah I just sign them all off then. It's still quicker.
>
> Done!

Thanks! I'll be more careful next time.

I guess I should base my next pull request on the new commit
73dacc3403436fc2 ("pinctrl: sh-pfc: Add r8a77470 PFC support") in your
tree, instead of on my previous pull request? Else there will be some
conflicts (I checked: so far in one file only).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

On Wed, May 16, 2018 at 7:40 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:

> I guess I should base my next pull request on the new commit
> 73dacc3403436fc2 ("pinctrl: sh-pfc: Add r8a77470 PFC support") in your
> tree, instead of on my previous pull request? Else there will be some
> conflicts (I checked: so far in one file only).

Yeah that should work. I try not to rebase my tree too much,
sometimes it happens anyway. This commit should be stable
and nice.

Yours,
Linus Walleij

linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

Hi all,

Commit

  c04c391aa743 ("dt-bindings: pinctrl: add rockchip,rk3036-pinctrl compatible string")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

On Fri, Apr 22, 2022 at 12:32 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Commit
>
>   c04c391aa743 ("dt-bindings: pinctrl: add rockchip,rk3036-pinctrl compatible string")
>
> is missing a Signed-off-by from its committer.

Thanks Stephen, fixed it up in-place.

Yours,
Linus Walleij

linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

Hi all,

Commit

  4f838411c98b ("pinctrl: bcm63xx: Fix More dependencies")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

Hi all,

Commit

  eb032d7b146b ("pinctrl: qcom: Remove duplicated include from pinctrl-msm.c")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

On Fri, Apr 17, 2020 at 12:30 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
>
> Commit
>
>   eb032d7b146b ("pinctrl: qcom: Remove duplicated include from pinctrl-msm.c")
>
> is missing a Signed-off-by from its committer.

Ooops sorry fixed it up.

Yours,
Linus Walleij

linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

Hi all,

Commit

  cc3abdb73df4 ("pinctrl: iproc: Add 'get_direction' support")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

On Wed, Sep 11, 2019 at 11:48 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

>   cc3abdb73df4 ("pinctrl: iproc: Add 'get_direction' support")
>
> is missing a Signed-off-by from its committer.

Thanks, fixed it up!

Yours,
Linus Walleij

linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Hi Linus,

Commit

  a742fcf72902 ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

Hm must have come from Geert's pull request?

(I'm regularly wrong about this so not so certain...)

Geert can I fix it the usual way by simply rebasing and
adding the right SoB?

Yours,
Linus Walleij

On Mon, Jul 9, 2018 at 11:54 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Linus,
>
> Commit
>
>   a742fcf72902 ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
>
> is missing a Signed-off-by from its author.
>
> --
> Cheers,
> Stephen Rothwell

RE: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Yoshihiro Shimoda]

Hi Stephen, Linus, Geert,

> -----Original Message-----
> From: Linus Walleij, Sent: Tuesday, July 10, 2018 7:46 AM
> 
> Hm must have come from Geert's pull request?
> 
> (I'm regularly wrong about this so not so certain...)
> 
> Geert can I fix it the usual way by simply rebasing and
> adding the right SoB?

I'm very sorry for this trouble.
When I ported this patch, I dropped the author's Signed-of-by wrongly..

Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>

Best regards,
Yoshihiro Shimoda

> Yours,
> Linus Walleij
> 
> On Mon, Jul 9, 2018 at 11:54 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi Linus,
> >
> > Commit
> >
> >   a742fcf72902 ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
> >
> > is missing a Signed-off-by from its author.
> >
> > --
> > Cheers,
> > Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Geert Uytterhoeven]

Hi Shimoda-san, Linus,

On Tue, Jul 10, 2018 at 3:18 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > -----Original Message-----
> > From: Linus Walleij, Sent: Tuesday, July 10, 2018 7:46 AM
> >
> > Hm must have come from Geert's pull request?
> >
> > (I'm regularly wrong about this so not so certain...)
> >
> > Geert can I fix it the usual way by simply rebasing and
> > adding the right SoB?
>
> I'm very sorry for this trouble.
> When I ported this patch, I dropped the author's Signed-of-by wrongly..
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>

Thank you!

Since this was the top commit from my last pull request, I've just ammended it,
retagged, and pushed.

Sorry for the trouble.

/me looks into improving checkpatch.pl...

> > On Mon, Jul 9, 2018 at 11:54 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > Commit
> > >
> > >   a742fcf72902 ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
> > >
> > > is missing a Signed-off-by from its author.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

Hi Linus,

Commit

  fc08fa6009a0 ("pinctrl: sh-pfc: r8a7795: remove duplicate of CLKOUT pin in pinmux_pins[]")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

On Wed, Mar 7, 2018 at 9:39 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> Commit
>
>   fc08fa6009a0 ("pinctrl: sh-pfc: r8a7795: remove duplicate of CLKOUT pin in pinmux_pins[]")
>
> is missing a Signed-off-by from its committer.

Looping in Geert,

I guess this came in through the Renesas PFC pull request.

Geert do you prefer that I back it all out so you can send me
a new pull request? Or some other solution?

Yours,
Linus Walleij

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Hi Linus,

On Wed, 7 Mar 2018 23:25:48 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Wed, Mar 7, 2018 at 9:39 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Commit
> >
> >   fc08fa6009a0 ("pinctrl: sh-pfc: r8a7795: remove duplicate of CLKOUT pin in pinmux_pins[]")
> >
> > is missing a Signed-off-by from its committer.  
> 
> Looping in Geert,
> 
> I guess this came in through the Renesas PFC pull request.
> 
> Geert do you prefer that I back it all out so you can send me
> a new pull request? Or some other solution?

But you are listed as the committer ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Geert Uytterhoeven]

Hi Stephen,

On Thu, Mar 8, 2018 at 1:36 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Wed, 7 Mar 2018 23:25:48 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Wed, Mar 7, 2018 at 9:39 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> > Commit
>> >
>> >   fc08fa6009a0 ("pinctrl: sh-pfc: r8a7795: remove duplicate of CLKOUT pin in pinmux_pins[]")
>> >
>> > is missing a Signed-off-by from its committer.
>>
>> Looping in Geert,
>>
>> I guess this came in through the Renesas PFC pull request.
>>
>> Geert do you prefer that I back it all out so you can send me
>> a new pull request? Or some other solution?
>
> But you are listed as the committer ...

Right, that's the bug fix I had asked Linus to take directly, as a fix
for v4.16.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

[Linus Walleij]

On Thu, Mar 8, 2018 at 1:36 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> On Wed, 7 Mar 2018 23:25:48 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>>
>> On Wed, Mar 7, 2018 at 9:39 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> > Commit
>> >
>> >   fc08fa6009a0 ("pinctrl: sh-pfc: r8a7795: remove duplicate of CLKOUT pin in pinmux_pins[]")
>> >
>> > is missing a Signed-off-by from its committer.
>>
>> Looping in Geert,
>>
>> I guess this came in through the Renesas PFC pull request.
>>
>> Geert do you prefer that I back it all out so you can send me
>> a new pull request? Or some other solution?
>
> But you are listed as the committer ...

Bah yeah this commit is on the fixes branch like Geert says, sorry it
is 100% my sloppy mistake.

I fixed it up and pushed the result for-next.

Sorry for the fuzz!

Yours,
Linus Walleij

linux-next: Signed-off-by missing for commit in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

Hi Linus,

Commit

  77bd5bf24c08 ("pinctrl: sh-pfc: r8a7795: remove duplicate of CLKOUT pin in pinmux_pins[]")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]