linux-next: build failure after merge of the pinctrl tree

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/pinctrl-st.c: In function 'st_pctl_dt_parse_groups':
drivers/pinctrl/pinctrl-st.c:1212:15: error: implicit declaration of function 'of_get_named_gpio'; did you mean 'of_get_address'? [-Werror=implicit-function-declaration]
   conf->pin = of_get_named_gpio(pins, pp->name, 0);
               ^~~~~~~~~~~~~~~~~
               of_get_address

Probably caused by commit

  712dfdaf62b6 ("pinctrl: st: Include the right header")

I have used the pinctrl tree from next-20190820 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Wed, Aug 21, 2019 at 8:16 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/pinctrl/pinctrl-st.c: In function 'st_pctl_dt_parse_groups':
> drivers/pinctrl/pinctrl-st.c:1212:15: error: implicit declaration of function 'of_get_named_gpio'; did you mean 'of_get_address'? [-Werror=implicit-function-declaration]
>    conf->pin = of_get_named_gpio(pins, pp->name, 0);
>                ^~~~~~~~~~~~~~~~~
>                of_get_address
>
> Probably caused by commit
>
>   712dfdaf62b6 ("pinctrl: st: Include the right header")

Yeah my mistake :(

I made a v2 patch fixing the error and took this out.

Thanks,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Nov 14, 2023 at 3:13 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:10: error: 'const struct lpi_pinctrl_variant_data' has no member named 'flags'
>   232 |         .flags = LPI_FLAG_SLEW_RATE_SAME_REG,
>       |          ^~~~~
> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: error: 'LPI_FLAG_SLEW_RATE_SAME_REG' undeclared here (not in a function); did you mean 'LPI_SLEW_RATE_CTL_REG'?
>   232 |         .flags = LPI_FLAG_SLEW_RATE_SAME_REG,
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                  LPI_SLEW_RATE_CTL_REG
> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: error: excess elements in struct initializer [-Werror]
> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: note: (near initialization for 'sm8650_lpi_data')
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   c4e47673853f ("pinctrl: qcom: sm8650-lpass-lpi: add SM8650 LPASS")

Ah I forgot a prerequisite patch we postponed before.

Applied it now so things should work by tomorrow, thanks!

Yours,
Linus Walleij

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:10: error: 'const struct lpi_pinctrl_variant_data' has no member named 'flags'
  232 |         .flags = LPI_FLAG_SLEW_RATE_SAME_REG,
      |          ^~~~~
drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: error: 'LPI_FLAG_SLEW_RATE_SAME_REG' undeclared here (not in a function); did you mean 'LPI_SLEW_RATE_CTL_REG'?
  232 |         .flags = LPI_FLAG_SLEW_RATE_SAME_REG,
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                  LPI_SLEW_RATE_CTL_REG
drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: error: excess elements in struct initializer [-Werror]
drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c:232:18: note: (near initialization for 'sm8650_lpi_data')
cc1: all warnings being treated as errors

Caused by commit

  c4e47673853f ("pinctrl: qcom: sm8650-lpass-lpi: add SM8650 LPASS")

I have used the pinctrl tree from next-20231113 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "debounce_time_mt6765" [drivers/pinctrl/mediatek/pinctrl-mt6765.ko] undefined!
ERROR: modpost: "debounce_time_mt2701" [drivers/pinctrl/mediatek/pinctrl-mt6779.ko] undefined!

Caused by commit

  e1ff91f9d230 ("pinctrl: mediatek: Fix EINT pins input debounce time configuration")

I have used the pinctrl tree from next-20221114 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Thu, Nov 10, 2022 at 5:09 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/pinctrl/pinctrl-loongson2.o
>
> Caused by commit
>
>   6b88d921f848 ("pinctrl: pinctrl-loongson2: add pinctrl driver support")
>
> I have used the pinctrl tree from next-20221108 again for today.

Fixed this by taking out the patches and waiting for a new revision.

Yours,
Linus Walleij

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: missing MODULE_LICENSE() in drivers/pinctrl/pinctrl-loongson2.o

Caused by commit

  6b88d921f848 ("pinctrl: pinctrl-loongson2: add pinctrl driver support")

I have used the pinctrl tree from next-20221108 again for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Wed, Nov 9, 2022 at 3:46 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Fixed by putting in a new v8 version from Yinbo.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Yinbo Zhu]

在 2022/11/9 上午10:46, Stephen Rothwell 写道:
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/pinctrl/pinctrl-loongson2.c:42:29: error: field 'desc' has incomplete type
>     42 |         struct pinctrl_desc desc;
>        |                             ^~~~
> drivers/pinctrl/pinctrl-loongson2.c:63:38: error: array type has incomplete element type 'struct pinctrl_pin_desc'
>     63 | static const struct pinctrl_pin_desc loongson2_pctrl_pins[] = {
>        |                                      ^~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:62:26: error: implicit declaration of function 'PINCTRL_PIN' [-Werror=implicit-function-declaration]
>     62 | #define LOONGSON2_PIN(x) PINCTRL_PIN(x, "gpio"#x)
>        |                          ^~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:64:9: note: in expansion of macro 'LOONGSON2_PIN'
>     64 |         LOONGSON2_PIN(0),  LOONGSON2_PIN(1),  LOONGSON2_PIN(2),  LOONGSON2_PIN(3),
>        |         ^~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c: In function 'loongson2_pin_dbg_show':
> drivers/pinctrl/pinctrl-loongson2.c:208:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
>    208 |         seq_printf(s, " %s", dev_name(pcdev->dev));
>        |         ^~~~~~~~~~
>        |         bstr_printf
> drivers/pinctrl/pinctrl-loongson2.c: At top level:
> drivers/pinctrl/pinctrl-loongson2.c:211:21: error: variable 'loongson2_pctrl_ops' has initializer but incomplete type
>    211 | static const struct pinctrl_ops loongson2_pctrl_ops = {
>        |                     ^~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:212:10: error: 'const struct pinctrl_ops' has no member named 'get_groups_count'
>    212 |         .get_groups_count       = loongson2_get_groups_count,
>        |          ^~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:212:35: error: excess elements in struct initializer [-Werror]
>    212 |         .get_groups_count       = loongson2_get_groups_count,
>        |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:212:35: note: (near initialization for 'loongson2_pctrl_ops')
> drivers/pinctrl/pinctrl-loongson2.c:213:10: error: 'const struct pinctrl_ops' has no member named 'get_group_name'
>    213 |         .get_group_name         = loongson2_get_group_name,
>        |          ^~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:213:35: error: excess elements in struct initializer [-Werror]
>    213 |         .get_group_name         = loongson2_get_group_name,
>        |                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:213:35: note: (near initialization for 'loongson2_pctrl_ops')
> drivers/pinctrl/pinctrl-loongson2.c:214:10: error: 'const struct pinctrl_ops' has no member named 'get_group_pins'
>    214 |         .get_group_pins         = loongson2_get_group_pins,
>        |          ^~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:214:35: error: excess elements in struct initializer [-Werror]
>    214 |         .get_group_pins         = loongson2_get_group_pins,
>        |                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:214:35: note: (near initialization for 'loongson2_pctrl_ops')
> drivers/pinctrl/pinctrl-loongson2.c:215:10: error: 'const struct pinctrl_ops' has no member named 'dt_node_to_map'
>    215 |         .dt_node_to_map         = pinconf_generic_dt_node_to_map_all,
>        |          ^~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:215:35: error: excess elements in struct initializer [-Werror]
>    215 |         .dt_node_to_map         = pinconf_generic_dt_node_to_map_all,
>        |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:215:35: note: (near initialization for 'loongson2_pctrl_ops')
> drivers/pinctrl/pinctrl-loongson2.c:216:10: error: 'const struct pinctrl_ops' has no member named 'dt_free_map'
>    216 |         .dt_free_map            = pinctrl_utils_free_map,
>        |          ^~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:216:35: error: excess elements in struct initializer [-Werror]
>    216 |         .dt_free_map            = pinctrl_utils_free_map,
>        |                                   ^~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:216:35: note: (near initialization for 'loongson2_pctrl_ops')
> drivers/pinctrl/pinctrl-loongson2.c:217:10: error: 'const struct pinctrl_ops' has no member named 'pin_dbg_show'
>    217 |         .pin_dbg_show           = loongson2_pin_dbg_show,
>        |          ^~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:217:35: error: excess elements in struct initializer [-Werror]
>    217 |         .pin_dbg_show           = loongson2_pin_dbg_show,
>        |                                   ^~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:217:35: note: (near initialization for 'loongson2_pctrl_ops')
> drivers/pinctrl/pinctrl-loongson2.c: In function 'loongson2_pmx_set_mux':
> drivers/pinctrl/pinctrl-loongson2.c:223:43: error: implicit declaration of function 'pinctrl_dev_get_drvdata'; did you mean 'dev_get_drvdata'? [-Werror=implicit-function-declaration]
>    223 |         struct loongson2_pinctrl *pctrl = pinctrl_dev_get_drvdata(pcdev);
>        |                                           ^~~~~~~~~~~~~~~~~~~~~~~
>        |                                           dev_get_drvdata
> drivers/pinctrl/pinctrl-loongson2.c:223:43: error: initialization of 'struct loongson2_pinctrl *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> In file included from include/linux/container_of.h:5,
>                   from include/linux/list.h:5,
>                   from include/linux/module.h:12,
>                   from drivers/pinctrl/pinctrl-loongson2.c:9:
> drivers/pinctrl/pinctrl-loongson2.c: In function 'loongson2_pinctrl_probe':
> include/linux/build_bug.h:16:51: error: bit-field '<anonymous>' width not an integer constant
>     16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
>        |                                                   ^
> include/linux/compiler.h:232:33: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
>    232 | #define __must_be_array(a)      BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
>        |                                 ^~~~~~~~~~~~~~~~~
> include/linux/kernel.h:55:59: note: in expansion of macro '__must_be_array'
>     55 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
>        |                                                           ^~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:294:35: note: in expansion of macro 'ARRAY_SIZE'
>    294 |         pctrl->desc.npins       = ARRAY_SIZE(loongson2_pctrl_pins);
>        |                                   ^~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:296:24: error: implicit declaration of function 'devm_pinctrl_register'; did you mean 'device_register'? [-Werror=implicit-function-declaration]
>    296 |         pctrl->pcdev = devm_pinctrl_register(pctrl->dev, &pctrl->desc, pctrl);
>        |                        ^~~~~~~~~~~~~~~~~~~~~
>        |                        device_register
> drivers/pinctrl/pinctrl-loongson2.c: At top level:
> drivers/pinctrl/pinctrl-loongson2.c:211:33: error: storage size of 'loongson2_pctrl_ops' isn't known
>    211 | static const struct pinctrl_ops loongson2_pctrl_ops = {
>        |                                 ^~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-loongson2.c:63:38: error: 'loongson2_pctrl_pins' defined but not used [-Werror=unused-variable]
>     63 | static const struct pinctrl_pin_desc loongson2_pctrl_pins[] = {
>        |                                      ^~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>    6c2a0a800390 ("pinctrl: pinctrl-loongson2: add pinctrl driver support")
> 
> I have used the pinctrl tree from next-20221108 for today.
I was test it that base on 6.1-rc3 master branch and it is okay, but in 
pinctrl tree test that need include following head file.
--- a/drivers/pinctrl/pinctrl-loongson2.c
+++ b/drivers/pinctrl/pinctrl-loongson2.c
@@ -11,6 +11,8 @@
  #include <linux/of.h>
  #include <linux/pinctrl/pinmux.h>
  #include <linux/pinctrl/pinconf-generic.h>
+#include <linux/pinctrl/pinctrl.h>
+#include <linux/seq_file.h>
  #include <asm-generic/io.h>

BRs,
Yinbo.
> 

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 7956 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/pinctrl/pinctrl-loongson2.c:42:29: error: field 'desc' has incomplete type
   42 |         struct pinctrl_desc desc;
      |                             ^~~~
drivers/pinctrl/pinctrl-loongson2.c:63:38: error: array type has incomplete element type 'struct pinctrl_pin_desc'
   63 | static const struct pinctrl_pin_desc loongson2_pctrl_pins[] = {
      |                                      ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:62:26: error: implicit declaration of function 'PINCTRL_PIN' [-Werror=implicit-function-declaration]
   62 | #define LOONGSON2_PIN(x) PINCTRL_PIN(x, "gpio"#x)
      |                          ^~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:64:9: note: in expansion of macro 'LOONGSON2_PIN'
   64 |         LOONGSON2_PIN(0),  LOONGSON2_PIN(1),  LOONGSON2_PIN(2),  LOONGSON2_PIN(3),
      |         ^~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c: In function 'loongson2_pin_dbg_show':
drivers/pinctrl/pinctrl-loongson2.c:208:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
  208 |         seq_printf(s, " %s", dev_name(pcdev->dev));
      |         ^~~~~~~~~~
      |         bstr_printf
drivers/pinctrl/pinctrl-loongson2.c: At top level:
drivers/pinctrl/pinctrl-loongson2.c:211:21: error: variable 'loongson2_pctrl_ops' has initializer but incomplete type
  211 | static const struct pinctrl_ops loongson2_pctrl_ops = {
      |                     ^~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:212:10: error: 'const struct pinctrl_ops' has no member named 'get_groups_count'
  212 |         .get_groups_count       = loongson2_get_groups_count,
      |          ^~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:212:35: error: excess elements in struct initializer [-Werror]
  212 |         .get_groups_count       = loongson2_get_groups_count,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:212:35: note: (near initialization for 'loongson2_pctrl_ops')
drivers/pinctrl/pinctrl-loongson2.c:213:10: error: 'const struct pinctrl_ops' has no member named 'get_group_name'
  213 |         .get_group_name         = loongson2_get_group_name,
      |          ^~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:213:35: error: excess elements in struct initializer [-Werror]
  213 |         .get_group_name         = loongson2_get_group_name,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:213:35: note: (near initialization for 'loongson2_pctrl_ops')
drivers/pinctrl/pinctrl-loongson2.c:214:10: error: 'const struct pinctrl_ops' has no member named 'get_group_pins'
  214 |         .get_group_pins         = loongson2_get_group_pins,
      |          ^~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:214:35: error: excess elements in struct initializer [-Werror]
  214 |         .get_group_pins         = loongson2_get_group_pins,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:214:35: note: (near initialization for 'loongson2_pctrl_ops')
drivers/pinctrl/pinctrl-loongson2.c:215:10: error: 'const struct pinctrl_ops' has no member named 'dt_node_to_map'
  215 |         .dt_node_to_map         = pinconf_generic_dt_node_to_map_all,
      |          ^~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:215:35: error: excess elements in struct initializer [-Werror]
  215 |         .dt_node_to_map         = pinconf_generic_dt_node_to_map_all,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:215:35: note: (near initialization for 'loongson2_pctrl_ops')
drivers/pinctrl/pinctrl-loongson2.c:216:10: error: 'const struct pinctrl_ops' has no member named 'dt_free_map'
  216 |         .dt_free_map            = pinctrl_utils_free_map,
      |          ^~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:216:35: error: excess elements in struct initializer [-Werror]
  216 |         .dt_free_map            = pinctrl_utils_free_map,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:216:35: note: (near initialization for 'loongson2_pctrl_ops')
drivers/pinctrl/pinctrl-loongson2.c:217:10: error: 'const struct pinctrl_ops' has no member named 'pin_dbg_show'
  217 |         .pin_dbg_show           = loongson2_pin_dbg_show,
      |          ^~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:217:35: error: excess elements in struct initializer [-Werror]
  217 |         .pin_dbg_show           = loongson2_pin_dbg_show,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:217:35: note: (near initialization for 'loongson2_pctrl_ops')
drivers/pinctrl/pinctrl-loongson2.c: In function 'loongson2_pmx_set_mux':
drivers/pinctrl/pinctrl-loongson2.c:223:43: error: implicit declaration of function 'pinctrl_dev_get_drvdata'; did you mean 'dev_get_drvdata'? [-Werror=implicit-function-declaration]
  223 |         struct loongson2_pinctrl *pctrl = pinctrl_dev_get_drvdata(pcdev);
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~
      |                                           dev_get_drvdata
drivers/pinctrl/pinctrl-loongson2.c:223:43: error: initialization of 'struct loongson2_pinctrl *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
In file included from include/linux/container_of.h:5,
                 from include/linux/list.h:5,
                 from include/linux/module.h:12,
                 from drivers/pinctrl/pinctrl-loongson2.c:9:
drivers/pinctrl/pinctrl-loongson2.c: In function 'loongson2_pinctrl_probe':
include/linux/build_bug.h:16:51: error: bit-field '<anonymous>' width not an integer constant
   16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
      |                                                   ^
include/linux/compiler.h:232:33: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
  232 | #define __must_be_array(a)      BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
      |                                 ^~~~~~~~~~~~~~~~~
include/linux/kernel.h:55:59: note: in expansion of macro '__must_be_array'
   55 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
      |                                                           ^~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:294:35: note: in expansion of macro 'ARRAY_SIZE'
  294 |         pctrl->desc.npins       = ARRAY_SIZE(loongson2_pctrl_pins);
      |                                   ^~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:296:24: error: implicit declaration of function 'devm_pinctrl_register'; did you mean 'device_register'? [-Werror=implicit-function-declaration]
  296 |         pctrl->pcdev = devm_pinctrl_register(pctrl->dev, &pctrl->desc, pctrl);
      |                        ^~~~~~~~~~~~~~~~~~~~~
      |                        device_register
drivers/pinctrl/pinctrl-loongson2.c: At top level:
drivers/pinctrl/pinctrl-loongson2.c:211:33: error: storage size of 'loongson2_pctrl_ops' isn't known
  211 | static const struct pinctrl_ops loongson2_pctrl_ops = {
      |                                 ^~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-loongson2.c:63:38: error: 'loongson2_pctrl_pins' defined but not used [-Werror=unused-variable]
   63 | static const struct pinctrl_pin_desc loongson2_pctrl_pins[] = {
      |                                      ^~~~~~~~~~~~~~~~~~~~

Caused by commit

  6c2a0a800390 ("pinctrl: pinctrl-loongson2: add pinctrl driver support")

I have used the pinctrl tree from next-20221108 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

Hello Linus,

On Fri, Aug 26, 2022 at 03:18:25PM +0200, Linus Walleij wrote:
> On Fri, Aug 26, 2022 at 1:20 PM Wolfram Sang <wsa@the-dreams.de> wrote:
> 
> > > How typical, the ideal way to resolve it is if there is an immutable
> > > branch with the basic changes I can pull in from the i2c tree
> >
> > It is already there:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/make_remove_callback_void-immutable
> 
> Oh excellent, pulled this in and applied Stephens fixup on top.

Ideally you would have squashed the fixup into the merge commit. With
the history as it is now you introduced a commit (i.e.  1681956cb79c
("Merge branch 'i2c/make_remove_callback_void-immutable' of
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux into devel"))
that fails to compile the pinctrl-cy8c95x0 driver. Also a better subject
line than "pinctrl: fixup for "i2c: Make remove callback return void""
would be nice, I would have mentioned 'cy8c95x0' at least. (But this is
mood of course if your tree is already stable or you remerge and
squash.)

> > Uwe (originator of the series) spread this information. Sorry that it
> > did not reach you.
> 
> Don't worry about that, there is no perfect process.

This commit touches quite a lot of files and subsystems. In the first
revision I added all affected maintainers and lists. vger refused the
mail because the the headers got too long.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Aug 26, 2022 at 1:20 PM Wolfram Sang <wsa@the-dreams.de> wrote:

> > How typical, the ideal way to resolve it is if there is an immutable
> > branch with the > basic changes I can pull in from the i2c tree
>
> It is already there:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/make_remove_callback_void-immutable

Oh excellent, pulled this in and applied Stephens fixup on top.

> Uwe (originator of the series) spread this information. Sorry that it
> did not reach you.

Don't worry about that, there is no perfect process.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi Linus,

> How typical, the ideal way to resolve it is if there is an immutable
> branch with the > basic changes I can pull in from the i2c tree

It is already there:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/make_remove_callback_void-immutable

Uwe (originator of the series) spread this information. Sorry that it
did not reach you.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Aug 26, 2022 at 7:26 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
(...)
> Caused by commit
>
>   e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support")
>
> interacting with commit
>
>   ed5c2f5fd10d ("i2c: Make remove callback return void")
>
> from the i2c tree.

How typical, the ideal way to resolve it is if there is an immutable
branch with the
basic changes I can pull in from the i2c tree and apply Stephen's fix on top,
or we can just wait for the merge window and let Torvalds sort it out?

Yours,
Linus Walleij

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/pinctrl/pinctrl-cy8c95x0.c:1371:27: error: initialization of 'void (*)(struct i2c_client *)' from incompatible pointer type 'int (*)(struct i2c_client *)' [-Werror=incompatible-pointer-types]
 1371 |         .remove         = cy8c95x0_remove,
      |                           ^~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-cy8c95x0.c:1371:27: note: (near initialization for 'cy8c95x0_driver.remove')

Caused by commit

  e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support")

interacting with commit

  ed5c2f5fd10d ("i2c: Make remove callback return void")

from the i2c tree.

I have applied the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 26 Aug 2022 15:20:29 +1000
Subject: [PATCH] pinctrl: fixup for "i2c: Make remove callback return void"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pinctrl/pinctrl-cy8c95x0.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c
index a29df0920f4f..05791212822e 100644
--- a/drivers/pinctrl/pinctrl-cy8c95x0.c
+++ b/drivers/pinctrl/pinctrl-cy8c95x0.c
@@ -1352,14 +1352,12 @@ static int cy8c95x0_probe(struct i2c_client *client)
 	return ret;
 }
 
-static int cy8c95x0_remove(struct i2c_client *client)
+static void cy8c95x0_remove(struct i2c_client *client)
 {
 	struct cy8c95x0_pinctrl *chip = i2c_get_clientdata(client);
 
 	if (!IS_ERR_OR_NULL(chip->regulator))
 		regulator_disable(chip->regulator);
-
-	return 0;
 }
 
 static struct i2c_driver cy8c95x0_driver = {
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Mario Limonciello]

On 8/2/22 17:21, broonie@kernel.org wrote:
> Hi all,
> 
> After merging the pinctrl-samsung tree, today's linux-next build
> (x86 allmodconfig) failed like this:
> 
> /tmp/next/build/drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show':
> /tmp/next/build/drivers/pinctrl/pinctrl-amd.c:219:8: error: unused variable 'output_enable' [-Werror=unused-variable]
>    219 |  char *output_enable;
>        |        ^~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>    e8129a076a509c ("pinctrl: amd: Use unicode for debugfs output")
> 
> I have reverted that commit for today.


I submitted this yesterday to fix it:

https://lore.kernel.org/linux-gpio/20220801144952.141-1-mario.limonciello@amd.com/

linux-next: build failure after merge of the pinctrl tree

[broonie]

Hi all,

After merging the pinctrl-samsung tree, today's linux-next build
(x86 allmodconfig) failed like this:

/tmp/next/build/drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show':
/tmp/next/build/drivers/pinctrl/pinctrl-amd.c:219:8: error: unused variable 'output_enable' [-Werror=unused-variable]
  219 |  char *output_enable;
      |        ^~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  e8129a076a509c ("pinctrl: amd: Use unicode for debugfs output")

I have reverted that commit for today.

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (arm64 defconig)
failed like this:

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_pinctrl_probe':
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:391:31: error: assignment of member 'is_clk_optional' in read-only object
  391 |         data->is_clk_optional = of_property_read_bool(dev->of_node,
      |                               ^

Caused by commit

  36fe26843d6d ("pinctrl: qcom: sc7280: Add clock optional check for ADSP bypass targets")

I am beginning to wonder if this commit has ever even been compile
tested :-(

I have reverted that commit (and its follow up fix) for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (arm64 defconfig)
failed like this:

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_pinctrl_probe':
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:391:55: error: 'np' undeclared (first use in this function); did you mean 'up'?
  391 |         data->is_clk_optional = of_property_read_bool(np, "qcom,adsp-bypass-mode");
      |                                                       ^~
      |                                                       up
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:391:55: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  36fe26843d6d ("pinctrl: qcom: sc7280: Add clock optional check for ADSP bypass targets")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Thu, Oct 28, 2021 at 2:31 PM Prathamesh Shete <pshete@nvidia.com> wrote:

> Thanks Dmitry for pointing out.
> Attached patch to fix the issue.
> Please help apply the patch.

Patch applied for fixes.

Yours,
Linus Walleij

RE: linux-next: build failure after merge of the pinctrl tree

[Prathamesh Shete]

[-- Attachment #1: Type: text/plain, Size: 2662 bytes --]

Thanks Dmitry for pointing out.
Attached patch to fix the issue.
Please help apply the patch.

Thanks
Prathamesh.

-----Original Message-----
From: Dmitry Osipenko <digetx@gmail.com> 
Sent: Wednesday, October 27, 2021 2:51 AM
To: Prathamesh Shete <pshete@nvidia.com>; Stephen Rothwell <sfr@canb.auug.org.au>; Linus Walleij <linus.walleij@linaro.org>
Cc: Kartik . <kkartik@nvidia.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the pinctrl tree

External email: Use caution opening links or attachments


26.10.2021 15:30, Prathamesh Shete пишет:
> Fixed following warnings and error.
> Attached the patch that fixes the issue.
> Please help apply the Patch.
>
> Thanks
> Prathamesh.
>
> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Tuesday, October 26, 2021 10:59 AM
> To: Linus Walleij <linus.walleij@linaro.org>
> Cc: Kartik . <kkartik@nvidia.com>; Prathamesh Shete 
> <pshete@nvidia.com>; Linux Kernel Mailing List 
> <linux-kernel@vger.kernel.org>; Linux Next Mailing List 
> <linux-next@vger.kernel.org>
> Subject: linux-next: build failure after merge of the pinctrl tree
>
> Hi all,
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_get_group':
> drivers/pinctrl/tegra/pinctrl-tegra.c:293:12: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   293 |     return &pmx->soc->groups[group];
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/tegra/pinctrl-tegra.c:282:25: warning: unused variable 'g' [-Wunused-variable]
>   282 |  struct tegra_pingroup *g;
>       |                         ^
> drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_gpio_disable_free':
> drivers/pinctrl/tegra/pinctrl-tegra.c:341:10: error: 'return' with a value, in function returning void [-Werror=return-type]
>   341 |   return -EINVAL;
>       |          ^
> drivers/pinctrl/tegra/pinctrl-tegra.c:327:13: note: declared here
>   327 | static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   a42c7d95d29e ("pinctrl: tegra: Use correct offset for pin group")
>
> I have used the pinctrl tree from next-20211025 for today.
>

The tegra_pinctrl_get_group() should return const and not cast the pointers. Please make another patch to fix it properly.

[-- Attachment #2: 0001-pinctrl-tegra-Return-const-pointer-from-tegra_pinctr.patch --]
[-- Type: application/octet-stream, Size: 1419 bytes --]

From 247a23a8ba6378fb6bd9100b93e82f109deb9c2b Mon Sep 17 00:00:00 2001
From: Prathamesh Shete <pshete@nvidia.com>
Date: Thu, 28 Oct 2021 17:32:35 +0530
Subject: [PATCH] pinctrl: tegra: Return const pointer from
 tegra_pinctrl_get_group()

Instead of returning const pointer from tegra_pinctrl_get_group()
the return value is being casted.

This change helps return const pointer.

Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
---
 drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index 8d734bfc33d2..50bd26a30ac0 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -275,7 +275,7 @@ static int tegra_pinctrl_set_mux(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-static struct tegra_pingroup *tegra_pinctrl_get_group(struct pinctrl_dev *pctldev,
+static const struct tegra_pingroup *tegra_pinctrl_get_group(struct pinctrl_dev *pctldev,
 					unsigned int offset)
 {
 	struct tegra_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
@@ -289,7 +289,7 @@ static struct tegra_pingroup *tegra_pinctrl_get_group(struct pinctrl_dev *pctlde
 			continue;
 		for (j = 0; j < num_pins; j++) {
 			if (offset == pins[j])
-				return (struct tegra_pingroup *)&pmx->soc->groups[group];
+				return &pmx->soc->groups[group];
 		}
 	}
 
-- 
2.17.1

Re: linux-next: build failure after merge of the pinctrl tree

[Dmitry Osipenko]

26.10.2021 15:30, Prathamesh Shete пишет:
> Fixed following warnings and error.
> Attached the patch that fixes the issue.
> Please help apply the Patch.
> 
> Thanks
> Prathamesh.
> 
> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au> 
> Sent: Tuesday, October 26, 2021 10:59 AM
> To: Linus Walleij <linus.walleij@linaro.org>
> Cc: Kartik . <kkartik@nvidia.com>; Prathamesh Shete <pshete@nvidia.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_get_group':
> drivers/pinctrl/tegra/pinctrl-tegra.c:293:12: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   293 |     return &pmx->soc->groups[group];
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/tegra/pinctrl-tegra.c:282:25: warning: unused variable 'g' [-Wunused-variable]
>   282 |  struct tegra_pingroup *g;
>       |                         ^
> drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_gpio_disable_free':
> drivers/pinctrl/tegra/pinctrl-tegra.c:341:10: error: 'return' with a value, in function returning void [-Werror=return-type]
>   341 |   return -EINVAL;
>       |          ^
> drivers/pinctrl/tegra/pinctrl-tegra.c:327:13: note: declared here
>   327 | static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   a42c7d95d29e ("pinctrl: tegra: Use correct offset for pin group")
> 
> I have used the pinctrl tree from next-20211025 for today.
> 

The tegra_pinctrl_get_group() should return const and not cast the
pointers. Please make another patch to fix it properly.

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Oct 26, 2021 at 2:30 PM Prathamesh Shete <pshete@nvidia.com> wrote:

> Fixed following warnings and error.
> Attached the patch that fixes the issue.
> Please help apply the Patch.

I applied the patch!

Yours,
Linus Walleij

RE: linux-next: build failure after merge of the pinctrl tree

[Prathamesh Shete]

[-- Attachment #1: Type: text/plain, Size: 1792 bytes --]

Fixed following warnings and error.
Attached the patch that fixes the issue.
Please help apply the Patch.

Thanks
Prathamesh.

-----Original Message-----
From: Stephen Rothwell <sfr@canb.auug.org.au> 
Sent: Tuesday, October 26, 2021 10:59 AM
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Kartik . <kkartik@nvidia.com>; Prathamesh Shete <pshete@nvidia.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the pinctrl tree

Hi all,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_get_group':
drivers/pinctrl/tegra/pinctrl-tegra.c:293:12: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  293 |     return &pmx->soc->groups[group];
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra.c:282:25: warning: unused variable 'g' [-Wunused-variable]
  282 |  struct tegra_pingroup *g;
      |                         ^
drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_gpio_disable_free':
drivers/pinctrl/tegra/pinctrl-tegra.c:341:10: error: 'return' with a value, in function returning void [-Werror=return-type]
  341 |   return -EINVAL;
      |          ^
drivers/pinctrl/tegra/pinctrl-tegra.c:327:13: note: declared here
  327 | static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  a42c7d95d29e ("pinctrl: tegra: Use correct offset for pin group")

I have used the pinctrl tree from next-20211025 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: 0001-pinctrl-tegra-Fix-warnings-and-error.patch --]
[-- Type: application/octet-stream, Size: 1541 bytes --]

From d40c09bfd0415b57e102b1be3818b02a2d1080a9 Mon Sep 17 00:00:00 2001
From: Prathamesh Shete <pshete@nvidia.com>
Date: Tue, 26 Oct 2021 17:41:35 +0530
Subject: [PATCH] pinctrl: tegra: Fix warnings and error

Fix warnings are errors caused by commit a42c7d95d29e
("pinctrl: tegra: Use correct offset for pin group").

Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
---
 drivers/pinctrl/tegra/pinctrl-tegra.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index 0471d9c7f0ba..8d734bfc33d2 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -279,7 +279,6 @@ static struct tegra_pingroup *tegra_pinctrl_get_group(struct pinctrl_dev *pctlde
 					unsigned int offset)
 {
 	struct tegra_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
-	struct tegra_pingroup *g;
 	unsigned int group, num_pins, j;
 	const unsigned int *pins;
 	int ret;
@@ -290,7 +289,7 @@ static struct tegra_pingroup *tegra_pinctrl_get_group(struct pinctrl_dev *pctlde
 			continue;
 		for (j = 0; j < num_pins; j++) {
 			if (offset == pins[j])
-				return &pmx->soc->groups[group];
+				return (struct tegra_pingroup *)&pmx->soc->groups[group];
 		}
 	}
 
@@ -338,7 +337,7 @@ static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
 	group = tegra_pinctrl_get_group(pctldev, offset);
 
 	if (!group)
-		return -EINVAL;
+		return;
 
 	if (group->mux_reg < 0 || group->sfsel_bit < 0)
 		return;
-- 
2.17.1

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_get_group':
drivers/pinctrl/tegra/pinctrl-tegra.c:293:12: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  293 |     return &pmx->soc->groups[group];
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra.c:282:25: warning: unused variable 'g' [-Wunused-variable]
  282 |  struct tegra_pingroup *g;
      |                         ^
drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_gpio_disable_free':
drivers/pinctrl/tegra/pinctrl-tegra.c:341:10: error: 'return' with a value, in function returning void [-Werror=return-type]
  341 |   return -EINVAL;
      |          ^
drivers/pinctrl/tegra/pinctrl-tegra.c:327:13: note: declared here
  327 | static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  a42c7d95d29e ("pinctrl: tegra: Use correct offset for pin group")

I have used the pinctrl tree from next-20211025 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

Hi,

On Fri, 5 Mar 2021 08:46:46 +0800 "jay.xu@rock-chips.com" <jay.xu@rock-chips.com> wrote:
>
> Thanks，and I think i have miss to upstream the changes,
> I have resend them in a new thread.
> 
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -155,9 +155,7 @@ config ARCH_REALTEK
>  config ARCH_ROCKCHIP
>         bool "Rockchip Platforms"
>         select ARCH_HAS_RESET_CONTROLLER
> -       select GPIOLIB
>         select PINCTRL
> -       select PINCTRL_ROCKCHIP
>         select PM
>         select ROCKCHIP_TIMER
>         help
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index b197d23324fb..970c18191f6f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -179,10 +179,14 @@ config PINCTRL_OXNAS
>  
>  config PINCTRL_ROCKCHIP
>         tristate "Rockchip gpio and pinctrl driver"
> +       select GPIOLIB
>         select PINMUX
>         select GENERIC_PINCONF
>         select GENERIC_IRQ_CHIP
>         select MFD_SYSCON
> +       default ARCH_ROCKCHIP
> +       help
> +         This support pinctrl and gpio driver for Rockchip SoCs.
>  
>  config PINCTRL_RZA1
>         bool "Renesas RZ/A1 gpio and pinctrl driver"
> 
> 
>  
> From: Linus Walleij
> Date: 2021-03-05 08:43
> To: jay.xu@rock-chips.com
> CC: Stephen Rothwell; Linux Kernel Mailing List; Linux Next Mailing List
> Subject: Re: Re: linux-next: build failure after merge of the pinctrl tree
> On Fri, Mar 5, 2021 at 1:13 AM jay.xu@rock-chips.com
> <jay.xu@rock-chips.com> wrote:
>  
> > Could you show me the issue log ?  
>  
> It's attached to Stephen's original mail in this thread.

Sorry I lost the error message, but it was a reference to a symbol that
has no EXPORT_SYMBOL.  So building the driver as a module should show
the error.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi Linus,

On Thu, 4 Mar 2021 09:16:17 +0100 Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Thu, Mar 4, 2021 at 2:12 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > After merging the pinctrl tree, today's linux-next build (x86_64
> > allmodconfig ) failed like this:
> >
> >
> > Presumably caused by commit
> >
> >   c9e84d46cc03 ("pinctrl: rockchip: make driver be tristate module")
> >
> > I have used the pinctrl tree from next-20210303 for today.  
> 
> Thanks Stephen, I'm taking the patch out again.

Sorry I managed to not put the error message in the mail :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Thu, Mar 4, 2021 at 2:12 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig ) failed like this:
>
>
> Presumably caused by commit
>
>   c9e84d46cc03 ("pinctrl: rockchip: make driver be tristate module")
>
> I have used the pinctrl tree from next-20210303 for today.

Thanks Stephen, I'm taking the patch out again.

Yours,
Linus Walleij

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig ) failed like this:


Presumably caused by commit

  c9e84d46cc03 ("pinctrl: rockchip: make driver be tristate module")

I have used the pinctrl tree from next-20210303 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Krzysztof Kozlowski]

On Wed, Jan 27, 2021 at 08:41:26PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Thanks for the message. This should be fixed already.

Best regards,
Krzysztof

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3250 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/wait.h:9,
                 from include/linux/pid.h:6,
                 from include/linux/sched.h:14,
                 from include/linux/ratelimit.h:6,
                 from include/linux/dev_printk.h:16,
                 from include/linux/device.h:15,
                 from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
drivers/pinctrl/samsung/pinctrl-s3c64xx.c: In function 's3c64xx_irq_set_function':
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:289:20: error: passing argument 1 of 'spinlock_check' from incompatible pointer type [-Werror=incompatible-pointer-types]
  289 |  spin_lock_irqsave(&bank->slock, flags);
      |                    ^~~~~~~~~~~~
      |                    |
      |                    raw_spinlock_t * {aka struct raw_spinlock *}
include/linux/spinlock.h:252:34: note: in definition of macro 'raw_spin_lock_irqsave'
  252 |   flags = _raw_spin_lock_irqsave(lock); \
      |                                  ^~~~
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:289:2: note: in expansion of macro 'spin_lock_irqsave'
  289 |  spin_lock_irqsave(&bank->slock, flags);
      |  ^~~~~~~~~~~~~~~~~
In file included from include/linux/wait.h:9,
                 from include/linux/pid.h:6,
                 from include/linux/sched.h:14,
                 from include/linux/ratelimit.h:6,
                 from include/linux/dev_printk.h:16,
                 from include/linux/device.h:15,
                 from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
include/linux/spinlock.h:327:67: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct raw_spinlock *'}
  327 | static __always_inline raw_spinlock_t *spinlock_check(spinlock_t *lock)
      |                                                       ~~~~~~~~~~~~^~~~
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:296:25: error: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [-Werror=incompatible-pointer-types]
  296 |  spin_unlock_irqrestore(&bank->slock, flags);
      |                         ^~~~~~~~~~~~
      |                         |
      |                         raw_spinlock_t * {aka struct raw_spinlock *}
In file included from include/linux/wait.h:9,
                 from include/linux/pid.h:6,
                 from include/linux/sched.h:14,
                 from include/linux/ratelimit.h:6,
                 from include/linux/dev_printk.h:16,
                 from include/linux/device.h:15,
                 from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
include/linux/spinlock.h:407:64: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct raw_spinlock *'}
  407 | static __always_inline void spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags)
      |                                                    ~~~~~~~~~~~~^~~~

Caused by commit

  1f306ecbe0f6 ("pinctrl: samsung: use raw_spinlock for locking")

I have used the pinctrl tree from next-20210125 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Wed, Nov 4, 2020 at 4:10 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Fri, 30 Oct 2020 12:50:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the pinctrl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: modpost: "irq_gc_set_wake" [drivers/pinctrl/pinctrl-rockchip.ko] undefined!
> >
> > Caused by commit
> >
> >   6c684f5e79ea ("pinctrl: rockchip: make driver be tristate module")
> >
> > I have reverted that commit for today.
>
> I am still getting this failure.

Sorry for the mess, I dropped this commit now.

I think we need a separate patch to export that call
before we make Rockchip tristate.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hi all,

On Fri, 30 Oct 2020 12:50:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: modpost: "irq_gc_set_wake" [drivers/pinctrl/pinctrl-rockchip.ko] undefined!
> 
> Caused by commit
> 
>   6c684f5e79ea ("pinctrl: rockchip: make driver be tristate module")
> 
> I have reverted that commit for today.

I am still getting this failure.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "irq_gc_set_wake" [drivers/pinctrl/pinctrl-rockchip.ko] undefined!

Caused by commit

  6c684f5e79ea ("pinctrl: rockchip: make driver be tristate module")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Jul 17, 2020 at 11:01 AM Hanks Chen <hanks.chen@mediatek.com> wrote:
> On Fri, 2020-07-17 at 17:16 +1000, Stephen Rothwell wrote:

> > Caused by commit
> >
> >   e6f744c6ad4f ("pinctrl: mediatek: add pinctrl support for MT6779 SoC")
> >
> > Forgot to include module.h (since it is tristate in Kconfig) or init.h?
> >
> > I used the pinctrl tree from next-20200716 for today.
> >
>
> My fault, I'll fix it in next version.
> (Series: Add basic SoC Support for Mediatek MT6779 SoC)

OK I pulled out all the MTK6779 patches from my tree and wait
for a new version.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Hanks Chen]

On Fri, 2020-07-17 at 17:16 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: data definition has no type or storage class
>   783 | arch_initcall(mt6779_pinctrl_init);
>       | ^~~~~~~~~~~~~
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int]
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: parameter names (without types) in function declaration
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:779:19: warning: 'mt6779_pinctrl_init' defined but not used [-Wunused-function]
>   779 | static int __init mt6779_pinctrl_init(void)
>       |                   ^~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   e6f744c6ad4f ("pinctrl: mediatek: add pinctrl support for MT6779 SoC")
> 
> Forgot to include module.h (since it is tristate in Kconfig) or init.h?
> 
> I used the pinctrl tree from next-20200716 for today.
> 

My fault, I'll fix it in next version.
(Series: Add basic SoC Support for Mediatek MT6779 SoC)

Thank you for your message


Hanks Chen

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: data definition has no type or storage class
  783 | arch_initcall(mt6779_pinctrl_init);
      | ^~~~~~~~~~~~~
drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int]
drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: parameter names (without types) in function declaration
drivers/pinctrl/mediatek/pinctrl-mt6779.c:779:19: warning: 'mt6779_pinctrl_init' defined but not used [-Wunused-function]
  779 | static int __init mt6779_pinctrl_init(void)
      |                   ^~~~~~~~~~~~~~~~~~~

Caused by commit

  e6f744c6ad4f ("pinctrl: mediatek: add pinctrl support for MT6779 SoC")

Forgot to include module.h (since it is tristate in Kconfig) or init.h?

I used the pinctrl tree from next-20200716 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 5201 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/qcom/pinctrl-msm.c:909:4: error: expected identifier or '(' before 'else'
  909 |  } else {
      |    ^~~~
drivers/pinctrl/qcom/pinctrl-msm.c:921:2: warning: data definition has no type or storage class
  921 |  val = msm_readl_intr_cfg(pctrl, g);
      |  ^~~
drivers/pinctrl/qcom/pinctrl-msm.c:921:2: error: type defaults to 'int' in declaration of 'val' [-Werror=implicit-int]
drivers/pinctrl/qcom/pinctrl-msm.c:921:27: error: 'pctrl' undeclared here (not in a function); did you mean 'pinctrl'?
  921 |  val = msm_readl_intr_cfg(pctrl, g);
      |                           ^~~~~
      |                           pinctrl
drivers/pinctrl/qcom/pinctrl-msm.c:921:34: error: 'g' undeclared here (not in a function)
  921 |  val = msm_readl_intr_cfg(pctrl, g);
      |                                  ^
drivers/pinctrl/qcom/pinctrl-msm.c:922:6: error: expected '=', ',', ';', 'asm' or '__attribute__' before '|=' token
  922 |  val |= BIT(g->intr_raw_status_bit);
      |      ^~
drivers/pinctrl/qcom/pinctrl-msm.c:923:2: error: expected identifier or '(' before 'if'
  923 |  if (g->intr_detection_width == 2) {
      |  ^~
drivers/pinctrl/qcom/pinctrl-msm.c:945:4: error: expected identifier or '(' before 'else'
  945 |  } else if (g->intr_detection_width == 1) {
      |    ^~~~
drivers/pinctrl/qcom/pinctrl-msm.c:966:4: error: expected identifier or '(' before 'else'
  966 |  } else {
      |    ^~~~
drivers/pinctrl/qcom/pinctrl-msm.c:969:2: warning: data definition has no type or storage class
  969 |  msm_writel_intr_cfg(val, pctrl, g);
      |  ^~~~~~~~~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:969:2: error: type defaults to 'int' in declaration of 'msm_writel_intr_cfg' [-Werror=implicit-int]
drivers/pinctrl/qcom/pinctrl-msm.c:969:2: warning: parameter names (without types) in function declaration
drivers/pinctrl/qcom/pinctrl-msm.c:969:2: error: conflicting types for 'msm_writel_intr_cfg'
drivers/pinctrl/qcom/pinctrl-msm.c:84:13: note: previous definition of 'msm_writel_intr_cfg' was here
   84 | static void msm_writel_##name(u32 val, struct msm_pinctrl *pctrl, \
      |             ^~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:92:1: note: in expansion of macro 'MSM_ACCESSOR'
   92 | MSM_ACCESSOR(intr_cfg)
      | ^~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:971:2: error: expected identifier or '(' before 'if'
  971 |  if (test_bit(d->hwirq, pctrl->dual_edge_irqs))
      |  ^~
In file included from include/linux/vmalloc.h:5,
                 from include/asm-generic/io.h:887,
                 from arch/arm/include/asm/io.h:438,
                 from include/linux/io.h:13,
                 from drivers/pinctrl/qcom/pinctrl-msm.c:9:
include/linux/spinlock.h:287:2: error: expected identifier or '(' before 'do'
  287 |  do {       \
      |  ^~
drivers/pinctrl/qcom/pinctrl-msm.c:974:2: note: in expansion of macro 'raw_spin_unlock_irqrestore'
  974 |  raw_spin_unlock_irqrestore(&pctrl->lock, flags);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/spinlock.h:290:4: error: expected identifier or '(' before 'while'
  290 |  } while (0)
      |    ^~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:974:2: note: in expansion of macro 'raw_spin_unlock_irqrestore'
  974 |  raw_spin_unlock_irqrestore(&pctrl->lock, flags);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:976:2: error: expected identifier or '(' before 'if'
  976 |  if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
      |  ^~
drivers/pinctrl/qcom/pinctrl-msm.c:978:2: error: expected identifier or '(' before 'else'
  978 |  else if (type & (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
      |  ^~~~
drivers/pinctrl/qcom/pinctrl-msm.c:981:2: error: expected identifier or '(' before 'return'
  981 |  return 0;
      |  ^~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:982:1: error: expected identifier or '(' before '}' token
  982 | }
      | ^
drivers/pinctrl/qcom/pinctrl-msm.c: In function 'msm_gpio_irq_set_type':
drivers/pinctrl/qcom/pinctrl-msm.c:909:2: warning: control reaches end of non-void function [-Wreturn-type]
  909 |  } else {
      |  ^
At top level:
drivers/pinctrl/qcom/pinctrl-msm.c:84:13: warning: 'msm_writel_intr_target' defined but not used [-Wunused-function]
   84 | static void msm_writel_##name(u32 val, struct msm_pinctrl *pctrl, \
      |             ^~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:94:1: note: in expansion of macro 'MSM_ACCESSOR'
   94 | MSM_ACCESSOR(intr_target)
      | ^~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:79:12: warning: 'msm_readl_intr_target' defined but not used [-Wunused-function]
   79 | static u32 msm_readl_##name(struct msm_pinctrl *pctrl, \
      |            ^~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:94:1: note: in expansion of macro 'MSM_ACCESSOR'
   94 | MSM_ACCESSOR(intr_target)
      | ^~~~~~~~~~~~

Caused by commit

  13bec8d49bdf ("pinctrl: qcom: use scm_call to route GPIO irq to Apps")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Marco Felsch]

Hi Stephen,

Thanks for the report and sorry for the build issue.

On 20-02-25 12:21, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "gpiochip_get_desc" [drivers/pinctrl/pinctrl-da9062.ko] undefined!
> 
> Caused by commit
> 
>   56cc3af4e8c8 ("pinctrl: da9062: add driver support")
> 
> I used the pinctrl tree from next-20200224 for today.

I'm the first user of this function within a driver and the functions
lacks of EXPORT_SYMBOL_GPL() currently.

@Linus
Shall I send a patch to address this or do you prepared a patch already?

Regards,
  Marco

> -- 
> Cheers,
> Stephen Rothwell

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi all,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "gpiochip_get_desc" [drivers/pinctrl/pinctrl-da9062.ko] undefined!

Caused by commit

  56cc3af4e8c8 ("pinctrl: da9062: add driver support")

I used the pinctrl tree from next-20200224 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Dec 6, 2016 at 10:31 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the pinctrl tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
>> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member named 'irq_parent'
>>   return irq_set_irq_wake(gc->irq_parent, state);
>>                             ^
>> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void function [-Wreturn-type]
>>  }
>>  ^
>>
>> Caused by commit
>>
>>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
>>
>> I have used the pinctrl tree from next-20161202 for today.
>
> I am still getting this.

Sorry. My intention was of course to put the required pl061 patches on
an immutable branch and pull into pinctrl as well.

Oh well.

FIxing it up now, sorry for the mess.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Peter Rosin]

On 2016-12-06 23:46, Stephen Rothwell wrote:
> Hi Peter,
> 
> On Tue, 6 Dec 2016 23:27:48 +0100 Peter Rosin <peda@axentia.se> wrote:
>>
>> The bug you are referring to is in the gpio tree, not pinctrl.
>> That had me confused for a while, and is the reason I'm writing
>> this. Maybe the next person need not be confused...
> 
> Part of the gpio tree has been merged into the pinctrl tree (see commit
> 70afa835d2d7 ("Merge branch 'thread-irq-simpler' of /home/linus/linux-gpio
> into devel")), but when I merge the gpio tree later in my process, I do
> not get this error.

Right. *blush*

The reason appears that the gpio tree has updates to the pl061 driver
that is not present in pinctrl, specifically
009df9a02000 ("gpio: pl061: use local state for parent IRQ storage")

I guess you could merge gpio first, but you'd still hit the silly bug
in pinctrl that Andrew fixed so maybe that's not worth it...

>> But when I'm writing on this topic anyway, I'll add some more
>> info, in case anyone cares.
>>
>> I think fix for this bug is to use gc->irq_chained_parent instead
>> of gc->irq_parent, at least that changed as part of the indicated
>> commit. Completely untested...
>>
>> The fix for the bug in the pinctrl tree is to add a missing >
>> as posted by Andrew Lunn in [1] (with a slightly broken commit
>> message; two counts of s/chip-/client-/, an extra line after
>> the sob and I guess the subject is no longer true).
>>
>> Cheers,
>> Peter
>>
>> [1] http://marc.info/?l=linux-gpio&m=148088890030876&w=2
> 
> Thanks for the info ... this still needs fixing in the pinctrl tree.
> 
> P.S. Peter, your email had a bad header line:
> 
> Reply-To: 20161207083102.093fdf96@canb.auug.org.au
> 
> that should probably have been In-Reply-To ...

Right. *blush*

Off to bed I guess. After all, it's a new day tomorrow and I don't seem
very effective at the moment...

Cheers,
Peter

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Peter,

On Tue, 6 Dec 2016 23:27:48 +0100 Peter Rosin <peda@axentia.se> wrote:
>
> The bug you are referring to is in the gpio tree, not pinctrl.
> That had me confused for a while, and is the reason I'm writing
> this. Maybe the next person need not be confused...

Part of the gpio tree has been merged into the pinctrl tree (see commit
70afa835d2d7 ("Merge branch 'thread-irq-simpler' of /home/linus/linux-gpio
into devel")), but when I merge the gpio tree later in my process, I do
not get this error.

> But when I'm writing on this topic anyway, I'll add some more
> info, in case anyone cares.
> 
> I think fix for this bug is to use gc->irq_chained_parent instead
> of gc->irq_parent, at least that changed as part of the indicated
> commit. Completely untested...
> 
> The fix for the bug in the pinctrl tree is to add a missing >
> as posted by Andrew Lunn in [1] (with a slightly broken commit
> message; two counts of s/chip-/client-/, an extra line after
> the sob and I guess the subject is no longer true).
> 
> Cheers,
> Peter
> 
> [1] http://marc.info/?l=linux-gpio&m=148088890030876&w=2

Thanks for the info ... this still needs fixing in the pinctrl tree.

P.S. Peter, your email had a bad header line:

Reply-To: 20161207083102.093fdf96@canb.auug.org.au

that should probably have been In-Reply-To ...
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Peter Rosin]

> Hi Linus,
> 
> On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the pinctrl tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>> 
>> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
>> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member named 'irq_parent'
>>   return irq_set_irq_wake(gc->irq_parent, state);
>>                             ^
>> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void function [-Wreturn-type]
>>  }
>>  ^
>> 
>> Caused by commit
>> 
>>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
>> 
>> I have used the pinctrl tree from next-20161202 for today.
> 
> I am still getting this.

The bug you are referring to is in the gpio tree, not pinctrl.
That had me confused for a while, and is the reason I'm writing
this. Maybe the next person need not be confused...

But when I'm writing on this topic anyway, I'll add some more
info, in case anyone cares.

I think fix for this bug is to use gc->irq_chained_parent instead
of gc->irq_parent, at least that changed as part of the indicated
commit. Completely untested...

The fix for the bug in the pinctrl tree is to add a missing >
as posted by Andrew Lunn in [1] (with a slightly broken commit
message; two counts of s/chip-/client-/, an extra line after
the sob and I guess the subject is no longer true).

Cheers,
Peter

[1] http://marc.info/?l=linux-gpio&m=148088890030876&w=2

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member named 'irq_parent'
>   return irq_set_irq_wake(gc->irq_parent, state);
>                             ^
> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void function [-Wreturn-type]
>  }
>  ^
> 
> Caused by commit
> 
>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
> 
> I have used the pinctrl tree from next-20161202 for today.

I am still getting this.

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member named 'irq_parent'
  return irq_set_irq_wake(gc->irq_parent, state);
                            ^
drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Caused by commit

  d245b3f9bd36 ("gpio: simplify adding threaded interrupts")

I have used the pinctrl tree from next-20161202 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

Laxman, this must be due to one of the two top commits for tegra:

commit 1d18a3f0f0809f6c71f1f6e9e268ee904ce0b588
"pinctrl: tegra: avoid parked_reg and parked_bank"
commit b22ef2a0979f2b91cfeeabb086e4d665183a93a1
"pinctrl: tegra: Correctly check the supported configuration"

Is it something you can fix quickly or should I just revert both patches
for the time being?

Yours,
Linus Walleij

On Thu, May 12, 2016 at 6:14 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> In file included from include/linux/thread_info.h:11:0,
>                  from include/asm-generic/preempt.h:4,
>                  from arch/arm/include/generated/asm/preempt.h:1,
>                  from include/linux/preempt.h:59,
>                  from include/linux/spinlock.h:50,
>                  from include/linux/seqlock.h:35,
>                  from include/linux/time.h:5,
>                  from include/linux/stat.h:18,
>                  from include/linux/module.h:10,
>                  from drivers/pinctrl/tegra/pinctrl-tegra20.c:20:
> include/linux/bug.h:34:45: error: unknown field 'parked_reg' specified in initializer
>  #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
>                                              ^
> include/linux/compiler-gcc.h:64:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
>  #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
>                             ^
> include/linux/kernel.h:54:59: note: in expansion of macro '__must_be_array'
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
>                                                            ^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2027:12: note: in expansion of macro 'ARRAY_SIZE'
>    .npins = ARRAY_SIZE(drive_##pg_name##_pins), \
>             ^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2050:2: note: in expansion of macro 'DRV_PG_EXT'
>   DRV_PG_EXT(pg_name, r, 2,  3,  4, 12, 20, 28, 2, 30, 2)
>   ^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2178:2: note: in expansion of macro 'DRV_PG'
>   DRV_PG(ao1,        0x868),
>   ^
>
> and many more.
>
> I cannot figure out what caused it, but using the pinctrl tree from
> next-20160511 makes it build again.
>
> I am using gcc 5.2.0 hosted on powerpcle, if that matters.
>
> --
> Cheers,
> Stephen Rothwell

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/linux/thread_info.h:11:0,
                 from include/asm-generic/preempt.h:4,
                 from arch/arm/include/generated/asm/preempt.h:1,
                 from include/linux/preempt.h:59,
                 from include/linux/spinlock.h:50,
                 from include/linux/seqlock.h:35,
                 from include/linux/time.h:5,
                 from include/linux/stat.h:18,
                 from include/linux/module.h:10,
                 from drivers/pinctrl/tegra/pinctrl-tegra20.c:20:
include/linux/bug.h:34:45: error: unknown field 'parked_reg' specified in initializer
 #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
                                             ^
include/linux/compiler-gcc.h:64:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
 #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
                            ^
include/linux/kernel.h:54:59: note: in expansion of macro '__must_be_array'
 #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                                           ^
drivers/pinctrl/tegra/pinctrl-tegra20.c:2027:12: note: in expansion of macro 'ARRAY_SIZE'
   .npins = ARRAY_SIZE(drive_##pg_name##_pins), \
            ^
drivers/pinctrl/tegra/pinctrl-tegra20.c:2050:2: note: in expansion of macro 'DRV_PG_EXT'
  DRV_PG_EXT(pg_name, r, 2,  3,  4, 12, 20, 28, 2, 30, 2)
  ^
drivers/pinctrl/tegra/pinctrl-tegra20.c:2178:2: note: in expansion of macro 'DRV_PG'
  DRV_PG(ao1,        0x868),
  ^

and many more.

I cannot figure out what caused it, but using the pinctrl tree from
next-20160511 makes it build again.

I am using gcc 5.2.0 hosted on powerpcle, if that matters.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Mon, Dec 21, 2015 at 5:58 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:

Argh damned, I pushed a oneliner fix in accordance with Pramod's
report. Sorry about the mess.

Yours,
Linus Walleij

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]

Hi Stephen Rothwell,

This is the same error what we discussed on Friday mail-chain. Please see the attachment of my reply.

Regards,
Pramod

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: 21 December 2015 10:28
> To: Linus Walleij
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: 'struct cygnus_gpio'
> declared inside parameter list  static void iproc_gpio_unregister_pinconf(struct
> cygnus_gpio *chip)
>                                                   ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: its scope is only this
> definition or declaration, which is probably not what you want
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>                          ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
>                                 ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>              ^
> 
> Caused by commit
> 
>  afc8c78d179d ("gpio: Rename func/macro/var to IP-block,iproc")
> 
> This does not look like it has even been build tested :-(
> 
> I have used the pinctrl tree from next-20151217 again as the previous
> (fixed) error was hiding this one.
> 
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au


[-- Attachment #2: Type: message/rfc822, Size: 3093 bytes --]

From: Pramod Kumar <pramodku@broadcom.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>
Subject: RE: linux-next: build failure after merge of the pinctrl tree
Date: Fri, 18 Dec 2015 05:34:56 +0000

Hi Stephen/Linus,

The patch " [PATCH v2 5/7] gpio: Rename func/macro/var to IP-block,iproc" 
(https://lkml.org/lkml/2015/11/18/1004) in "for-next" and "devel" of  pinctrl
tree ( http://git.linaro.org/people/linus.walleij/linux-pinctrl.git ) has little rebase issue.

Original patch has:
<snip>
-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)
<snip>

while "for-next" and "devel" branch of pinctrl tree has:
<snip>
-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip) 
<snip>

Please suggest us how could we fix this issue.

Regards,
Pramod

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: 18 December 2015 09:15
> To: Linus Walleij
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>                          ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
>                                 ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>              ^
> 
> Caused by commit
> 
>   616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc")
> 
> I have used the pinctrl tree from next-20151217 for today.
> 
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: 'struct cygnus_gpio' declared inside parameter list
 static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
                                                  ^
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_unregister_pinconf':
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer to incomplete type 'struct cygnus_gpio'
  pinctrl_unregister(chip->pctl);   
                         ^
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 of 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-Wincompatible-pointer-types]   
  iproc_gpio_unregister_pinconf(chip);
                                ^   
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
 static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
             ^

Caused by commit

 afc8c78d179d ("gpio: Rename func/macro/var to IP-block,iproc")

This does not look like it has even been build tested :-(

I have used the pinctrl tree from next-20151217 again as the previous
(fixed) error was hiding this one.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the pinctrl tree

[Ray Jui]

Hi All,

Yes I also checked the original patch that Pramod sent out:

@@ -636,13 +638,13 @@ static int cygnus_gpio_register_pinconf(struct 
cygnus_gpio *chip)
  	return 0;
  }

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)
  {
  	if (chip->pctl)
  		pinctrl_unregister(chip->pctl);
  }

Somehow it was not merged properly into Linus' tree? The fix is simple 
and just like Pramod proposed.

Linus, how do you want to proceed with this?

Thanks,

Ray


On 12/17/2015 10:12 PM, Pramod Kumar wrote:
> Hi Stephen,
>
> The issue I pointed out is the relevant and is fully related to the statement-
>
> " After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:"
>
> Even I tried the build for config "arm multi_v7_defconfig" it was compile failed. After fixing this I see compilation successful. I don't think we see any more issue after this fix.
>
> Please let me know in case I should try any more compilation.
>
> Regards,
> Pramod
>
>> -----Original Message-----
>> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
>> Sent: 18 December 2015 11:28
>> To: Pramod Kumar
>> Cc: Linus Walleij; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Ray
>> Jui; Scott Branden
>> Subject: Re: linux-next: build failure after merge of the pinctrl tree
>>
>> Hi Pramod,
>>
>> On Fri, 18 Dec 2015 05:34:58 +0000 Pramod Kumar
>> <pramodku@broadcom.com> wrote:
>>>
>>> Hi Stephen/Linus,
>>>
>>> Please suggest us how could we fix this issue.
>>
>> I think you issue is different from what I reported, What I reported was caused
>> by the addition of the dependency on COMPILE_TEST which allowed the driver
>> to be built on architectures/platforms that do not have the needed definitions.
>>
>> --
>> Cheers,
>> Stephen Rothwell                    sfr@canb.auug.org.au
>

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

Hi Stephen,

The issue I pointed out is the relevant and is fully related to the statement-

" After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:"

Even I tried the build for config "arm multi_v7_defconfig" it was compile failed. After fixing this I see compilation successful. I don't think we see any more issue after this fix.

Please let me know in case I should try any more compilation.

Regards,
Pramod

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: 18 December 2015 11:28
> To: Pramod Kumar
> Cc: Linus Walleij; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Ray
> Jui; Scott Branden
> Subject: Re: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Pramod,
> 
> On Fri, 18 Dec 2015 05:34:58 +0000 Pramod Kumar
> <pramodku@broadcom.com> wrote:
> >
> > Hi Stephen/Linus,
> >
> > Please suggest us how could we fix this issue.
> 
> I think you issue is different from what I reported, What I reported was caused
> by the addition of the dependency on COMPILE_TEST which allowed the driver
> to be built on architectures/platforms that do not have the needed definitions.
> 
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Pramod,

On Fri, 18 Dec 2015 05:34:58 +0000 Pramod Kumar <pramodku@broadcom.com> wrote:
>
> Hi Stephen/Linus,
> 
> Please suggest us how could we fix this issue.

I think you issue is different from what I reported, What I reported
was caused by the addition of the dependency on COMPILE_TEST which
allowed the driver to be built on architectures/platforms that do not
have the needed definitions.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

Hi Stephen/Linus,

The patch " [PATCH v2 5/7] gpio: Rename func/macro/var to IP-block,iproc" 
(https://lkml.org/lkml/2015/11/18/1004) in "for-next" and "devel" of  pinctrl
tree ( http://git.linaro.org/people/linus.walleij/linux-pinctrl.git ) has little rebase issue.

Original patch has:
<snip>
-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)
<snip>

while "for-next" and "devel" branch of pinctrl tree has:
<snip>
-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip) 
<snip>

Please suggest us how could we fix this issue.

Regards,
Pramod

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: 18 December 2015 09:15
> To: Linus Walleij
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>                          ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
>                                 ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>              ^
> 
> Caused by commit
> 
>   616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc")
> 
> I have used the pinctrl tree from next-20151217 for today.
> 
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_unregister_pinconf':
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer to incomplete type 'struct cygnus_gpio'
  pinctrl_unregister(chip->pctl);   
                         ^
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 of 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-Wincompatible-pointer-types]   
  iproc_gpio_unregister_pinconf(chip);
                                ^   
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
 static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
             ^

Caused by commit

  616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc")

I have used the pinctrl tree from next-20151217 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Oct 2, 2015 at 5:37 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

>> Caused by commit
>>
>>   776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
>>
>> I have used the pinctrl tree from next-20150924 for today.
>
> I am still getting this error.

Sorry for slow fixing, I was travelling.

It should be fixed today.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Fri, 25 Sep 2015 13:34:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_gpio_irq_set_type':
> drivers/pinctrl/pinctrl-at91-pio4.c:170:3: error: implicit declaration of function '__irq_set_handler_locked' [-Werror=implicit-function-declaration]
>    __irq_set_handler_locked(d->irq, handle_edge_irq);
>    ^
> drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
> drivers/pinctrl/pinctrl-at91-pio4.c:925:3: warning: passing argument 2 of 'irq_set_chained_handler' from incompatible pointer type
>    irq_set_chained_handler(res->start, atmel_gpio_irq_handler);
>    ^
> In file included from include/linux/gpio/driver.h:6:0,
>                  from include/asm-generic/gpio.h:12,
>                  from arch/arm/include/asm/gpio.h:9,
>                  from include/linux/gpio.h:48,
>                  from drivers/pinctrl/pinctrl-at91-pio4.c:18:
> include/linux/irq.h:548:1: note: expected 'irq_flow_handler_t' but argument is of type 'void (*)(unsigned int,  struct irq_desc *)'
>  irq_set_chained_handler(unsigned int irq, irq_flow_handler_t handle)
>  ^
> 
> Caused by commit
> 
>   776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
> 
> I have used the pinctrl tree from next-20150924 for today.

I am still getting this error.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_gpio_irq_set_type':
drivers/pinctrl/pinctrl-at91-pio4.c:170:3: error: implicit declaration of function '__irq_set_handler_locked' [-Werror=implicit-function-declaration]
   __irq_set_handler_locked(d->irq, handle_edge_irq);
   ^
drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
drivers/pinctrl/pinctrl-at91-pio4.c:925:3: warning: passing argument 2 of 'irq_set_chained_handler' from incompatible pointer type
   irq_set_chained_handler(res->start, atmel_gpio_irq_handler);
   ^
In file included from include/linux/gpio/driver.h:6:0,
                 from include/asm-generic/gpio.h:12,
                 from arch/arm/include/asm/gpio.h:9,
                 from include/linux/gpio.h:48,
                 from drivers/pinctrl/pinctrl-at91-pio4.c:18:
include/linux/irq.h:548:1: note: expected 'irq_flow_handler_t' but argument is of type 'void (*)(unsigned int,  struct irq_desc *)'
 irq_set_chained_handler(unsigned int irq, irq_flow_handler_t handle)
 ^

Caused by commit

  776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")

I have used the pinctrl tree from next-20150924 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Mon, Jan 12, 2015 at 6:02 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Fixed already, hopefully. (Atleast the autobuilders are happy.)

Yours,
Linus Walleij

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2384 bytes --]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/pinctrl/pinconf-generic.c: In function 'pinconf_generic_dump_pins':
drivers/pinctrl/pinconf-generic.c:116:19: error: 'struct pinctrl_desc' has no member named 'num_dt_params'
  if (pctldev->desc->num_dt_params && pctldev->desc->conf_items)
                   ^
drivers/pinctrl/pinconf-generic.c:116:51: error: 'struct pinctrl_desc' has no member named 'conf_items'
  if (pctldev->desc->num_dt_params && pctldev->desc->conf_items)
                                                   ^
drivers/pinctrl/pinconf-generic.c:118:20: error: 'struct pinctrl_desc' has no member named 'conf_items'
       pctldev->desc->conf_items,
                    ^
drivers/pinctrl/pinconf-generic.c:119:20: error: 'struct pinctrl_desc' has no member named 'num_dt_params'
       pctldev->desc->num_dt_params);
                    ^
drivers/pinctrl/pinconf-generic.c: In function 'pinconf_generic_dump_config':
drivers/pinctrl/pinconf-generic.c:134:20: error: 'struct pinctrl_desc' has no member named 'num_dt_params'
  if (!pctldev->desc->num_dt_params || !pctldev->desc->conf_items)
                    ^
drivers/pinctrl/pinconf-generic.c:134:53: error: 'struct pinctrl_desc' has no member named 'conf_items'
  if (!pctldev->desc->num_dt_params || !pctldev->desc->conf_items)
                                                     ^
drivers/pinctrl/pinconf-generic.c:137:31: error: 'struct pinctrl_desc' has no member named 'num_dt_params'
  for (i = 0; i < pctldev->desc->num_dt_params; i++) {
                               ^
drivers/pinctrl/pinconf-generic.c:138:55: error: 'struct pinctrl_desc' has no member named 'conf_items'
   if (pinconf_to_config_param(config) != pctldev->desc->conf_items[i].param)
                                                       ^
drivers/pinctrl/pinconf-generic.c:140:42: error: 'struct pinctrl_desc' has no member named 'conf_items'
   seq_printf(s, "%s: 0x%x", pctldev->desc->conf_items[i].display,
                                          ^

Caused by commit dd4d01f7bad8 ("pinctrl: pinconf-generic: Allow driver
to specify DT params").  This build does not have CONFIG_OF set.

I have used the pinctrl tree from next-20150109 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm multi_v7_defconfig)
failed like this:

drivers/pinctrl/samsung/pinctrl-exynos.c:1194:43: error: array type has incomplete element type
 static const struct samsung_pin_bank_data exynos7_pin_banks0[] __initconst = {
                                           ^
drivers/pinctrl/samsung/pinctrl-exynos.c:1195:2: error: field name not in record or union initializer
  EXYNOS_PIN_BANK_EINTW(8, 0x000, "gpa0", 0x00),
  ^
drivers/pinctrl/samsung/pinctrl-exynos.c:1195:2: error: (near initialization for 'exynos7_pin_banks0')
drivers/pinctrl/samsung/pinctrl-exynos.c:1195:2: error: field name not in record or union initializer

And so on ...

Caused by commit 9d3de28d785f ("pinctrl: exynos: Add initial driver
data for Exynos7").

I have used the pinctrl tree from next-20141023 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, May 30, 2014 at 8:08 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> After merging the pinctrl tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:
>
> drivers/pinctrl/sirf/pinctrl-sirf.c: In function 'sirfsoc_gpio_handle_irq':
> drivers/pinctrl/sirf/pinctrl-sirf.c:578:11: error: 'sgpio_chip' undeclared (first use in this function)
>
> Caused by commit 294d1351ff47 ("pinctrl: sirf: switch to using
> allocated state container").

Grr a bad cherry-pick from my side. I've fixed it up today.
Thanks a lot for this Stephen.

Yours,
Linus Walleij

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm multi_v7_defconfig)
failed like this:

drivers/pinctrl/sirf/pinctrl-sirf.c: In function 'sirfsoc_gpio_handle_irq':
drivers/pinctrl/sirf/pinctrl-sirf.c:578:11: error: 'sgpio_chip' undeclared (first use in this function)


Caused by commit 294d1351ff47 ("pinctrl: sirf: switch to using
allocated state container").

I have used the pinctrl tree from next-20140529 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Feb 11, 2014 at 4:56 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> drivers/pinctrl/pinctrl-st.c:407:18: error: 'stid127_delays' undeclared here (not in a function)
>
> Caused by commit cab6bf05bab5 ("pinctrl: st: add stid127 support").

Oh darn, I was waiting for an update of that patch but forgot.

I'll rip out that patch immediately, sorry!

Yours,
Linus Walleij

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/pinctrl-st.c:407:18: error: 'stid127_delays' undeclared here (not in a function)

Caused by commit cab6bf05bab5 ("pinctrl: st: add stid127 support").

I have used the pinctrl tree from next-20140210 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Dec 10, 2013 at 4:02 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/fsl/eukrea-tlv320.c:28:28: fatal error: asm/mach-types.h: No such file or directory
>  #include <asm/mach-types.h>
>                             ^

It is trying to include an ARM-only file in an x86_64 compile...
I think the Kconfig for that driver needs a

depends on ARM

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

Hi Linus,

On Tue, 10 Dec 2013 14:02:18 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/fsl/eukrea-tlv320.c:28:28: fatal error: asm/mach-types.h: No such file or directory
>  #include <asm/mach-types.h>
>                             ^
> 
> Probably caused by commit 6bca8471566c ("pinctrl: select dependency on OF
> for MSM driver").  the build of eukrea-tlv320.c depends on CONFIG_OF
> which is not normally set for as x86_64 build, but the above commit
> caused it to be selected (I think).
> 
> I have used the pinctrl tree from next-20131206 again.

It turns out that this is build failure is actually caused by a commit in
the sound-asoc tree (436aa86f0414 "ASoC: eukrea-tlv320: Add DT support"),
but was exposed by the pinctrl tree commit.

So I am not sure if the pinctrl tree needs fixing (I think it did select
CONFIG_OF where it would normally not be).
-- 
Cheers,
Stephen Rothwell <sfr@canb.auug.org.au>

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/fsl/eukrea-tlv320.c:28:28: fatal error: asm/mach-types.h: No such file or directory
 #include <asm/mach-types.h>
                            ^

Probably caused by commit 6bca8471566c ("pinctrl: select dependency on OF
for MSM driver").  the build of eukrea-tlv320.c depends on CONFIG_OF
which is not normally set for as x86_64 build, but the above commit
caused it to be selected (I think).

I have used the pinctrl tree from next-20131206 again.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/pinctrl/pinctrl-msm.c:103:21: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
  .dt_node_to_map  = pinconf_generic_dt_node_to_map_group,
                     ^
drivers/pinctrl/pinctrl-msm.c: In function 'msm_gpio_init':
drivers/pinctrl/pinctrl-msm.c:905:6: error: 'struct gpio_chip' has no member named 'of_node'
  chip->of_node = pctrl->dev->of_node;
      ^

Probably caused by commit f365be092572 ("pinctrl: Add Qualcomm TLMM
driver").

I have used the pinctrl tree from next-20131206 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/pinctrl/pinctrl-adi2.c:25:25: fatal error: asm/portmux.h: No such file or directory
 #include <asm/portmux.h>
                         ^

Caused by commit e9a03add0c6e ("pinctrl: ADI PIN control driver for the
GPIO controller on bf54x and bf60x"). asm/portmux.h only exists on
blackfin ...

I have used the version of the pinctrl tree from next-20130919 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Warren]

On 04/10/2012 01:42 AM, Linus Walleij wrote:
> On Wed, Apr 4, 2012 at 5:43 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 04/03/2012 08:44 PM, Stephen Rothwell wrote:
>>> Hi Linus,
>>>
>>> After merging the pinctrl tree, today's linux-next build (powerpc
>>> ppc64_defconfig) failed like this:
>>>
>>> drivers/pinctrl/devicetree.c: In function 'dt_free_map':
>>> drivers/pinctrl/devicetree.c:44:42: error: dereferencing pointer to
>>> incomplete type drivers/pinctrl/devicetree.c:45:6: error:
>>> dereferencing pointer to incomplete type
>>> drivers/pinctrl/devicetree.c: In function 'dt_to_map_one_config':
>>> drivers/pinctrl/devicetree.c:140:21: error: dereferencing pointer
>>> to incomplete type drivers/pinctrl/devicetree.c:141:10: error:
>>> dereferencing pointer to incomplete type
>>> drivers/pinctrl/devicetree.c:146:11: error: dereferencing pointer
>>> to incomplete type
>>
>> This doesn't repro for me with tegra_defconfig, which has both
>> CONFIG_PINCTRL and CONFIG_OF enabled.
>>
>> I believe this happens because of the following in
>> drivers/pinctrl/Makefile:
>>
>> obj-$(CONFIG_OF)                += devicetree.o
>>
>> On ppc64, CONFIG_OF is probably true, yet the rest of PINCTRL isn't
>> enabled, hence the headers that are included probably don't declare
>> all the types needed to compile that file.
>>
>> In fact, the file shouldn't be compiled, since it's not needed if
>> !CONFIG_PINCTRL. So perhaps the Makefile should be more like:
>>
>> ifeq ($(CONFIG_OF),y)
>> obj-$(CONFIG_PINCTRL)           += devicetree.o
>> endif
> 
> Easiest fixed with a new Kconfig like CONFIG_PINCTRL_OF that
> depend on both right?
> 
> I'll cook a patch.

I don't think so; why wouldn't pinctrl automatically have DT support
when both pinctrl and OF are enabled. BTW, I already posted a patch to
fix this last week.

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Wed, Apr 4, 2012 at 5:43 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 04/03/2012 08:44 PM, Stephen Rothwell wrote:
>> Hi Linus,
>>
>> After merging the pinctrl tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> drivers/pinctrl/devicetree.c: In function 'dt_free_map':
>> drivers/pinctrl/devicetree.c:44:42: error: dereferencing pointer to
>> incomplete type drivers/pinctrl/devicetree.c:45:6: error:
>> dereferencing pointer to incomplete type
>> drivers/pinctrl/devicetree.c: In function 'dt_to_map_one_config':
>> drivers/pinctrl/devicetree.c:140:21: error: dereferencing pointer
>> to incomplete type drivers/pinctrl/devicetree.c:141:10: error:
>> dereferencing pointer to incomplete type
>> drivers/pinctrl/devicetree.c:146:11: error: dereferencing pointer
>> to incomplete type
>
> This doesn't repro for me with tegra_defconfig, which has both
> CONFIG_PINCTRL and CONFIG_OF enabled.
>
> I believe this happens because of the following in
> drivers/pinctrl/Makefile:
>
> obj-$(CONFIG_OF)                += devicetree.o
>
> On ppc64, CONFIG_OF is probably true, yet the rest of PINCTRL isn't
> enabled, hence the headers that are included probably don't declare
> all the types needed to compile that file.
>
> In fact, the file shouldn't be compiled, since it's not needed if
> !CONFIG_PINCTRL. So perhaps the Makefile should be more like:
>
> ifeq ($(CONFIG_OF),y)
> obj-$(CONFIG_PINCTRL)           += devicetree.o
> endif

Easiest fixed with a new Kconfig like CONFIG_PINCTRL_OF that
depend on both right?

I'll cook a patch.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Warren]

On 04/03/2012 08:44 PM, Stephen Rothwell wrote:
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (powerpc 
> ppc64_defconfig) failed like this:
> 
> drivers/pinctrl/devicetree.c: In function 'dt_free_map': 
> drivers/pinctrl/devicetree.c:44:42: error: dereferencing pointer to
> incomplete type drivers/pinctrl/devicetree.c:45:6: error:
> dereferencing pointer to incomplete type 
> drivers/pinctrl/devicetree.c: In function 'dt_to_map_one_config': 
> drivers/pinctrl/devicetree.c:140:21: error: dereferencing pointer
> to incomplete type drivers/pinctrl/devicetree.c:141:10: error:
> dereferencing pointer to incomplete type 
> drivers/pinctrl/devicetree.c:146:11: error: dereferencing pointer
> to incomplete type

This doesn't repro for me with tegra_defconfig, which has both
CONFIG_PINCTRL and CONFIG_OF enabled.

I believe this happens because of the following in
drivers/pinctrl/Makefile:

obj-$(CONFIG_OF)		+= devicetree.o

On ppc64, CONFIG_OF is probably true, yet the rest of PINCTRL isn't
enabled, hence the headers that are included probably don't declare
all the types needed to compile that file.

In fact, the file shouldn't be compiled, since it's not needed if
!CONFIG_PINCTRL. So perhaps the Makefile should be more like:

ifeq ($(CONFIG_OF),y)
obj-$(CONFIG_PINCTRL)		+= devicetree.o
endif

(I see something similar to that in drivers/mmc/host/Makefile)

But, I notice the same construct in ./drivers/regulator/Makefile, and
I don't believe regulators are enabled for ppc64. Perhaps the
regulator headers always declare the types, so the issue doesn't come
up, although I daresay that perhaps the regulator file also shouldn't
be compiled when CONFIG_REGULATOR is off?

linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Hi Linus,

After merging the pinctrl tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/pinctrl/devicetree.c: In function 'dt_free_map':
drivers/pinctrl/devicetree.c:44:42: error: dereferencing pointer to incomplete type
drivers/pinctrl/devicetree.c:45:6: error: dereferencing pointer to incomplete type
drivers/pinctrl/devicetree.c: In function 'dt_to_map_one_config':
drivers/pinctrl/devicetree.c:140:21: error: dereferencing pointer to incomplete type
drivers/pinctrl/devicetree.c:141:10: error: dereferencing pointer to incomplete type
drivers/pinctrl/devicetree.c:146:11: error: dereferencing pointer to incomplete type

Caused by commit 23289e6ecc6d ("pinctrl: core device tree mapping table
parsing support").  Missing includes?

I have used the version of the pinctrl tree from next-20120403 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]