linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Rabin Vincent <rabin.vincent@stericsson.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled
Date: Tue, 13 Nov 2012 14:35:26 +0100	[thread overview]
Message-ID: <CACRpkdZj5iuyXAfynF-5r65dnakxxm2A1O602P4Lc6it8=fU9g@mail.gmail.com> (raw)
In-Reply-To: <50A12FF1.4000800@infradead.org>

On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when CONFIG_OF is not enabled by including
> <linux/of.h> (needs to be added in any case).
> An alternative fix could be to make the driver depend on OF.
>
> drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
> drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
> drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rabin Vincent <rabin.vincent@stericsson.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

  reply	other threads:[~2012-11-13 13:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12  5:44 linux-next: Tree for Nov 12 Stephen Rothwell
2012-11-12 17:20 ` [PATCH -next] mfd: fix stmpe.c build when OF is not enabled Randy Dunlap
2012-11-13 13:35   ` Linus Walleij [this message]
2012-11-26 19:21     ` Randy Dunlap
2012-11-26 21:07       ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZj5iuyXAfynF-5r65dnakxxm2A1O602P4Lc6it8=fU9g@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rabin.vincent@stericsson.com \
    --cc=rdunlap@infradead.org \
    --cc=sameo@linux.intel.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).