linux-next: build failure after merge of the final tree (tty tree related)

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/tty/ehv_bytechan.c: In function 'udbg_init_ehv_bc':
drivers/tty/ehv_bytechan.c:230:18: error: 'MSR_GS' undeclared (first use in this function)
drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_write':
drivers/tty/ehv_bytechan.c:289:24: warning: cast from pointer to integer of different size
drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_init':
drivers/tty/ehv_bytechan.c:355:24: warning: cast to pointer from integer of different size

Caused by commit dcd83aaff1c8 ("tty/powerpc: introduce the ePAPR embedded
hypervisor byte channel driver").

MSR_GS is defined in arch/powerpc/include/asm/reg_booke.h which is
included by arch/powerpc/include/asm/reg.h but only when defined
(CONFIG_BOOKE) || defined(CONFIG_40x).

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Greg KH]

On Thu, Aug 25, 2011 at 04:18:43PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/tty/ehv_bytechan.c: In function 'udbg_init_ehv_bc':
> drivers/tty/ehv_bytechan.c:230:18: error: 'MSR_GS' undeclared (first use in this function)
> drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_write':
> drivers/tty/ehv_bytechan.c:289:24: warning: cast from pointer to integer of different size
> drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_init':
> drivers/tty/ehv_bytechan.c:355:24: warning: cast to pointer from integer of different size
> 
> Caused by commit dcd83aaff1c8 ("tty/powerpc: introduce the ePAPR embedded
> hypervisor byte channel driver").
> 
> MSR_GS is defined in arch/powerpc/include/asm/reg_booke.h which is
> included by arch/powerpc/include/asm/reg.h but only when defined
> (CONFIG_BOOKE) || defined(CONFIG_40x).

Thanks for the report.

Timur, care to send a fixup patch for this so this gets resolved?

greg k-h

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Timur Tabi]

On Aug 25, 2011, at 9:08 AM, Greg KH <greg@kroah.com> wrote:

> On Thu, Aug 25, 2011 at 04:18:43PM +1000, Stephen Rothwell wrote:
>> 
> 
> Thanks for the report.
> 
> Timur, care to send a fixup patch for this so this gets resolved?

Yes, I will do it ASAP, probably within the next two hours.
> 

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Timur Tabi]

Greg KH wrote:
>> > MSR_GS is defined in arch/powerpc/include/asm/reg_booke.h which is
>> > included by arch/powerpc/include/asm/reg.h but only when defined
>> > (CONFIG_BOOKE) || defined(CONFIG_40x).
> Thanks for the report.
> 
> Timur, care to send a fixup patch for this so this gets resolved?

Is there some trick to building allyesconfig on PowerPC?  When I do try that, I
get all sorts of weird build errors, and it dies long before it gets to my
driver.  I get stuff like:

  LD      arch/powerpc/sysdev/xics/built-in.o
WARNING: arch/powerpc/sysdev/xics/built-in.o(.text+0x1310): Section mismatch in
reference from the function .icp_native_init() to the function
.init.text:.icp_native_init_one_node()
The function .icp_native_init() references
the function __init .icp_native_init_one_node().
This is often because .icp_native_init lacks a __init
annotation or the annotation of .icp_native_init_one_node is wrong.

and

  AS      arch/powerpc/kernel/head_64.o
arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
arch/powerpc/kernel/exceptions-64s.S:1151: Error: attempt to move .org backwards
arch/powerpc/kernel/exceptions-64s.S:1160: Error: attempt to move .org backwards
make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1

I guess I don't have the right compiler.

Anyway, I think I know how to fix the break that Stephen is seeing.  I will post
a v4 patch in a few minutes.


-- 
Timur Tabi
Linux kernel developer at Freescale

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

Hi Timur,

On Thu, 25 Aug 2011 10:22:05 -0500 Timur Tabi <timur@freescale.com> wrote:
>
> Is there some trick to building allyesconfig on PowerPC?  When I do try that, I
> get all sorts of weird build errors, and it dies long before it gets to my
> driver.  I get stuff like:
> 
>   LD      arch/powerpc/sysdev/xics/built-in.o
> WARNING: arch/powerpc/sysdev/xics/built-in.o(.text+0x1310): Section mismatch in
> reference from the function .icp_native_init() to the function
> .init.text:.icp_native_init_one_node()
> The function .icp_native_init() references
> the function __init .icp_native_init_one_node().
> This is often because .icp_native_init lacks a __init
> annotation or the annotation of .icp_native_init_one_node is wrong.

We get lots of those in many builds. :-(  Just a warning.

> and
> 
>   AS      arch/powerpc/kernel/head_64.o
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1151: Error: attempt to move .org backwards
> arch/powerpc/kernel/exceptions-64s.S:1160: Error: attempt to move .org backwards

There is a patch for that pending with either the kvm guys or the powerpc guys.

> I guess I don't have the right compiler.

Yours seems to be OK.  If you pass -k to make it will get further.  Or
you could configure it and then just try building your driver rather than
the whole tree.

> Anyway, I think I know how to fix the break that Stephen is seeing.  I will post
> a v4 patch in a few minutes.

Thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Arnaud Lacombe]

Hi,

On Thu, Aug 25, 2011 at 11:51 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Timur,
>
> On Thu, 25 Aug 2011 10:22:05 -0500 Timur Tabi <timur@freescale.com> wrote:
>>
>> Is there some trick to building allyesconfig on PowerPC?  When I do try that, I
>> get all sorts of weird build errors, and it dies long before it gets to my
>> driver.  I get stuff like:
>>
>>   LD      arch/powerpc/sysdev/xics/built-in.o
>> WARNING: arch/powerpc/sysdev/xics/built-in.o(.text+0x1310): Section mismatch in
>> reference from the function .icp_native_init() to the function
>> .init.text:.icp_native_init_one_node()
>> The function .icp_native_init() references
>> the function __init .icp_native_init_one_node().
>> This is often because .icp_native_init lacks a __init
>> annotation or the annotation of .icp_native_init_one_node is wrong.
>
> We get lots of those in many builds. :-(  Just a warning.
>
If you could provide an exhaustive list of them, I'd be interested. Do
you account/reference them in the report you make on each new -next
tree ?

 - Arnaud

>> and
>>
>>   AS      arch/powerpc/kernel/head_64.o
>> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
>> arch/powerpc/kernel/exceptions-64s.S:1151: Error: attempt to move .org backwards
>> arch/powerpc/kernel/exceptions-64s.S:1160: Error: attempt to move .org backwards
>
> There is a patch for that pending with either the kvm guys or the powerpc guys.
>
>> I guess I don't have the right compiler.
>
> Yours seems to be OK.  If you pass -k to make it will get further.  Or
> you could configure it and then just try building your driver rather than
> the whole tree.
>
>> Anyway, I think I know how to fix the break that Stephen is seeing.  I will post
>> a v4 patch in a few minutes.
>
> Thanks.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi Arnaud,

On Thu, 25 Aug 2011 12:09:20 -0400 Arnaud Lacombe <lacombar@gmail.com> wrote:
>
> If you could provide an exhaustive list of them, I'd be interested. Do
> you account/reference them in the report you make on each new -next
> tree ?

I don't refer to them at all :-(

If you are not just referring to powerpc ones, then an x86_64
allmodconfig is a good place to start, there are several in there.

Otherwise, I will send you the results of some of my builds this evening.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Arnaud Lacombe]

Hi,

[Removed PPC folks from the CC list, the conversation drifted.]

On Thu, Aug 25, 2011 at 8:39 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Arnaud,
>
> On Thu, 25 Aug 2011 12:09:20 -0400 Arnaud Lacombe <lacombar@gmail.com> wrote:
>>
>> If you could provide an exhaustive list of them, I'd be interested. Do
>> you account/reference them in the report you make on each new -next
>> tree ?
>
> I don't refer to them at all :-(
>
> If you are not just referring to powerpc ones, then an x86_64
> allmodconfig is a good place to start, there are several in there.
>
> Otherwise, I will send you the results of some of my builds this evening.
>
Couldn't all the error log be public, rotated over a 7 iteration
period ? That would be fair to everyone.

Thanks,
 - Arnaud

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

Hi Arnaud,

On Fri, 26 Aug 2011 11:47:40 -0400 Arnaud Lacombe <lacombar@gmail.com> wrote:
>
> Couldn't all the error log be public, rotated over a 7 iteration
> period ? That would be fair to everyone.

See http://kisskb.ellerman.id.au/linux-next (as stated in all my release
emails).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Geert Uytterhoeven]

Hi Arnaud,

On Sun, Sep 11, 2011 at 06:23, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Fri, 26 Aug 2011 11:47:40 -0400 Arnaud Lacombe <lacombar@gmail.com> wrote:
>> Couldn't all the error log be public, rotated over a 7 iteration
>> period ? That would be fair to everyone.
>
> See http://kisskb.ellerman.id.au/linux-next (as stated in all my release
> emails).

And if you want to analyze the results, you can use the scripts I use
to create the
regression/improvement reports for tagged Linux releases.
While it would be nice to have the same for linux-next releases, I
unfortunately don't
have the time for that, as there's still some manual work involved.

http://www.spinics.net/lists/linux-next/msg11040.html

You can get the scripts referenced in my email above from any kernel.org mirror,
e.g. ftp://ftp.belnet.be/mirrors/ftp.kernel.org/pub/linux/kernel/people/geert/linux-log/.
They may not be the latest version, though, have to check/fix when
master.kernel.org
is back.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb':
drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
  case PRE_RATE_CHANGE:
       ^
drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in
drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type
   if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud,
                                    ^
drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function)
  case POST_RATE_CHANGE:
       ^
drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to incomplete type
   port->uartclk = ndata->new_rate;
                        ^
drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function)
  case ABORT_RATE_CHANGE:
       ^
drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe':
drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration]
  if (clk_notifier_register(xuartps_data->refclk,
  ^
drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration]
  clk_notifier_unregister(xuartps_data->refclk,
  ^

Caused by commits in the tty tree.

I have left this broken for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 2246 bytes --]

On 10/28/2013 03:33 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb':
> drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
>   case PRE_RATE_CHANGE:
>        ^
> drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in
> drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type
>    if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud,
>                                     ^
> drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function)
>   case POST_RATE_CHANGE:
>        ^
> drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to incomplete type
>    port->uartclk = ndata->new_rate;
>                         ^
> drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function)
>   case ABORT_RATE_CHANGE:
>        ^
> drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe':
> drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration]
>   if (clk_notifier_register(xuartps_data->refclk,
>   ^
> drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration]
>   clk_notifier_unregister(xuartps_data->refclk,
>   ^
> 
> Caused by commits in the tty tree.
> 
> I have left this broken for today.
> 

Soren: Please correct me if I am wrong.
But this should be fixed by:
"[PATCH 3/3] tty: xuartps: Fix build error when COMMON_CLK is not set"

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Sören Brinkmann]

On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb':
> drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
>   case PRE_RATE_CHANGE:
>        ^
> drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in
> drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type
>    if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud,
>                                     ^
> drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function)
>   case POST_RATE_CHANGE:
>        ^
> drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to incomplete type
>    port->uartclk = ndata->new_rate;
>                         ^
> drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function)
>   case ABORT_RATE_CHANGE:
>        ^
> drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe':
> drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration]
>   if (clk_notifier_register(xuartps_data->refclk,
>   ^
> drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration]
>   clk_notifier_unregister(xuartps_data->refclk,
>   ^
> 
> Caused by commits in the tty tree.
> 
> I have left this broken for today.

I already sent a series to Greg which should fix the x86 build of the
tty tree. I think he didn't apply those patches yet.

	Sören

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Greg KH]

On Mon, Oct 28, 2013 at 09:05:37AM -0700, Sören Brinkmann wrote:
> On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb':
> > drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
> >   case PRE_RATE_CHANGE:
> >        ^
> > drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in
> > drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type
> >    if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud,
> >                                     ^
> > drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function)
> >   case POST_RATE_CHANGE:
> >        ^
> > drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to incomplete type
> >    port->uartclk = ndata->new_rate;
> >                         ^
> > drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function)
> >   case ABORT_RATE_CHANGE:
> >        ^
> > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe':
> > drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration]
> >   if (clk_notifier_register(xuartps_data->refclk,
> >   ^
> > drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration]
> >   clk_notifier_unregister(xuartps_data->refclk,
> >   ^
> > 
> > Caused by commits in the tty tree.
> > 
> > I have left this broken for today.
> 
> I already sent a series to Greg which should fix the x86 build of the
> tty tree. I think he didn't apply those patches yet.

Yes, I have them, sorry, been traveling, will get to them later today...

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

Hi all,

On Mon, 28 Oct 2013 09:33:33 -0700 Greg KH <greg@kroah.com> wrote:
>
> On Mon, Oct 28, 2013 at 09:05:37AM -0700, Sören Brinkmann wrote:
> > On Tue, Oct 29, 2013 at 01:33:17AM +1100, Stephen Rothwell wrote:
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb':
> > > drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
> > >   case PRE_RATE_CHANGE:
> > >        ^
> > > drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in
> > > drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type
> > >    if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud,
> > >                                     ^
> > > 
> > > Caused by commits in the tty tree.
> > > 
> > > I have left this broken for today.
> > 
> > I already sent a series to Greg which should fix the x86 build of the
> > tty tree. I think he didn't apply those patches yet.
> 
> Yes, I have them, sorry, been traveling, will get to them later today...

As a temporary work around, I will disable xilinx_uartps in linux-next
today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/tty/serial/8250/8250_dw.c: In function 'dw8250_probe':
drivers/tty/serial/8250/8250_dw.c:341:3: error: too many arguments to function 'dw8250_probe_acpi'
   err = dw8250_probe_acpi(&uart, data);
   ^
drivers/tty/serial/8250/8250_dw.c:281:19: note: declared here
 static inline int dw8250_probe_acpi(struct uart_8250_port *up)
                   ^

Caused by commit fe95855539fd ("serial: 8250_dw: don't limit DMA support
to ACPI") from the tty tree.

I have reverted that commit for today (and commit 7fb8c56c7fa0 ("serial:
8250_dw: provide a filter for DMA channel detection") that depends on it).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Greg KH]

On Fri, Sep 27, 2013 at 06:21:17PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/tty/serial/8250/8250_dw.c: In function 'dw8250_probe':
> drivers/tty/serial/8250/8250_dw.c:341:3: error: too many arguments to function 'dw8250_probe_acpi'
>    err = dw8250_probe_acpi(&uart, data);
>    ^
> drivers/tty/serial/8250/8250_dw.c:281:19: note: declared here
>  static inline int dw8250_probe_acpi(struct uart_8250_port *up)
>                    ^
> 
> Caused by commit fe95855539fd ("serial: 8250_dw: don't limit DMA support
> to ACPI") from the tty tree.
> 
> I have reverted that commit for today (and commit 7fb8c56c7fa0 ("serial:
> 8250_dw: provide a filter for DMA channel detection") that depends on it).

Should now be fixed, thanks.

greg k-h

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

Hi all,

After merging the final tree, today's linux-next build (arm defconfig)
failed like this:

drivers/tty/serial/amba-pl011.c: In function 'pl011_rx_chars':
drivers/tty/serial/amba-pl011.c:1199:11: error: 'struct uart_amba_port' has no member named 'dmarx'
drivers/tty/serial/amba-pl011.c:1200:8: error: 'struct uart_amba_port' has no member named 'dmarx'
drivers/tty/serial/amba-pl011.c:1201:8: error: 'struct uart_amba_port' has no member named 'dmarx'
drivers/tty/serial/amba-pl011.c:1201:31: error: 'PL011_DMA_BUFFER_SIZE' undeclared (first use in this function)
drivers/tty/serial/amba-pl011.c:1201:31: note: each undeclared identifier is reported only once for each function it appears in
drivers/tty/serial/amba-pl011.c:1202:19: error: 'struct uart_amba_port' has no member named 'dmarx'
drivers/tty/serial/amba-pl011.c:1204:26: error: 'struct uart_amba_port' has no member named 'dmarx'
drivers/tty/serial/amba-pl011.c: In function 'pl011_set_termios':
drivers/tty/serial/amba-pl011.c:1671:9: error: 'struct uart_amba_port' has no member named 'dmarx'
drivers/tty/serial/amba-pl011.c:1672:6: error: 'struct uart_amba_port' has no member named 'dmarx'

Caused by commit cb06ff102e2d ("ARM: PL011: Add support for Rx DMA buffer
polling").  This build does not have CONFIG_DMA_ENGINE set.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory

Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
driver").

I have disabled this driver with this patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 27 Nov 2012 00:45:07 +1100
Subject: [PATCH] disable the SB105X driver

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/sb105x/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig
index ac87c5e..c957e32 100644
--- a/drivers/staging/sb105x/Kconfig
+++ b/drivers/staging/sb105x/Kconfig
@@ -2,6 +2,7 @@ config SB105X
 	tristate "SystemBase PCI Multiport UART"
 	select SERIAL_CORE
 	depends on PCI
+	depends on BROKEN
 	help
 	  A driver for the SystemBase Multi-2/PCI serial card
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Steven Rostedt]

On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory

I haven't tested this with any other arch than x86. That said, what
about this instead:


> 
> Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
> driver").
> 
> I have disabled this driver with this patch:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 27 Nov 2012 00:45:07 +1100
> Subject: [PATCH] disable the SB105X driver
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/sb105x/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig
> index ac87c5e..c957e32 100644
> --- a/drivers/staging/sb105x/Kconfig
> +++ b/drivers/staging/sb105x/Kconfig
> @@ -2,6 +2,7 @@ config SB105X
>  	tristate "SystemBase PCI Multiport UART"
>  	select SERIAL_CORE
>  	depends on PCI
> +	depends on BROKEN

	depends on X86

You can add my SOB if you want. I don't care either way.

-- Steve

>  	help
>  	  A driver for the SystemBase Multi-2/PCI serial card
>  
> -- 
> 1.7.10.280.gaa39
> 

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

Hi Steve,

On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
>
> On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote:
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> > drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory
> 
> I haven't tested this with any other arch than x86. That said, what
> about this instead:
> 
> > Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
> > driver").
> > 
> > I have disabled this driver with this patch:
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Tue, 27 Nov 2012 00:45:07 +1100
> > Subject: [PATCH] disable the SB105X driver
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/staging/sb105x/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig
> > index ac87c5e..c957e32 100644
> > --- a/drivers/staging/sb105x/Kconfig
> > +++ b/drivers/staging/sb105x/Kconfig
> > @@ -2,6 +2,7 @@ config SB105X
> >  	tristate "SystemBase PCI Multiport UART"
> >  	select SERIAL_CORE
> >  	depends on PCI
> > +	depends on BROKEN
> 
> 	depends on X86
> 
> You can add my SOB if you want. I don't care either way.

Please just send a (tested) patch to Greg.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

Hi Steve, Greg,

On Tue, 27 Nov 2012 10:05:30 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
> >
> > On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote:
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> > > drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory
> > 
> > I haven't tested this with any other arch than x86. That said, what
> > about this instead:
> > 
> > > Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
> > > driver").
> > > 
> > > I have disabled this driver with this patch:
> > > 
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Date: Tue, 27 Nov 2012 00:45:07 +1100
> > > Subject: [PATCH] disable the SB105X driver
> > > 
> > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > ---
> > >  drivers/staging/sb105x/Kconfig |    1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig
> > > index ac87c5e..c957e32 100644
> > > --- a/drivers/staging/sb105x/Kconfig
> > > +++ b/drivers/staging/sb105x/Kconfig
> > > @@ -2,6 +2,7 @@ config SB105X
> > >  	tristate "SystemBase PCI Multiport UART"
> > >  	select SERIAL_CORE
> > >  	depends on PCI
> > > +	depends on BROKEN
> > 
> > 	depends on X86
> > 
> > You can add my SOB if you want. I don't care either way.
> 
> Please just send a (tested) patch to Greg.

This now breaks Linus' tree .....
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Greg KH]

On Fri, Dec 14, 2012 at 10:32:56AM +1100, Stephen Rothwell wrote:
> Hi Steve, Greg,
> 
> On Tue, 27 Nov 2012 10:05:30 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 26 Nov 2012 09:35:12 -0500 Steven Rostedt <srostedt@redhat.com> wrote:
> > >
> > > On Tue, 2012-11-27 at 00:49 +1100, Stephen Rothwell wrote:
> > > > 
> > > > After merging the final tree, today's linux-next build (powerpc
> > > > allyesconfig) failed like this:
> > > > 
> > > > In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> > > > drivers/staging/sb105x/sb_pci_mp.h:22:25: fatal error: asm/segment.h: No such file or directory
> > > 
> > > I haven't tested this with any other arch than x86. That said, what
> > > about this instead:
> > > 
> > > > Caused by commit 68a81291ff66 ("staging: Add SystemBase Multi-2/PCI
> > > > driver").
> > > > 
> > > > I have disabled this driver with this patch:
> > > > 
> > > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > Date: Tue, 27 Nov 2012 00:45:07 +1100
> > > > Subject: [PATCH] disable the SB105X driver
> > > > 
> > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > ---
> > > >  drivers/staging/sb105x/Kconfig |    1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/drivers/staging/sb105x/Kconfig b/drivers/staging/sb105x/Kconfig
> > > > index ac87c5e..c957e32 100644
> > > > --- a/drivers/staging/sb105x/Kconfig
> > > > +++ b/drivers/staging/sb105x/Kconfig
> > > > @@ -2,6 +2,7 @@ config SB105X
> > > >  	tristate "SystemBase PCI Multiport UART"
> > > >  	select SERIAL_CORE
> > > >  	depends on PCI
> > > > +	depends on BROKEN
> > > 
> > > 	depends on X86
> > > 
> > > You can add my SOB if you want. I don't care either way.
> > 
> > Please just send a (tested) patch to Greg.
> 
> This now breaks Linus' tree .....

Ugh, can someone send me a patch to forward to Linus to fix this please?
Steven, how about fixing the problem properly?

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Steven Rostedt]

On Thu, 2012-12-13 at 15:38 -0800, Greg KH wrote:

> Ugh, can someone send me a patch to forward to Linus to fix this please?
> Steven, how about fixing the problem properly?

Yeah, ugh, I should have sent the fix earlier :-(

I've just been hammering at bugs for the people that pay me ;-)

OK, I'll whip up a patch that should at least fix the issue for the time
being.

-- Steve

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc64 defconfig)
failed like this:

fs/compat_ioctl.c:868:1: error: 'TIOCSRS485' undeclared here (not in a function)
fs/compat_ioctl.c:869:1: error: 'TIOCGRS485' undeclared here (not in a function)

Caused by commit 84c3b8486044 ("compat_ioctl: Add RS-485 IOCTLs to the
list") from the tty tree.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Greg KH]

On Tue, Sep 25, 2012 at 12:36:44AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> failed like this:
> 
> fs/compat_ioctl.c:868:1: error: 'TIOCSRS485' undeclared here (not in a function)
> fs/compat_ioctl.c:869:1: error: 'TIOCGRS485' undeclared here (not in a function)
> 
> Caused by commit 84c3b8486044 ("compat_ioctl: Add RS-485 IOCTLs to the
> list") from the tty tree.

Thanks, Jaeden just sent me a fix for this, I'll go apply it.

greg k-h

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2084 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/usb/serial/console.c: In function 'usb_console_setup':
drivers/usb/serial/console.c:168:16: error: invalid type argument of '->' (have 'struct ktermios')
drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'

Caused by commit adc8d746caa6 ("tty: move the termios object into the
tty").  Hopefully this is the last of them.

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 Jul 2012 14:58:31 +1000
Subject: [PATCH] tty: fix up usb serial console for termios change.

fixes these errors:

drivers/usb/serial/console.c: In function 'usb_console_setup':
drivers/usb/serial/console.c:168:16: error: invalid type argument of '->' (have 'struct ktermios')
drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/serial/console.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
index b9cca6d..9a56428 100644
--- a/drivers/usb/serial/console.c
+++ b/drivers/usb/serial/console.c
@@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co, char *options)
 		}
 
 		if (serial->type->set_termios) {
-			tty->termios->c_cflag = cflag;
-			tty_termios_encode_baud_rate(tty->termios, baud, baud);
+			tty->termios.c_cflag = cflag;
+			tty_termios_encode_baud_rate(&tty->termios, baud, baud);
 			memset(&dummy, 0, sizeof(struct ktermios));
 			serial->type->set_termios(tty, port, &dummy);
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Greg KH]

On Fri, Jul 20, 2012 at 03:02:37PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> 
> Caused by commit adc8d746caa6 ("tty: move the termios object into the
> tty").  Hopefully this is the last of them.
> 
> I have added the following fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 20 Jul 2012 14:58:31 +1000
> Subject: [PATCH] tty: fix up usb serial console for termios change.
> 
> fixes these errors:
> 
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/usb/serial/console.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
> index b9cca6d..9a56428 100644
> --- a/drivers/usb/serial/console.c
> +++ b/drivers/usb/serial/console.c
> @@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co, char *options)
>  		}
>  
>  		if (serial->type->set_termios) {
> -			tty->termios->c_cflag = cflag;
> -			tty_termios_encode_baud_rate(tty->termios, baud, baud);
> +			tty->termios.c_cflag = cflag;
> +			tty_termios_encode_baud_rate(&tty->termios, baud, baud);
>  			memset(&dummy, 0, sizeof(struct ktermios));
>  			serial->type->set_termios(tty, port, &dummy);
>  

Alan, any objection to this?

greg k-h

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Alan Cox]

> >  		if (serial->type->set_termios) {
> > -			tty->termios->c_cflag = cflag;
> > -			tty_termios_encode_baud_rate(tty->termios,
> > baud, baud);
> > +			tty->termios.c_cflag = cflag;
> > +
> > tty_termios_encode_baud_rate(&tty->termios, baud, baud);
> > memset(&dummy, 0, sizeof(struct ktermios));
> > serial->type->set_termios(tty, port, &dummy); 
> 
> Alan, any objection to this?

The fix looks correct to me.

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2276 bytes --]

Hi Greg, Alan,

On Fri, 20 Jul 2012 15:02:37 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> 
> Caused by commit adc8d746caa6 ("tty: move the termios object into the
> tty").  Hopefully this is the last of them.
> 
> I have added the following fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 20 Jul 2012 14:58:31 +1000
> Subject: [PATCH] tty: fix up usb serial console for termios change.
> 
> fixes these errors:
> 
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/usb/serial/console.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
> index b9cca6d..9a56428 100644
> --- a/drivers/usb/serial/console.c
> +++ b/drivers/usb/serial/console.c
> @@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co, char *options)
>  		}
>  
>  		if (serial->type->set_termios) {
> -			tty->termios->c_cflag = cflag;
> -			tty_termios_encode_baud_rate(tty->termios, baud, baud);
> +			tty->termios.c_cflag = cflag;
> +			tty_termios_encode_baud_rate(&tty->termios, baud, baud);
>  			memset(&dummy, 0, sizeof(struct ktermios));
>  			serial->type->set_termios(tty, port, &dummy);
>  
> -- 
> 1.7.10.280.gaa39

Ping?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Hi Greg,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/serial/apbuart.c:596: error: conflicting types for 'grlib_apbuart_configure'
drivers/serial/apbuart.c:523: note: previous declaration of 'grlib_apbuart_configure' was here

Caused by commit 35c64e5d13c3d7d8c4ad061ad5e20498b9160c24 ("drivers:
serial: apbuart: Handle OF failures gracefully").  This build has
CONFIG_SERIAL_GRLIB_GAISLER_APBUART_CONSOLE set ...

I have reverted this commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Greg KH]

On Fri, Dec 17, 2010 at 05:11:20PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/serial/apbuart.c:596: error: conflicting types for 'grlib_apbuart_configure'
> drivers/serial/apbuart.c:523: note: previous declaration of 'grlib_apbuart_configure' was here
> 
> Caused by commit 35c64e5d13c3d7d8c4ad061ad5e20498b9160c24 ("drivers:
> serial: apbuart: Handle OF failures gracefully").  This build has
> CONFIG_SERIAL_GRLIB_GAISLER_APBUART_CONSOLE set ...
> 
> I have reverted this commit for today.

Ugh.  Thomas, care to send me a patch?

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Thomas Gleixner]

On Thu, 16 Dec 2010, Greg KH wrote:
> On Fri, Dec 17, 2010 at 05:11:20PM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/serial/apbuart.c:596: error: conflicting types for 'grlib_apbuart_configure'
> > drivers/serial/apbuart.c:523: note: previous declaration of 'grlib_apbuart_configure' was here
> > 
> > Caused by commit 35c64e5d13c3d7d8c4ad061ad5e20498b9160c24 ("drivers:
> > serial: apbuart: Handle OF failures gracefully").  This build has
> > CONFIG_SERIAL_GRLIB_GAISLER_APBUART_CONSOLE set ...
> > 
> > I have reverted this commit for today.
> 
> Ugh.  Thomas, care to send me a patch?

Sorry, I missed the console part. Patch below.

Thanks,

	tglx
---
Subject: drivers: serial: apbuart: Fixup apbuart_console_init()
From: Thomas Gleixner <tglx@linutronix.de>
Date: Fri, 17 Dec 2010 11:09:49 +0100

commit 35c64e5d (drivers: serial: apbuart: Handle OF failures
gracefully) missed that the modified grlib_apbuart_configure()
function is called from apbuart_console_init() as well.

Fix the fallout.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/serial/apbuart.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux-2.6-tip/drivers/serial/apbuart.c
===================================================================
--- linux-2.6-tip.orig/drivers/serial/apbuart.c
+++ linux-2.6-tip/drivers/serial/apbuart.c
@@ -520,11 +520,12 @@ static struct console grlib_apbuart_cons
 };
 
 
-static void grlib_apbuart_configure(void);
+static int grlib_apbuart_configure(void);
 
 static int __init apbuart_console_init(void)
 {
-	grlib_apbuart_configure();
+	if (grlib_apbuart_configure())
+		return -ENODEV;
 	register_console(&grlib_apbuart_console);
 	return 0;
 }

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2219 bytes --]

HI Greg,

On Fri, 17 Dec 2010 11:16:17 +0100 (CET) Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Thu, 16 Dec 2010, Greg KH wrote:
> > On Fri, Dec 17, 2010 at 05:11:20PM +1100, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > drivers/serial/apbuart.c:596: error: conflicting types for 'grlib_apbuart_configure'
> > > drivers/serial/apbuart.c:523: note: previous declaration of 'grlib_apbuart_configure' was here
> > > 
> > > Caused by commit 35c64e5d13c3d7d8c4ad061ad5e20498b9160c24 ("drivers:
> > > serial: apbuart: Handle OF failures gracefully").  This build has
> > > CONFIG_SERIAL_GRLIB_GAISLER_APBUART_CONSOLE set ...
> > > 
> > > I have reverted this commit for today.
> > 
> > Ugh.  Thomas, care to send me a patch?
> 
> Sorry, I missed the console part. Patch below.

Ping?

> Thanks,
> 
> 	tglx
> ---
> Subject: drivers: serial: apbuart: Fixup apbuart_console_init()
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Fri, 17 Dec 2010 11:09:49 +0100
> 
> commit 35c64e5d (drivers: serial: apbuart: Handle OF failures
> gracefully) missed that the modified grlib_apbuart_configure()
> function is called from apbuart_console_init() as well.
> 
> Fix the fallout.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  drivers/serial/apbuart.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6-tip/drivers/serial/apbuart.c
> ===================================================================
> --- linux-2.6-tip.orig/drivers/serial/apbuart.c
> +++ linux-2.6-tip/drivers/serial/apbuart.c
> @@ -520,11 +520,12 @@ static struct console grlib_apbuart_cons
>  };
>  
>  
> -static void grlib_apbuart_configure(void);
> +static int grlib_apbuart_configure(void);
>  
>  static int __init apbuart_console_init(void)
>  {
> -	grlib_apbuart_configure();
> +	if (grlib_apbuart_configure())
> +		return -ENODEV;
>  	register_console(&grlib_apbuart_console);
>  	return 0;
>  }

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Greg KH]

On Thu, Jan 06, 2011 at 02:27:10PM +1100, Stephen Rothwell wrote:
> HI Greg,
> 
> On Fri, 17 Dec 2010 11:16:17 +0100 (CET) Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > On Thu, 16 Dec 2010, Greg KH wrote:
> > > On Fri, Dec 17, 2010 at 05:11:20PM +1100, Stephen Rothwell wrote:
> > > > Hi Greg,
> > > > 
> > > > After merging the final tree, today's linux-next build (powerpc
> > > > allyesconfig) failed like this:
> > > > 
> > > > drivers/serial/apbuart.c:596: error: conflicting types for 'grlib_apbuart_configure'
> > > > drivers/serial/apbuart.c:523: note: previous declaration of 'grlib_apbuart_configure' was here
> > > > 
> > > > Caused by commit 35c64e5d13c3d7d8c4ad061ad5e20498b9160c24 ("drivers:
> > > > serial: apbuart: Handle OF failures gracefully").  This build has
> > > > CONFIG_SERIAL_GRLIB_GAISLER_APBUART_CONSOLE set ...
> > > > 
> > > > I have reverted this commit for today.
> > > 
> > > Ugh.  Thomas, care to send me a patch?
> > 
> > Sorry, I missed the console part. Patch below.
> 
> Ping?

Ick, sorry about this, I've now applied this.

thanks for the reminder.

greg k-h

linux-next: build failure after merge of the final tree (tty tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi Greg,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/serial/ifx6x60.c: In function 'ifx_spi_reset':
drivers/serial/ifx6x60.c:928: error: implicit declaration of function 'msleep'

Caused by commit af3b8881f4c9852eefe9c7f1a997b3ecf580561b ("ifx6x60: SPI
protocol driver for Infineon 6x60 modem").  An include is missing
(linux/delay.h).  See Rule 1 in Documentation/SubmitChecklist.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (tty tree related)

[Alan Cox]

On Fri, 12 Nov 2010 12:57:51 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Greg,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/serial/ifx6x60.c: In function 'ifx_spi_reset':
> drivers/serial/ifx6x60.c:928: error: implicit declaration of function
> 'msleep'

Patch sent to Greg

Alan