From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prasun Maiti Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns Date: Wed, 8 Jun 2016 20:05:15 +0530 Message-ID: References: <1465388474-20503-1-git-send-email-prasunmaiti87@gmail.com> <87wplzkbd9.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <87wplzkbd9.fsf@kamboji.qca.qualcomm.com> Sender: linux-kernel-owner@vger.kernel.org To: "Valo, Kalle" Cc: Linux Kernel , "ath6kl@lists.infradead.org" , Linux Next , Linux Wireless , Linux Kernel List-Id: linux-next.vger.kernel.org No. I did not any test for that case. This driver create a new wiphy for use with cfg80211 through "wiphy_new_nm" api, but in this api, I found that more warnings for inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && !ops->get_antenna);" So, warning comes during creation of a new wiphy. That's why It is needed. On Wed, Jun 8, 2016 at 7:53 PM, Valo, Kalle wrote: > Prasun Maiti writes: > >> Since add more warnings for inconsistent ops in cfg80211, the wireless >> core warns if a driver implements a cfg80211 callback but doesn't >> implements the inverse operation. The ath6kl driver implements a cfg80211 >> .get_antenna operation handler but doesn't have the inverse .set_antenna >> callback. So, it makes warning. >> >> To remove this warning, add .set_antenna callback in ath6kl driver and >> also send a cmd to firmware with it's values. >> >> Signed-off-by: Prasun Maiti > > Did you test this? What hardware and firmware version? > > -- > Kalle Valo -- Thanks, Prasun