From: Jesse Gross <jesse@nicira.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andy Zhou <azhou@nicira.com>,
"dev@openvswitch.org" <dev@openvswitch.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Next <linux-next@vger.kernel.org>
Subject: Re: [-next] openvswitch BUILD_BUG_ON failed
Date: Thu, 29 Aug 2013 14:42:22 -0700 [thread overview]
Message-ID: <CAEP_g=-XvRiHPzSAp2rgC9Hxdd+pGEHvSTEJ1A1SkWnk1-6xZA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdVG9FmZNayrf7HMz4kC4X5QELeXUFjjzpAM80ND_QOm8A@mail.gmail.com>
On Thu, Aug 29, 2013 at 2:21 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> However, I have some doubts about other alignment "enforcements":
>
> "__aligned(__alignof__(long))" makes the whole struct aligned to the
> alignment rule for "long":
> 1. This is only 2 bytes on m68k, i.e. != sizeof(long).
> 2. This is 4 bytes on many 32-bit platforms, which may be less than the
> default alignment for "__be64" (cfr. some members of struct
> ovs_key_ipv4_tunnel), so this may make those 64-bit members unaligned.
Do any of those 32-bit architectures actually care about alignment of
64 bit values? On 32-bit x86, a long is 32 bits but the alignment
requirement of __be64 is also 32 bit.
next prev parent reply other threads:[~2013-08-29 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 21:21 [-next] openvswitch BUILD_BUG_ON failed Geert Uytterhoeven
[not found] ` <CAMuHMdVG9FmZNayrf7HMz4kC4X5QELeXUFjjzpAM80ND_QOm8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-29 21:40 ` Andy Zhou
2013-08-29 21:42 ` Jesse Gross [this message]
2013-08-29 22:10 ` David Miller
2013-08-30 1:11 ` Jesse Gross
2013-08-31 12:11 ` Geert Uytterhoeven
2013-09-03 21:44 ` Jesse Gross
2013-09-04 6:55 ` Geert Uytterhoeven
2013-09-04 17:53 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEP_g=-XvRiHPzSAp2rgC9Hxdd+pGEHvSTEJ1A1SkWnk1-6xZA@mail.gmail.com' \
--to=jesse@nicira.com \
--cc=azhou@nicira.com \
--cc=dev@openvswitch.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).