linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Rossi <issor.oruam@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Takashi Iwai <tiwai@suse.de>
Cc: Greg KH <greg@kroah.com>, Arnd Bergmann <arnd@arndb.de>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the char-misc.current tree
Date: Tue, 23 Jul 2019 01:31:27 +0200	[thread overview]
Message-ID: <CAEQFVGbuMKoE8uXkMjCAkey-H+tf_bjGqfRTnhweDvjgsRwL4A@mail.gmail.com> (raw)
In-Reply-To: <20190723082253.33b55afe@canb.auug.org.au>

On Tue, Jul 23, 2019 at 12:23 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the char-misc.current tree, today's linux-next build
> (arm multi_v7_defconfig) produced this warning:
>
> In file included from drivers/base/firmware_loader/main.c:41:
> drivers/base/firmware_loader/firmware.h:145:12: warning: 'fw_map_paged_buf' defined but not used [-Wunused-function]
>  static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; }
>             ^~~~~~~~~~~~~~~~
> drivers/base/firmware_loader/firmware.h:144:12: warning: 'fw_grow_paged_buf' defined but not used [-Wunused-function]
>  static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; }
>             ^~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
>   c8917b8ff09e ("firmware: fix build errors in paged buffer handling code")
>
> These need to be inline (as well as static) ... :-(
>
> --
> Cheers,
> Stephen Rothwell

They were 'static inline' in the patch I have submitted for review
when I reported the problem, but it was luck I am an hobbyst, not a
professional coder.

I checked with Takashi and Greg, because I noticed the inline removed
in the post review commit
and Takashi was checking if inline was really needed, now it's confirmed.

No big issue, now the important thing is that inline is added,
please Takashi kindly confirm when it's done.

Mauro

  reply	other threads:[~2019-07-22 23:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 22:22 linux-next: build warning after merge of the char-misc.current tree Stephen Rothwell
2019-07-22 23:31 ` Mauro Rossi [this message]
2020-09-07 23:43 Stephen Rothwell
2020-09-09 12:22 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEQFVGbuMKoE8uXkMjCAkey-H+tf_bjGqfRTnhweDvjgsRwL4A@mail.gmail.com \
    --to=issor.oruam@gmail.com \
    --cc=arnd@arndb.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).