From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: linux-next: build failure after merge of the pci tree Date: Tue, 10 Jun 2014 20:23:49 -0600 Message-ID: References: <20140611120249.56a64953@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:43043 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751937AbaFKCYK (ORCPT ); Tue, 10 Jun 2014 22:24:10 -0400 Received: by mail-ie0-f174.google.com with SMTP id lx4so4633250iec.5 for ; Tue, 10 Jun 2014 19:24:09 -0700 (PDT) In-Reply-To: <20140611120249.56a64953@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: linux-next list , "linux-kernel@vger.kernel.org" , Ryan Desfosses On Tue, Jun 10, 2014 at 8:02 PM, Stephen Rothwell wrote: > Hi Bjorn, > > After merging the pci tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > > ERROR: ".pci_try_set_mwi" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined! > ERROR: ".pci_clear_mwi" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined! > ERROR: ".pci_try_set_mwi" [drivers/scsi/lpfc/lpfc.ko] undefined! > > Caused by commit 9259d755975f ("PCI: Move EXPORT_SYMBOL so it > immediately follows function/variable"). > arch/powerpc/include/asm/pci.h defines PCI_DISABLE_MWI and there are > two version of those functions depending on the setting of that symbol. > > I have used the pci tree from next-20140610 for today. Thanks. This is my fault, not Ryan's. I made more similar changes, but didn't notice the #ifdefs around the definitions. I fixed it and will update my "next" branch tomorrow, after Fengguang's buildbot confirms the fix. Bjorn