From: Oded Gabbay <oded.gabbay@gmail.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-next@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER
Date: Tue, 24 Apr 2018 12:51:55 +0300 [thread overview]
Message-ID: <CAFCwf10nfNixtZrWkP7kGBfGyctrqZP2kwaFp1-KUDFtTgu-4g@mail.gmail.com> (raw)
In-Reply-To: <CADYN=9KhMhgCzmwg1P5FHEt0EaTH-EoELeF7mCCc-KtWocEGOQ@mail.gmail.com>
On Thu, Apr 19, 2018 at 1:46 PM, Anders Roxell <anders.roxell@linaro.org> wrote:
> On 14 April 2018 at 04:49, Randy Dunlap <rdunlap@infradead.org> wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> When CONFIG_MMU_NOTIFIER is not enabled, struct mmu_notifier has an
>> incomplete type definition, which causes build errors.
>>
>> ../drivers/gpu/drm/amd/amdkfd/kfd_priv.h:607:22: error: field 'mmu_notifier' has incomplete type
>> ../include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type
>> ../include/linux/kernel.h:980:18: error: dereferencing pointer to incomplete type
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:434:2: error: implicit declaration of function 'mmu_notifier_unregister_no_release' [-Werror=implicit-function-declaration]
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:435:2: error: implicit declaration of function 'mmu_notifier_call_srcu' [-Werror=implicit-function-declaration]
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:438:21: error: variable 'kfd_process_mmu_notifier_ops' has initializer but incomplete type
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: error: unknown field 'release' specified in initializer
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: excess elements in struct initializer [enabled by default]
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: (near initialization for 'kfd_process_mmu_notifier_ops') [enabled by default]
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:534:2: error: implicit declaration of function 'mmu_notifier_register' [-Werror=implicit-function-declaration]
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Oded Gabbay <oded.gabbay@gmail.com>
>> Cc: dri-devel@lists.freedesktop.org
>
> Tested-by: Anders Roxell <anders.roxell@linaro.org>
>
>> ---
>> From linux-next, not mmotm, but found in mmotm builds.
>>
>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- mmotm-2018-0413-1728.orig/drivers/gpu/drm/amd/amdkfd/Kconfig
>> +++ mmotm-2018-0413-1728/drivers/gpu/drm/amd/amdkfd/Kconfig
>> @@ -6,5 +6,6 @@ config HSA_AMD
>> tristate "HSA kernel driver for AMD GPU devices"
>> depends on DRM_AMDGPU && X86_64
>> imply AMD_IOMMU_V2
>> + select MMU_NOTIFIER
>> help
>> Enable this if you want to use HSA features on AMD GPU devices.
>>
Thanks, taken to -fixes
Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-04-24 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 0:29 mmotm 2018-04-13-17-28 uploaded akpm
2018-04-14 2:49 ` [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER Randy Dunlap
2018-04-19 10:46 ` Anders Roxell
2018-04-24 9:51 ` Oded Gabbay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFCwf10nfNixtZrWkP7kGBfGyctrqZP2kwaFp1-KUDFtTgu-4g@mail.gmail.com \
--to=oded.gabbay@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).