From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D63C7C3A5A3 for ; Tue, 27 Aug 2019 16:10:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8D0F206BF for ; Tue, 27 Aug 2019 16:10:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="im8IgKyU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728670AbfH0QJ4 (ORCPT ); Tue, 27 Aug 2019 12:09:56 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46307 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbfH0QJ4 (ORCPT ); Tue, 27 Aug 2019 12:09:56 -0400 Received: by mail-pg1-f195.google.com with SMTP id m3so12920823pgv.13 for ; Tue, 27 Aug 2019 09:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=n+ewofGgqXwwrEKyd3RnPtDD4SWAWjoyL/KF4JyMz0k=; b=im8IgKyU7PApob9zdI2bKkHvClM5tT3ZrZYAP9rmDDUg2jlCUrhIR7L7c0BfEDnHpO 83ImifBo2cwuBUYl0UrPcB7CsJhC4+RrnVCamMHsdTui6dclTm5U19ArrKd8yJoxlQ7t c3tKw01vr0xikmjsHQ+RmpVXSfKJPDY2IXJ99aAd+gvVVMdibijXDdCXNuumogny6Rdc hq1Uao85EHQuS0GacD1QPj9OpkXEqnkLKbKkiOuM8YUifp1Q723saPkLh1zDASOy6TDZ m1baB002Y+CIWihR71yHbuQzHwiHYbvlkv9Gj4f89a/+tfj7GF6yucTl9PeicbkqwJEy iP/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=n+ewofGgqXwwrEKyd3RnPtDD4SWAWjoyL/KF4JyMz0k=; b=gJB0wL1ezFGyGrCiIW/kZfTio3hNtI7XEv3rEK8Yl+Po/NNDUKlLCrytbfdsyNAm/C yoMgn34QHheUCaACXCNiq1v6macw0y/gTxhN/GCIL/sovCzMBxkPecaHeDuSR8zPTtMR 6yP7PNenH07pJ/BHAjCrsfMgvae9e4lbQX90S/T3cw2qb8fT396k4TpXRNG0JL8lhQUi fJpDChREYLGxLS+Xs5OhLII2D/pmbgJKetWOBxPe0+DdcIvwKKAoCV//jqgBME2e4rUO 6zDuLIx1dz8sjDinjvCUc2QOay/KH9gyNbtFm8WkS7SUyQPzUUXDDq11r/7UIXTgcLsn iGZA== X-Gm-Message-State: APjAAAUazDLEVF1HBw8lN5HndNMIH/3VWVAWQkSjeeiFUkHTF0+XGJHW 09edcG2PkprFYNqnDWoqDbN3hakdaJ6aJXSC9y+oBsnw X-Google-Smtp-Source: APXvYqzquXmLYJxp8UUmLZGf/BqLEQu+rHsFlpty6Ng28rMacp102hu83XiIbg/DHK3ZGZb0KgfDfSnGw/9w/JHxBWg= X-Received: by 2002:a17:90a:25ea:: with SMTP id k97mr26573759pje.131.1566922194974; Tue, 27 Aug 2019 09:09:54 -0700 (PDT) MIME-Version: 1.0 References: <20190827190526.6f27e763@canb.auug.org.au> In-Reply-To: From: Brendan Higgins Date: Tue, 27 Aug 2019 09:09:43 -0700 Message-ID: Subject: Re: linux-next: Tree for Aug 27 (kunit) To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, Aug 27, 2019 at 8:29 AM Randy Dunlap wrote: > > On 8/27/19 2:05 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20190826: > > > > on i386: > # CONFIG_PRINTK is not set > > > ../kunit/test.c: In function =E2=80=98kunit_vprintk_emit=E2=80=99: > ../kunit/test.c:21:9: error: implicit declaration of function =E2=80=98vp= rintk_emit=E2=80=99; did you mean =E2=80=98vprintk=E2=80=99? [-Werror=3Dimp= licit-function-declaration] > return vprintk_emit(0, level, NULL, 0, fmt, args); > ^~~~~~~~~~~~ > vprintk Ooops, it never occurred to me to test the situation where I wouldn't be able to see test results :-) It seems to me that the right thing to do here is to do what dev_printk and friends do and to ifdef this out if CONFIG_PRINTK is unavailable. Does that seem reasonable? Also, do you want me to resend my patches with the fix or do you want me to send a new patch with this fix? (Sorry for the newbie question.) Thanks!