From: Chen-Yu Tsai <wens@csie.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Olof Johansson <olof@lixom.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Eric Anholt <eric@anholt.net>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
ARM <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commits in the arm-soc tree
Date: Mon, 16 Jul 2018 17:24:08 +0800 [thread overview]
Message-ID: <CAGb2v667K4Z6o-KEQROWuCbgJbKLNX_OCpCBOWaECb_qfRMBpw@mail.gmail.com> (raw)
In-Reply-To: <6a9fa6f3-7aef-a83b-72a6-dc9492964b5e@gmail.com>
On Mon, Jul 16, 2018 at 5:13 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
> On 07/15/2018 03:50 PM, Olof Johansson wrote:
>> Thanks Stephen, I keep saying every time you catch these that I need
>> to run the same script. :(
>>
>> Florian, I wonder if this happened when you rebased to squash in the fix?
>
> Humm, could be, all I did (and it was not the first time) was to do an
> interactive rebase with --preserve-merges. AFAICT, all of these commits
> came from Eric's pull request, so what I typically do is just sign off
> on the merge commit, but do not apply my SoB to all commits coming from
> that pull request if that makes sense?
When you rebase, if the commit is re-applied, the committer changes to
you, so you need to add your SoB to all commits you rebased.
I suppose you could override it with GIT_COMMITTER_NAME and
GIT_COMMITTER_EMAIL environment variables, but that sort of distorts
the SoB if any changes were added due to rebasing, such as resolution
of merge conflicts.
ChenYu
next prev parent reply other threads:[~2018-07-16 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 21:57 linux-next: Signed-off-by missing for commits in the arm-soc tree Stephen Rothwell
2018-07-15 22:50 ` Olof Johansson
2018-07-16 9:13 ` Florian Fainelli
2018-07-16 9:24 ` Chen-Yu Tsai [this message]
2018-07-16 9:54 ` Florian Fainelli
2018-07-16 9:57 ` Russell King - ARM Linux
2018-07-16 11:55 ` Florian Fainelli
2018-10-02 21:21 Stephen Rothwell
2018-10-04 19:37 ` Maxime Ripard
2020-07-26 21:35 Stephen Rothwell
2020-07-27 7:27 ` Arnd Bergmann
2021-10-27 11:53 Stephen Rothwell
2022-02-27 20:45 Stephen Rothwell
2022-02-28 11:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v667K4Z6o-KEQROWuCbgJbKLNX_OCpCBOWaECb_qfRMBpw@mail.gmail.com \
--to=wens@csie.org \
--cc=arnd@arndb.de \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).