From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="b/exAFwl" Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F24D1E9 for ; Mon, 11 Dec 2023 00:31:37 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-32f8441dfb5so3986896f8f.0 for ; Mon, 11 Dec 2023 00:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1702283496; x=1702888296; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=J9TssOoYj5sq85cjGlO/OWfUu7/5yk2nPtfgDzXrsu4=; b=b/exAFwl1xEjLGjHrsK8kWRYbVdGJl+RKzc/k56POwnbn40kdYE38lU2eVnAQSzZNv 1Pg0QzFqzdtwVLdK/6IulXVmaiqkjcKMQgaMTpNe7aDunluqVu//50joowZh1OZR8bur XQsh4J30Q5atWBeORwJJn/EoQ51RCU+y1ocUQp60uoeKKV3vK7ZnV0AY8/0s6Mp7bxLr 8qKN5GiD+C73xyRGv5fOtjUgENuYY9zMEoYKsbtBtDhxwcdAipNaFm2HBxRHY6naHyu3 1vifF9nfjr0/fXS3sKHnp7CpyLwmog6xebg1bjmFkqx6mnDL/jpPKhDyv57ANU9nvi0d 2Dhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702283496; x=1702888296; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J9TssOoYj5sq85cjGlO/OWfUu7/5yk2nPtfgDzXrsu4=; b=r7SlXipMKjXGgXNn7NyPwVd/j7dHBmQzOCwDdd2QPp1ahKeKtfYDB8fhQPAJ2E6LEu W5XDyhfvyabpm0hIoThp3E/9dGMs7hlaDICvk1/sWpWPGsCZn5+etU9CMjSO/JpfKg62 MX9CxD4J7ppr2DA2OkMOqfZzHWzB9dPsmRLnDihbBfdP2LFDx0pyWDtkV2y4i7rAqjzT 480Aqqm0EW826xW0TVD26hgLICg3lJXWIsxk/0i3f/B79hXYerFN+K6YBYfGiMYmhw5A /R1mkYCAfy4fdw5evcd5P1B5NR50ZzolvpoqYvsYYuDnrU88h+NuPiXhQob7Mkvz3bVQ +2KQ== X-Gm-Message-State: AOJu0YzbErP2U9ekKU8DDMf8g0RAXvreEt63SvqRbNSqjEi8Sy7t6CoM ZjRqolXU9DI+NW5zidlwzfksPyMPAo1cawk/9X7+nA== X-Google-Smtp-Source: AGHT+IHw6KbgF5ZdUqFJP2PUqyg2V4aLIlCnsgX6uYnrOdbdZVebUYLmRkdZ3Ba2r7B6LHXVcwP2IURHq+gQ2dAl7eo= X-Received: by 2002:adf:e781:0:b0:333:2fd2:6f7a with SMTP id n1-20020adfe781000000b003332fd26f7amr2089438wrm.132.1702283496334; Mon, 11 Dec 2023 00:31:36 -0800 (PST) Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231211171406.71fdc29b@canb.auug.org.au> In-Reply-To: <20231211171406.71fdc29b@canb.auug.org.au> From: Alexandre Ghiti Date: Mon, 11 Dec 2023 09:31:25 +0100 Message-ID: Subject: Re: linux-next: build failure after merge of the percpu tree To: Stephen Rothwell Cc: Dennis Zhou , Tejun Heo , Christoph Lameter , Ingo Molnar , Linux Kernel Mailing List , Linux Next Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stephen, On Mon, Dec 11, 2023 at 7:14=E2=80=AFAM Stephen Rothwell wrote: > > Hi all, > > After merging the percpu tree, today's linux-next build (sparc64 > defconfig) failed like this: > > mm/percpu.c: In function 'pcpu_page_first_chunk': > mm/percpu.c:3336:17: error: implicit declaration of function 'flush_cache= _vmap_early'; did you mean 'flush_cache_vmap'? [-Werror=3Dimplicit-function= -declaration] > 3336 | flush_cache_vmap_early(unit_addr, unit_addr + ai-= >unit_size); > | ^~~~~~~~~~~~~~~~~~~~~~ > | flush_cache_vmap > cc1: some warnings being treated as errors > > Caused by commit > > a95c15a43f4a ("mm: Introduce flush_cache_vmap_early() and its riscv imp= lementation") > > I have applied the following fix patch for today. Are there other > archs that don't use asm-generic/cacheflush.h? It seems like most archs do not include this file, I should have checked. As I'm a bit scared of the possible side-effects of including asm-generic/cacheflush.h, I'll define flush_cache_vmap_early() on all archs that do define flush_cache_vmap(). Stephen, do you want a patch fix? Or do you want me to send a new version of the current patches so that you can drop them for now? Sorry for the oversight, Thanks, Alex > > From: Stephen Rothwell > Date: Mon, 11 Dec 2023 16:57:00 +1100 > Subject: [PATCH] fix up for "mm: Introduce flush_cache_vmap_early() and i= ts riscv implementation" > > Signed-off-by: Stephen Rothwell > --- > arch/sparc/include/asm/cacheflush.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/sparc/include/asm/cacheflush.h b/arch/sparc/include/asm= /cacheflush.h > index 881ac76eab93..9d87b2bcb217 100644 > --- a/arch/sparc/include/asm/cacheflush.h > +++ b/arch/sparc/include/asm/cacheflush.h > @@ -10,4 +10,11 @@ > #else > #include > #endif > + > +#ifndef __ASSEMBLY__ > +static inline void flush_cache_vmap_early(unsigned long start, unsigned = long end) > +{ > +} > +#endif > + > #endif > -- > 2.40.1 > > -- > Cheers, > Stephen Rothwell