From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gomonovych, Vasyl" Subject: Re: [PATCH v2] misc: mic: Use memdup_user() as a cleanup Date: Tue, 12 Dec 2017 14:22:41 +0100 Message-ID: References: <20171212143910.146724d2@canb.auug.org.au> <1513075258-10860-1-git-send-email-gomonovych@gmail.com> <20171212114937.GA23534@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20171212114937.GA23534@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg KH Cc: Stephen Rothwell , Arnd Bergmann , sudeep.dutt@intel.com, ashutosh.dixit@intel.com, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org List-Id: linux-next.vger.kernel.org Hi, Thanks. Should I prepare fix patch only for missed label? Regards Vasyl. On Tue, Dec 12, 2017 at 12:49 PM, Greg KH wrote: > On Tue, Dec 12, 2017 at 11:40:58AM +0100, Vasyl Gomonovych wrote: >> Fix coccicheck warning which recommends to use memdup_user(): >> >> drivers/misc/mic/vop/vop_vringh.c:940:14-21: WARNING opportunity for mem= dup_user >> drivers/misc/mic/vop/vop_vringh.c:998:8-15: WARNING opportunity for memd= up_user >> >> Generated by: scripts/coccinelle/memdup_user/memdup_user.cocci >> >> Changelog: >> - v1: >> - Replace kzalloc + copy_from_user on memdup_user >> - v2: >> - Clear forgotten done label >> After merging the char-misc tree, today's linux-next build >> (x86_64_allmodconfig) produced this warning: >> drivers/misc/mic/vop/vop_vringh.c: In function 'vop_ioctl': >> drivers/misc/mic/vop/vop_vringh.c:1001:1: warning: label 'done' def= ined but not used [-Wunused-label] > > Will not work as I already have taken v1. > > Also, put the changelog below the --- line please. > > thanks, > > greg k-h --=20 =D0=94=D0=BE=D0=B1=D1=80=D0=BE=D1=97 =D0=B2=D0=B0=D0=BC =D0=BF=D0=BE=D1=80= =D0=B8 =D0=B4=D0=BD=D1=8F.