From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C1DEB64D7 for ; Fri, 30 Jun 2023 03:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbjF3DoU (ORCPT ); Thu, 29 Jun 2023 23:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjF3DoT (ORCPT ); Thu, 29 Jun 2023 23:44:19 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43C632694 for ; Thu, 29 Jun 2023 20:44:18 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-986d8332f50so167818366b.0 for ; Thu, 29 Jun 2023 20:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1688096656; x=1690688656; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DtdBcJGSafD9v1Gyc2SS9XYrmiGJVVhtneeuVwTi0t4=; b=MMKICGoQxSyosBvkESXPQp0shoQIMuWxB3nqsnT7wmyREw9srQKiXKv2yx/Xmf5asw FN6EeIEQKjwn6jw0mIKTUTMQq+jjO9jvF3aW8iJ0vCMbwXyude8HL4j222u/BXCvmRLd Ni7dVmF0G1TpKp3v4hX6k95xZON1IpGjOoU4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688096656; x=1690688656; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DtdBcJGSafD9v1Gyc2SS9XYrmiGJVVhtneeuVwTi0t4=; b=aQXZiA+/TsZ5iBgzdA4LQrKnftd3nzPWyxD+KPAkbWH5CMlyOqoKRnHIuK+r+119+i +QxhkPFqs2HZxstUTcyYjf0joh2xNW69bbqAu8BbrxbA5q6gT/5iyBtz5CHr0M+lzWaW FqGXKM/t6uTgj0+Y0eGPwK2tIYiiQp+MqscGfuLWwSnWbPOEC5K4IOhLyIEgTFR7Ph+P 2agfaRx9sYxchkkA9Nyr/P6mReyROxQLVDZ5jznEfwnO9HB7Lfu/toN6DDhyrTfofQYz TIttNczXrzh1+PfxLvpSjacE/J2ZXkuXNZNlf1VQQrFe5G0xYJq+a+ON5Yyztb3dqZcR VGuw== X-Gm-Message-State: ABy/qLZFIfVo4J0lma+K7l7kppskPwbWKBuQ7omqrq1JSII7DcAbYGkn 5Voq1YqYA3fGAX/d4td1otGxR3yLWDqZGAYRjMAQGb0v X-Google-Smtp-Source: APBJJlFaVZwMDolxPsHe3owLWeZAvSp5i4EX2bQto4p6+oWCnSn0zSy5BzLDznB/rl2YstOMVR3h3Q== X-Received: by 2002:a17:906:9489:b0:98d:e605:2bce with SMTP id t9-20020a170906948900b0098de6052bcemr809309ejx.46.1688096656567; Thu, 29 Jun 2023 20:44:16 -0700 (PDT) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id lh22-20020a170906f8d600b0098282bb8effsm7552921ejb.196.2023.06.29.20.44.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 20:44:15 -0700 (PDT) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-51d804c7d14so1422286a12.3 for ; Thu, 29 Jun 2023 20:44:15 -0700 (PDT) X-Received: by 2002:a50:ef16:0:b0:51d:d48b:9978 with SMTP id m22-20020a50ef16000000b0051dd48b9978mr583174eds.8.1688096655507; Thu, 29 Jun 2023 20:44:15 -0700 (PDT) MIME-Version: 1.0 References: <20230630125926.785699c1@canb.auug.org.au> In-Reply-To: <20230630125926.785699c1@canb.auug.org.au> From: Linus Torvalds Date: Thu, 29 Jun 2023 20:43:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure after merge of the origin tree To: Stephen Rothwell Cc: Linux Kernel Mailing List , Linux Next Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, 29 Jun 2023 at 19:59, Stephen Rothwell wrote: > > After merging the origin tree, today's linux-next build (sparc defconfig) > failed like this: > > /home/sfr/next/next/arch/sparc/mm/fault_32.c: In function 'force_user_fault': > /home/sfr/next/next/arch/sparc/mm/fault_32.c:315:49: error: 'regs' undeclared (first use in this function) > 315 | vma = lock_mm_and_find_vma(mm, address, regs); Duh. Yeah, the register window faults don't pass the user register state pointer around, and as noted in commit a050ba1e7422 those left-over conversions were mostly done blind. The fix is trivial - just pass in NULL for the regs pointer. It's not required. Said fix pushed out. Thanks, Linus