From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1235C4363A for ; Fri, 23 Oct 2020 15:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D77221D47 for ; Fri, 23 Oct 2020 15:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603468791; bh=mriDfNZeSOsY3E7iF8bTx6Iue1eFMbjdN4unfPYRSRE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=OLU+DLUKHcfqG7078O423iuQw0YDDlyAWZy1aCydxofk/IPkIUZiddKZIwuDt+tv3 gAmfhXJgkqEdExv4QOmPyC/9MP2Ffp+1ZzFnRstgoXcRVF8ncEG84eqjKtUJEnLo6Q BfkHOXbjR/HL/g4iCJ3nbvZI06WCu+dY/2ienMVg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S464849AbgJWP7u (ORCPT ); Fri, 23 Oct 2020 11:59:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S464756AbgJWP7u (ORCPT ); Fri, 23 Oct 2020 11:59:50 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D25EAC0613CE for ; Fri, 23 Oct 2020 08:59:49 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id c141so2692920lfg.5 for ; Fri, 23 Oct 2020 08:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=So975owvkkTFfYXQ470Q4DlssmIVIFu2QdqnJrTF8xg=; b=TzWUN3CTm+h3r1g9oyCsI8lQvw43xzR9vIG57jNVIMScon9dkhOPSHSU0YuPTCTEbW xSUTXNkTa/xHcxjOZm+H+owVFWXNWx30+II0u/JJDBaUgnHNJQKAZRQgLvSR8UT7JBoq 5hUnMcwfEz4zN7MfPmgGe/s+oSgXWn8ttaA2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=So975owvkkTFfYXQ470Q4DlssmIVIFu2QdqnJrTF8xg=; b=q8Gyv/CbRoBeQUTV6SksLpGRUeNasvegxyM8aky9UnnzywyGZt78f8BJHtfcIblxFq 5EBNytn+VTri9CFhR2n0dug/+W5YRCLwsdP3mecOaEXyZkfXOvCfwjyw8cRi6F94ud06 BXjSRr5QW3oFvbxQhZWVeNKDPq9eey50yMNUU3g1kUVc2KQJ5hE7CTqV5qi1qE/FJYUN yb09E4TPZiZI2AHjfv8tNLW1bGPG5e68fRAl8NBVOqtA7AYTHwuxJI3gbSVyhOeiN0w/ XszAW7dDjRCMZx9aLXD6NDt8eXxAbj9fl5LqYZh+E3kFZooc1FYGQSU7x3is843Tyyys GAkA== X-Gm-Message-State: AOAM5337235FCXi9+XHoqBKrZSoK0ZAIpF2t6w23GXKJ/mE7YkrZ7QQG VjqUxg04OwXhYgvwA1qefB4y+O249v5mWg== X-Google-Smtp-Source: ABdhPJxKl4P55/Loedj60rNozBY6l+LmQmt9x0WULSKQVVwQMMTamgnzh70UuyzS2XXATF2PBo11pA== X-Received: by 2002:a05:6512:104d:: with SMTP id c13mr896531lfb.350.1603468788081; Fri, 23 Oct 2020 08:59:48 -0700 (PDT) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com. [209.85.208.178]) by smtp.gmail.com with ESMTPSA id x11sm173013lfa.174.2020.10.23.08.59.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Oct 2020 08:59:47 -0700 (PDT) Received: by mail-lj1-f178.google.com with SMTP id x16so2120127ljh.2 for ; Fri, 23 Oct 2020 08:59:47 -0700 (PDT) X-Received: by 2002:a2e:898c:: with SMTP id c12mr1248002lji.285.1603468386475; Fri, 23 Oct 2020 08:53:06 -0700 (PDT) MIME-Version: 1.0 References: <20201023050214.GG23681@linux.intel.com> In-Reply-To: <20201023050214.GG23681@linux.intel.com> From: Linus Torvalds Date: Fri, 23 Oct 2020 08:52:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [LTP] mmstress[1309]: segfault at 7f3d71a36ee8 ip 00007f3d77132bdf sp 00007f3d71a36ee8 error 4 in libc-2.27.so[7f3d77058000+1aa000] To: Sean Christopherson Cc: =?UTF-8?B?RGFuaWVsIETDrWF6?= , Naresh Kamboju , Stephen Rothwell , "Matthew Wilcox (Oracle)" , zenglg.jy@cn.fujitsu.com, "Peter Zijlstra (Intel)" , Viresh Kumar , X86 ML , open list , lkft-triage@lists.linaro.org, "Eric W. Biederman" , linux-mm , linux-m68k , Linux-Next Mailing List , Thomas Gleixner , kasan-dev , Dmitry Vyukov , Geert Uytterhoeven , Christian Brauner , Ingo Molnar , LTP List , Al Viro Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, Oct 22, 2020 at 10:02 PM Sean Christopherson wrote: > > I haven't reproduced the crash, but I did find a smoking gun that confirms the > "register shenanigans are evil shenanigans" theory. I ran into a similar thing > recently where a seemingly innocuous line of code after loading a value into a > register variable wreaked havoc because it clobbered the input register. Yup, that certainly looks like the smoking gun. Thanks for finding an example of this, clearly I'll have to either go back to the "conditionally use 'A' or 'a' depending on size" model, or perhaps try Rasmus' patch. Linus