From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
Vishwanath Somayaji <vishwanath.somayaji@intel.com>
Subject: Re: linux-next: Tree for Feb 11 (drivers/platform/x86/intel_pmc_core.c)
Date: Wed, 12 Feb 2020 16:23:25 +0200 [thread overview]
Message-ID: <CAHp75Ve3oenxkSCr9FC14MErQeN6pwrafemgKUNMwxUDr+aYKA@mail.gmail.com> (raw)
In-Reply-To: <f0d576b6-7204-0caf-1ca8-aae6c82d3b8d@infradead.org>
On Tue, Feb 11, 2020 at 9:32 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 2/10/20 6:00 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20200210:
> >
>
> on i386:
>
> Function args are reversed (offset and status);
>
> ../drivers/platform/x86/intel_pmc_core.c: In function 'pmc_core_resume':
> ../drivers/platform/x86/intel_pmc_core.c:1329:43: warning: passing argument 4 of 'pmc_core_lpm_display' makes integer from pointer without a cast [-Wint-conversion]
> pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
> ^~~~~~~~
> ../drivers/platform/x86/intel_pmc_core.c:977:13: note: expected 'u32 {aka unsigned int}' but argument is of type 'char *'
> static void pmc_core_lpm_display(struct pmc_dev *pmcdev, struct device *dev,
> ^~~~~~~~~~~~~~~~~~~~
> ../drivers/platform/x86/intel_pmc_core.c:1329:53: warning: passing argument 5 of 'pmc_core_lpm_display' makes pointer from integer without a cast [-Wint-conversion]
> pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
> ^~~~~~
> ../drivers/platform/x86/intel_pmc_core.c:977:13: note: expected 'const char *' but argument is of type 'int'
> static void pmc_core_lpm_display(struct pmc_dev *pmcdev, struct device *dev,
> ^~~~~~~~~~~~~~~~~~~~
Thank you, it should be fixed in today's Linux Next.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-02-12 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 2:00 linux-next: Tree for Feb 11 Stephen Rothwell
2020-02-11 7:06 ` linux-next: Tree for Feb 11 (drivers/platform/x86/intel_pmc_core.c) Randy Dunlap
2020-02-12 14:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Ve3oenxkSCr9FC14MErQeN6pwrafemgKUNMwxUDr+aYKA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajneesh.bhardwaj@intel.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=vishwanath.somayaji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).