* linux-next: Signed-off-by missing for commit in the fpga tree
@ 2022-05-10 4:56 Stephen Rothwell
2022-05-10 6:41 ` Moritz Fischer
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2022-05-10 4:56 UTC (permalink / raw)
To: Moritz Fischer, Xu Yilun, Wu Hao
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
Hi all,
Commits
7269868818a4 ("fpga: fpga-region: fix kernel-doc formatting issues")
d73ef1ed7300 ("fpga: Use tab instead of space indentation")
154970f89f06 ("fpga: fpga-mgr: fix kernel-doc warnings")
d0749c3c95fc ("fpga: fix for coding style issues")
are missing a Signed-off-by from their committer.
(A danger of rebasing omeone else's commits ..)
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the fpga tree
2022-05-10 4:56 linux-next: Signed-off-by missing for commit in the fpga tree Stephen Rothwell
@ 2022-05-10 6:41 ` Moritz Fischer
0 siblings, 0 replies; 5+ messages in thread
From: Moritz Fischer @ 2022-05-10 6:41 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Xu Yilun, Wu Hao, Linux Kernel Mailing List, Linux Next Mailing List
Ugh..
On Mon, May 9, 2022 at 9:56 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commits
>
> 7269868818a4 ("fpga: fpga-region: fix kernel-doc formatting issues")
> d73ef1ed7300 ("fpga: Use tab instead of space indentation")
> 154970f89f06 ("fpga: fpga-mgr: fix kernel-doc warnings")
> d0749c3c95fc ("fpga: fix for coding style issues")
>
> are missing a Signed-off-by from their committer.
>
> (A danger of rebasing omeone else's commits ..)
>
> --
> Cheers,
> Stephen Rothwell
Ok, there are some other issues on the current next branch. We'll clean that up.
Thanks for flagging this,
Moritz
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: Signed-off-by missing for commit in the fpga tree
@ 2023-07-16 22:02 Stephen Rothwell
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2023-07-16 22:02 UTC (permalink / raw)
To: Moritz Fischer, Xu Yilun, Wu Hao
Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
Hi all,
Commit
7617b957c6dd ("fpga: Explicitly include correct DT includes")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the fpga tree
2020-11-15 22:52 Stephen Rothwell
@ 2020-11-16 0:24 ` Moritz Fischer
0 siblings, 0 replies; 5+ messages in thread
From: Moritz Fischer @ 2020-11-16 0:24 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Moritz Fischer, Linux Kernel Mailing List, Linux Next Mailing List
On Mon, Nov 16, 2020 at 09:52:40AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> aaf8fe39c952 ("Revert "fpga: dfl: fix the definitions of type & feature_id for dfl devices"")
> 9922e71f43ac ("Revert "fpga: dfl: move dfl_device_id to mod_devicetable.h"")
> 3ae706b58b0b ("Revert "fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE()"")
> dd57ca7ddec5 ("Revert "fpga: dfl: move dfl bus related APIs to include/linux/dfl.h"")
>
> are missing a Signed-off-by from their author and committer.
>
> Reverts are commits, too. It is also very useful for the commit message
> of a revert to contain some reason(s) for the revert as this may help
> future developers.
>
> --
> Cheers,
> Stephen Rothwell
Sorry, thanks for catching that, for posterity the reason was
that Greg had some further comments and didn't take the pull-request
as-is, so I wanted to have the next-tree reflect that.
I'll be more careful next time,
- Moritz
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: Signed-off-by missing for commit in the fpga tree
@ 2020-11-15 22:52 Stephen Rothwell
2020-11-16 0:24 ` Moritz Fischer
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-11-15 22:52 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
Hi all,
Commits
aaf8fe39c952 ("Revert "fpga: dfl: fix the definitions of type & feature_id for dfl devices"")
9922e71f43ac ("Revert "fpga: dfl: move dfl_device_id to mod_devicetable.h"")
3ae706b58b0b ("Revert "fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE()"")
dd57ca7ddec5 ("Revert "fpga: dfl: move dfl bus related APIs to include/linux/dfl.h"")
are missing a Signed-off-by from their author and committer.
Reverts are commits, too. It is also very useful for the commit message
of a revert to contain some reason(s) for the revert as this may help
future developers.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-16 22:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 4:56 linux-next: Signed-off-by missing for commit in the fpga tree Stephen Rothwell
2022-05-10 6:41 ` Moritz Fischer
-- strict thread matches above, loose matches on Subject: below --
2023-07-16 22:02 Stephen Rothwell
2020-11-15 22:52 Stephen Rothwell
2020-11-16 0:24 ` Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).