From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58583C2BA83 for ; Fri, 14 Feb 2020 07:41:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14F3B20873 for ; Fri, 14 Feb 2020 07:41:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PLV4gdiq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728799AbgBNHlQ (ORCPT ); Fri, 14 Feb 2020 02:41:16 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:51458 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728691AbgBNHlQ (ORCPT ); Fri, 14 Feb 2020 02:41:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581666074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9AH+9K6FkW+pS7y9tB+dRIaOPalyWaM9Mi1EFVqxmeQ=; b=PLV4gdiqXMux5OeT85wGX5+B1MnrbsuKjT2qoCjssJ9rm0a7R0oDZYj50/p55EeTiw6Mtv 3N6Sd+kuXwe1P3W6t0JrQz/P0qOYVNwg0MRclR17vctm17toGdju86GSBrB881IQPOticu ni/o3eXnibzHyK28ytv9ENIgoXQ7kII= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-i77KcM0bN9-jhKFQ0jSTrg-1; Fri, 14 Feb 2020 02:41:10 -0500 X-MC-Unique: i77KcM0bN9-jhKFQ0jSTrg-1 Received: by mail-qv1-f72.google.com with SMTP id v3so5206466qvm.2 for ; Thu, 13 Feb 2020 23:41:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9AH+9K6FkW+pS7y9tB+dRIaOPalyWaM9Mi1EFVqxmeQ=; b=qSBNYjl7yG6rB6SO8mP0DmTh/LoTQREMMWCNj+A8KqdN8anaEdzp1c97mt70FZxE3w ksNft0WYBV5vDUpOtIpLzqQF6fIvI76AujmwvcGX5ig5QS1LYMvEngBIowMY2McsboG7 PX00pjszm5/FwSctWkOJ1+Rf823Urq7zhWxkc0wRdKMXrVcHs7Qc+CdlSGVZv1zoWx0V ttDFt2nasFlB+PgKaiCEItyGnfcKxkVxWkKqwhejKu62yWA8m88NB7Yhv4cRM5pUKCfu /RzUvuN1FMCYycNxV/EAwK4iw3psqw9PXVFZWl71blZrpYM32osjV5B+AXS9xSx/YS3H zHgA== X-Gm-Message-State: APjAAAVSJLVSufJXDH8hsgOZ8rwSm7bnt9PCbUxg8wPKlNLPx5K0Um8Y 9sy2VEMp5AXz71ksu4efl1IdaybOTn6FlwEAPdxb9gNhJayarpBK0HPnY1O5sCLAA0Fwl+HFBPf IAG+GsYehi6mnfC1RN3KJ/g9Bt8g3M+Dey0lCow== X-Received: by 2002:ac8:176f:: with SMTP id u44mr1455074qtk.379.1581666070296; Thu, 13 Feb 2020 23:41:10 -0800 (PST) X-Google-Smtp-Source: APXvYqzbJpYEfdIZO/Iz53hVql41wATZvSjrzaMJqeYJxMLbgGQEKZWPSNFwizIFAAhfVXZ/o5Dfo0cO5Cu3d+E5qrU= X-Received: by 2002:ac8:176f:: with SMTP id u44mr1455058qtk.379.1581666069907; Thu, 13 Feb 2020 23:41:09 -0800 (PST) MIME-Version: 1.0 References: <20200107042401-mutt-send-email-mst@kernel.org> <1ade56b5-083f-bb6f-d3e0-3ddcf78f4d26@de.ibm.com> <20200206171349-mutt-send-email-mst@kernel.org> <5c860fa1-cef5-b389-4ebf-99a62afa0fe8@de.ibm.com> <20200207025806-mutt-send-email-mst@kernel.org> <97c93d38-ef07-e321-d133-18483d54c0c0@de.ibm.com> <43a5dbaa-9129-e220-8483-45c60a82c945@de.ibm.com> <4c3f70b7-723a-8b0f-ac49-babef1bcc180@de.ibm.com> <50a79c3491ac483583c97df2fac29e2c3248fdea.camel@redhat.com> <8fbbfb49-99d1-7fee-e713-d6d5790fe866@de.ibm.com> <2364d0728c3bb4bcc0c13b591f774109a9274a30.camel@redhat.com> <468983fad50a5e74a739f71487f0ea11e8d4dfd1.camel@redhat.com> <2dc1df65-1431-3917-40e5-c2b12096e2a7@de.ibm.com> In-Reply-To: From: Eugenio Perez Martin Date: Fri, 14 Feb 2020 08:40:33 +0100 Message-ID: Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot To: Christian Borntraeger Cc: "Michael S. Tsirkin" , "virtualization@lists.linux-foundation.org" , Stephen Rothwell , Linux Next Mailing List , "linux-kernel@vger.kernel.org" , kvm list , Halil Pasic , Cornelia Huck Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hi. Were the vhost and vhost_net modules loaded with dyndbg=3D'+plt'? I miss all the others regular debug traces on that one. Thanks! On Fri, Feb 14, 2020 at 8:34 AM Christian Borntraeger wrote: > > I did > ping -c 20 -f ... ; reboot > twice > > The ping after the first reboot showed .......E > > this was on the host console > > [ 55.951885] CPU: 34 PID: 1908 Comm: CPU 0/KVM Not tainted 5.5.0+ #21 > [ 55.951891] Hardware name: IBM 3906 M04 704 (LPAR) > [ 55.951892] Call Trace: > [ 55.951902] [<0000001ede114132>] show_stack+0x8a/0xd0 > [ 55.951906] [<0000001edeb0672a>] dump_stack+0x8a/0xb8 > [ 55.951915] [<000003ff803736a6>] vhost_vring_ioctl+0x6fe/0x858 [vhost= ] > [ 55.951919] [<000003ff8042a608>] vhost_net_ioctl+0x510/0x570 [vhost_n= et] > [ 55.951924] [<0000001ede3c4dd8>] do_vfs_ioctl+0x430/0x6f8 > [ 55.951926] [<0000001ede3c5124>] ksys_ioctl+0x84/0xb0 > [ 55.951927] [<0000001ede3c51ba>] __s390x_sys_ioctl+0x2a/0x38 > [ 55.951931] [<0000001edeb27f72>] system_call+0x2a6/0x2c8 > [ 55.951949] CPU: 34 PID: 1908 Comm: CPU 0/KVM Not tainted 5.5.0+ #21 > [ 55.951950] Hardware name: IBM 3906 M04 704 (LPAR) > [ 55.951951] Call Trace: > [ 55.951952] [<0000001ede114132>] show_stack+0x8a/0xd0 > [ 55.951954] [<0000001edeb0672a>] dump_stack+0x8a/0xb8 > [ 55.951956] [<000003ff803736a6>] vhost_vring_ioctl+0x6fe/0x858 [vhost= ] > [ 55.951958] [<000003ff8042a608>] vhost_net_ioctl+0x510/0x570 [vhost_n= et] > [ 55.951959] [<0000001ede3c4dd8>] do_vfs_ioctl+0x430/0x6f8 > [ 55.951961] [<0000001ede3c5124>] ksys_ioctl+0x84/0xb0 > [ 55.951962] [<0000001ede3c51ba>] __s390x_sys_ioctl+0x2a/0x38 > [ 55.951964] [<0000001edeb27f72>] system_call+0x2a6/0x2c8 > [ 55.951997] Guest moved vq 0000000063d896c6 used index from 44 to 0 > [ 56.609831] unexpected descriptor format for RX: out 0, in 0 > [ 86.540460] CPU: 6 PID: 1908 Comm: CPU 0/KVM Not tainted 5.5.0+ #21 > [ 86.540464] Hardware name: IBM 3906 M04 704 (LPAR) > [ 86.540466] Call Trace: > [ 86.540473] [<0000001ede114132>] show_stack+0x8a/0xd0 > [ 86.540477] [<0000001edeb0672a>] dump_stack+0x8a/0xb8 > [ 86.540486] [<000003ff803736a6>] vhost_vring_ioctl+0x6fe/0x858 [vhost= ] > [ 86.540490] [<000003ff8042a608>] vhost_net_ioctl+0x510/0x570 [vhost_n= et] > [ 86.540494] [<0000001ede3c4dd8>] do_vfs_ioctl+0x430/0x6f8 > [ 86.540496] [<0000001ede3c5124>] ksys_ioctl+0x84/0xb0 > [ 86.540498] [<0000001ede3c51ba>] __s390x_sys_ioctl+0x2a/0x38 > [ 86.540501] [<0000001edeb27f72>] system_call+0x2a6/0x2c8 > [ 86.540524] CPU: 6 PID: 1908 Comm: CPU 0/KVM Not tainted 5.5.0+ #21 > [ 86.540525] Hardware name: IBM 3906 M04 704 (LPAR) > [ 86.540526] Call Trace: > [ 86.540527] [<0000001ede114132>] show_stack+0x8a/0xd0 > [ 86.540528] [<0000001edeb0672a>] dump_stack+0x8a/0xb8 > [ 86.540531] [<000003ff803736a6>] vhost_vring_ioctl+0x6fe/0x858 [vhost= ] > [ 86.540532] [<000003ff8042a608>] vhost_net_ioctl+0x510/0x570 [vhost_n= et] > [ 86.540534] [<0000001ede3c4dd8>] do_vfs_ioctl+0x430/0x6f8 > [ 86.540536] [<0000001ede3c5124>] ksys_ioctl+0x84/0xb0 > [ 86.540537] [<0000001ede3c51ba>] __s390x_sys_ioctl+0x2a/0x38 > [ 86.540538] [<0000001edeb27f72>] system_call+0x2a6/0x2c8 > [ 86.540570] unexpected descriptor format for RX: out 0, in 0 > [ 86.540577] Unexpected header len for TX: 0 expected 0 > > > On 14.02.20 08:06, Eugenio P=C3=A9rez wrote: > > Hi Christian. > > > > Sorry, that was meant to be applied over previous debug patch. > > > > Here I inline the one meant to be applied over eccb852f1fe6bede630e2e4f= 1a121a81e34354ab. > > > > Thanks! > > > > From d978ace99e4844b49b794d768385db3d128a4cc0 Mon Sep 17 00:00:00 2001 > > From: =3D?UTF-8?q?Eugenio=3D20P=3DC3=3DA9rez?=3D > > Date: Fri, 14 Feb 2020 08:02:26 +0100 > > Subject: [PATCH] vhost: disable all features and trace last_avail_idx a= nd > > ioctl calls > > > > --- > > drivers/vhost/net.c | 20 +++++++++++++++++--- > > drivers/vhost/vhost.c | 25 +++++++++++++++++++++++-- > > drivers/vhost/vhost.h | 10 +++++----- > > 3 files changed, 45 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > > index e158159671fa..e4d5f843f9c0 100644 > > --- a/drivers/vhost/net.c > > +++ b/drivers/vhost/net.c > > @@ -1505,10 +1505,13 @@ static long vhost_net_set_backend(struct vhost_= net *n, unsigned index, int fd) > > > > mutex_lock(&n->dev.mutex); > > r =3D vhost_dev_check_owner(&n->dev); > > - if (r) > > + if (r) { > > + pr_debug("vhost_dev_check_owner index=3D%u fd=3D%d rc r= =3D%d", index, fd, r); > > goto err; > > + } > > > > if (index >=3D VHOST_NET_VQ_MAX) { > > + pr_debug("vhost_dev_check_owner index=3D%u fd=3D%d MAX=3D= %d", index, fd, VHOST_NET_VQ_MAX); > > r =3D -ENOBUFS; > > goto err; > > } > > @@ -1518,22 +1521,26 @@ static long vhost_net_set_backend(struct vhost_= net *n, unsigned index, int fd) > > > > /* Verify that ring has been setup correctly. */ > > if (!vhost_vq_access_ok(vq)) { > > + pr_debug("vhost_net_set_backend index=3D%u fd=3D%d !vhost= _vq_access_ok", index, fd); > > r =3D -EFAULT; > > goto err_vq; > > } > > sock =3D get_socket(fd); > > if (IS_ERR(sock)) { > > r =3D PTR_ERR(sock); > > + pr_debug("vhost_net_set_backend index=3D%u fd=3D%d get_so= cket err r=3D%d", index, fd, r); > > goto err_vq; > > } > > > > /* start polling new socket */ > > oldsock =3D vq->private_data; > > if (sock !=3D oldsock) { > > + pr_debug("sock=3D%p !=3D oldsock=3D%p index=3D%u fd=3D%d = vq=3D%p", sock, oldsock, index, fd, vq); > > ubufs =3D vhost_net_ubuf_alloc(vq, > > sock && vhost_sock_zcopy(soc= k)); > > if (IS_ERR(ubufs)) { > > r =3D PTR_ERR(ubufs); > > + pr_debug("ubufs index=3D%u fd=3D%d err r=3D%d vq= =3D%p", index, fd, r, vq); > > goto err_ubufs; > > } > > > > @@ -1541,11 +1548,15 @@ static long vhost_net_set_backend(struct vhost_= net *n, unsigned index, int fd) > > vq->private_data =3D sock; > > vhost_net_buf_unproduce(nvq); > > r =3D vhost_vq_init_access(vq); > > - if (r) > > + if (r) { > > + pr_debug("init_access index=3D%u fd=3D%d r=3D%d v= q=3D%p", index, fd, r, vq); > > goto err_used; > > + } > > r =3D vhost_net_enable_vq(n, vq); > > - if (r) > > + if (r) { > > + pr_debug("enable_vq index=3D%u fd=3D%d r=3D%d vq= =3D%p", index, fd, r, vq); > > goto err_used; > > + } > > if (index =3D=3D VHOST_NET_VQ_RX) > > nvq->rx_ring =3D get_tap_ptr_ring(fd); > > > > @@ -1559,6 +1570,8 @@ static long vhost_net_set_backend(struct vhost_ne= t *n, unsigned index, int fd) > > > > mutex_unlock(&vq->mutex); > > > > + pr_debug("sock=3D%p", sock); > > + > > if (oldubufs) { > > vhost_net_ubuf_put_wait_and_free(oldubufs); > > mutex_lock(&vq->mutex); > > @@ -1710,6 +1723,7 @@ static long vhost_net_ioctl(struct file *f, unsig= ned int ioctl, > > > > switch (ioctl) { > > case VHOST_NET_SET_BACKEND: > > + pr_debug("VHOST_NET_SET_BACKEND"); > > if (copy_from_user(&backend, argp, sizeof backend)) > > return -EFAULT; > > return vhost_net_set_backend(n, backend.index, backend.fd= ); > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > > index b5a51b1f2e79..ec25ba32fe81 100644 > > --- a/drivers/vhost/vhost.c > > +++ b/drivers/vhost/vhost.c > > @@ -1642,15 +1642,30 @@ long vhost_vring_ioctl(struct vhost_dev *d, uns= igned int ioctl, void __user *arg > > r =3D -EINVAL; > > break; > > } > > + > > + if (vq->last_avail_idx || vq->avail_idx) { > > + pr_debug( > > + "strange VHOST_SET_VRING_BASE [vq=3D%p][s= .index=3D%u][s.num=3D%u]", > > + vq, s.index, s.num); > > + dump_stack(); > > + r =3D 0; > > + break; > > + } > > vq->last_avail_idx =3D s.num; > > /* Forget the cached index value. */ > > vq->avail_idx =3D vq->last_avail_idx; > > + pr_debug( > > + "VHOST_SET_VRING_BASE [vq=3D%p][vq->last_avail_id= x=3D%u][vq->avail_idx=3D%u][s.index=3D%u][s.num=3D%u]", > > + vq, vq->last_avail_idx, vq->avail_idx, s.index, s= .num); > > break; > > case VHOST_GET_VRING_BASE: > > s.index =3D idx; > > s.num =3D vq->last_avail_idx; > > if (copy_to_user(argp, &s, sizeof s)) > > r =3D -EFAULT; > > + pr_debug( > > + "VHOST_GET_VRING_BASE [vq=3D%p][vq->last_avail_id= x=3D%u][vq->avail_idx=3D%u][s.index=3D%u][s.num=3D%u]", > > + vq, vq->last_avail_idx, vq->avail_idx, s.index, s= .num); > > break; > > case VHOST_SET_VRING_KICK: > > if (copy_from_user(&f, argp, sizeof f)) { > > @@ -2239,8 +2254,8 @@ static int fetch_buf(struct vhost_virtqueue *vq) > > vq->avail_idx =3D vhost16_to_cpu(vq, avail_idx); > > > > if (unlikely((u16)(vq->avail_idx - last_avail_idx) > vq->= num)) { > > - vq_err(vq, "Guest moved used index from %u to %u"= , > > - last_avail_idx, vq->avail_idx); > > + vq_err(vq, "Guest moved vq %p used index from %u = to %u", > > + vq, last_avail_idx, vq->avail_idx); > > return -EFAULT; > > } > > > > @@ -2316,6 +2331,9 @@ static int fetch_buf(struct vhost_virtqueue *vq) > > BUG_ON(!(vq->used_flags & VRING_USED_F_NO_NOTIFY)); > > > > /* On success, increment avail index. */ > > + pr_debug( > > + "[vq=3D%p][vq->last_avail_idx=3D%u][vq->avail_idx=3D%u][v= q->ndescs=3D%d][vq->first_desc=3D%d]", > > + vq, vq->last_avail_idx, vq->avail_idx, vq->ndescs, vq->fi= rst_desc); > > vq->last_avail_idx++; > > > > return 0; > > @@ -2432,6 +2450,9 @@ EXPORT_SYMBOL_GPL(vhost_get_vq_desc); > > /* Reverse the effect of vhost_get_vq_desc. Useful for error handling.= */ > > void vhost_discard_vq_desc(struct vhost_virtqueue *vq, int n) > > { > > + pr_debug( > > + "DISCARD [vq=3D%p][vq->last_avail_idx=3D%u][vq->avail_idx= =3D%u][n=3D%d]", > > + vq, vq->last_avail_idx, vq->avail_idx, n); > > vq->last_avail_idx -=3D n; > > } > > EXPORT_SYMBOL_GPL(vhost_discard_vq_desc); > > diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h > > index 661088ae6dc7..08f6d2ccb697 100644 > > --- a/drivers/vhost/vhost.h > > +++ b/drivers/vhost/vhost.h > > @@ -250,11 +250,11 @@ int vhost_init_device_iotlb(struct vhost_dev *d, = bool enabled); > > } while (0) > > > > enum { > > - VHOST_FEATURES =3D (1ULL << VIRTIO_F_NOTIFY_ON_EMPTY) | > > - (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | > > - (1ULL << VIRTIO_RING_F_EVENT_IDX) | > > - (1ULL << VHOST_F_LOG_ALL) | > > - (1ULL << VIRTIO_F_ANY_LAYOUT) | > > + VHOST_FEATURES =3D /* (1ULL << VIRTIO_F_NOTIFY_ON_EMPTY) | */ > > + /* (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | */ > > + /* (1ULL << VIRTIO_RING_F_EVENT_IDX) | */ > > + /* (1ULL << VHOST_F_LOG_ALL) | */ > > + /* (1ULL << VIRTIO_F_ANY_LAYOUT) | */ > > (1ULL << VIRTIO_F_VERSION_1) > > }; > > > > >