From: Miklos Szeredi <miklos@szeredi.hu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the overlayfs tree
Date: Tue, 22 Nov 2016 09:41:44 +0100 [thread overview]
Message-ID: <CAJfpegsb5Qg0Y0SRpDC32tq1w2CBzdwMNip5DN-=QoEsfoqTAA@mail.gmail.com> (raw)
In-Reply-To: <20161122111939.0c0ea92a@canb.auug.org.au>
On Tue, Nov 22, 2016 at 1:19 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Miklos,
>
> After merging the overlayfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> In file included from fs/overlayfs/dir.c:20:0:
> fs/overlayfs/dir.c: In function 'ovl_set_redirect':
> fs/overlayfs/overlayfs.h:92:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
> int err = vfs_setxattr(dentry, name, value, size, flags);
> ^
> fs/overlayfs/dir.c:788:14: note: 'ret' was declared here
> char *buf, *ret;
> ^
>
> Introduced by commit
>
> 496654b0792e ("ovl: redirect on rename-dir")
>
> This is not necessarily a false positive (although is is a confusing
> message): if the kmalloc of "buf" fails and samedir was not set in
> ovl_get_redirect(), then "return ret" will be executed but "ret" has
> not been set.
Fixed. Thanks for reporting.
Miklos
next prev parent reply other threads:[~2016-11-22 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 0:19 linux-next: build warning after merge of the overlayfs tree Stephen Rothwell
2016-11-22 8:41 ` Miklos Szeredi [this message]
2017-05-17 0:19 Stephen Rothwell
2017-05-17 5:00 ` Amir Goldstein
2017-11-08 22:33 Stephen Rothwell
2017-11-09 3:59 ` Chandan Rajendra
2021-03-29 9:14 Stephen Rothwell
2021-03-29 9:28 ` Miklos Szeredi
2021-03-31 0:16 ` Stephen Rothwell
2021-04-21 6:26 ` Stephen Rothwell
2021-07-20 6:38 Stephen Rothwell
2021-07-21 13:39 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegsb5Qg0Y0SRpDC32tq1w2CBzdwMNip5DN-=QoEsfoqTAA@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).