From: Alexander Mikhalitsyn <alexander@mihalicyn.com>
To: "Von Dentz, Luiz" <luiz.von.dentz@intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Christian Brauner <brauner@kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: linux-next: build failure after merge of the bluetooth tree
Date: Fri, 23 Jun 2023 11:23:57 +0200 [thread overview]
Message-ID: <CAJqdLrrVfQx4fWJjpf0Nz7AdiNshdFi7xgXis_iO1jgU0YeGXw@mail.gmail.com> (raw)
In-Reply-To: <CAJqdLrpFcga4n7wxBhsFqPQiN8PKFVr6U10fKcJ9W7AcZn+o6Q@mail.gmail.com>
On Fri, Jun 23, 2023 at 10:34 AM Alexander Mikhalitsyn
<alexander@mihalicyn.com> wrote:
>
> On Fri, Jun 23, 2023 at 12:28 AM Von Dentz, Luiz
> <luiz.von.dentz@intel.com> wrote:
> >
> > Hi Stephen, Alexander,
>
> Dear friends,
>
> >
> > Looks like we have a similar problem as to:
> >
> > https://lore.kernel.org/lkml/20230524081933.44dc8bea@kernel.org/
> >
> > That said for unix socket it was decided to not allow it to be build as module, which is something I don't think we are willing to do for bluetooth, so we have to find a way to get around pidfd_prepare, which seems to be called due to the use of scm_recv (it is also used by netlink btw).
>
> Ugh, yep. That's bad and we can't workaround it like we did for unix sockets.
>
> Originally, Christian had objections against exporting the
> pidfd_prepare function [1]
>
> [1] https://lore.kernel.org/all/20230523-flechten-ortsschild-e5724ecc4ed0@brauner/
>
> +cc Christian
Idea. (-: We can introduce a new function like "scm_recv_light" that
will be just an old version of "scm_recv" without using pidfd,
if this feature with SCM_PIDFD is not important for hci sockets.
Forgot to add Jakub to CC.
+cc Jakub
>
> Kind regards,
> Alex
>
> >
> >
> > ________________________________ From: Stephen Rothwell
> > Sent: Monday, June 12, 2023 8:02 PM
> > To: Marcel Holtmann; Johan Hedberg
> > Cc: Von Dentz, Luiz; Linux Kernel Mailing List; Linux Next Mailing List
> > Subject: linux-next: build failure after merge of the bluetooth tree
> >
> > Hi all,
> >
> > After merging the bluetooth tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
> >
> > Caused by commit
> >
> > 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
> >
> > I have reverted that commit for today.
> >
> > --
> > Cheers,
> > Stephen Rothwell
next prev parent reply other threads:[~2023-06-23 9:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PH0PR11MB51262F07CD4739BDCB920483D322A@PH0PR11MB5126.namprd11.prod.outlook.com>
2023-06-23 8:34 ` linux-next: build failure after merge of the bluetooth tree Alexander Mikhalitsyn
2023-06-23 9:23 ` Alexander Mikhalitsyn [this message]
2023-06-23 12:24 ` Christian Brauner
2023-06-23 12:28 ` Alexander Mikhalitsyn
2023-06-23 15:09 ` Jakub Kicinski
2023-06-26 22:09 ` Alexander Mikhalitsyn
2024-05-01 1:19 Stephen Rothwell
2024-05-01 1:34 ` Sungwoo Kim
-- strict thread matches above, loose matches on Subject: below --
2023-07-20 22:21 Iwashima, Kuniyuki
[not found] <PH0PR11MB51269B6805230AB8ED209B14D332A@PH0PR11MB5126.namprd11.prod.outlook.com>
2023-07-20 0:50 ` Stephen Rothwell
2023-07-20 1:24 ` Jakub Kicinski
2023-07-20 3:00 ` Stephen Rothwell
[not found] ` <PH0PR11MB5126763E5913574B8ED6BDE4D33EA@PH0PR11MB5126.namprd11.prod.outlook.com>
2023-07-20 3:24 ` Jakub Kicinski
2023-07-20 6:00 ` Alexander Mikhalitsyn
2023-07-20 15:14 ` Jakub Kicinski
2023-07-20 15:21 ` Alexander Mikhalitsyn
2023-07-20 22:19 ` Stephen Rothwell
2023-07-20 22:12 ` Stephen Rothwell
2023-07-20 23:27 ` Jakub Kicinski
2023-07-20 23:30 ` Stephen Rothwell
[not found] <PH0PR11MB5126F2B2E020774AF8D91299D35BA@PH0PR11MB5126.namprd11.prod.outlook.com>
2023-06-15 23:27 ` Stephen Rothwell
2023-06-13 3:02 Stephen Rothwell
2023-06-15 22:32 ` Stephen Rothwell
2023-07-06 23:41 ` Stephen Rothwell
2021-12-07 0:26 Stephen Rothwell
2021-12-06 0:37 Stephen Rothwell
2021-09-27 0:16 Stephen Rothwell
[not found] <PH0PR11MB5126EFEDB65650EFC3368981D3749@PH0PR11MB5126.namprd11.prod.outlook.com>
2021-04-08 4:57 ` Stephen Rothwell
2021-04-08 3:59 Stephen Rothwell
2020-07-27 3:44 Stephen Rothwell
2020-07-27 5:22 ` Christoph Hellwig
2020-07-27 13:28 ` Alain Michaud
2019-10-18 0:13 Stephen Rothwell
2015-09-14 0:14 Stephen Rothwell
2015-09-14 0:22 ` Stephen Rothwell
2015-09-22 1:20 ` Stephen Rothwell
2015-09-22 3:42 ` David Miller
2015-08-12 8:01 Stephen Rothwell
2014-10-27 2:19 Stephen Rothwell
2014-10-28 14:49 ` Johan Hedberg
2012-09-19 1:45 Stephen Rothwell
2012-02-22 1:21 Stephen Rothwell
2012-02-22 1:29 ` David Miller
2011-12-21 2:19 Stephen Rothwell
2011-04-28 1:41 Stephen Rothwell
2011-04-28 4:12 ` Gustavo F. Padovan
2011-02-15 2:16 Stephen Rothwell
2011-02-15 12:48 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJqdLrrVfQx4fWJjpf0Nz7AdiNshdFi7xgXis_iO1jgU0YeGXw@mail.gmail.com \
--to=alexander@mihalicyn.com \
--cc=brauner@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).