From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Wu Subject: Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks Date: Tue, 5 Mar 2013 10:46:51 -0800 Message-ID: References: <1360771110-9490-1-git-send-email-christian.gmeiner@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-la0-f46.google.com ([209.85.215.46]:58836 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755343Ab3CESrN (ORCPT ); Tue, 5 Mar 2013 13:47:13 -0500 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Christian Gmeiner Cc: akpm , "linux-next@vger.kernel.org" , LKML , stable@vger.kernel.org On Sun, Mar 3, 2013 at 11:40 PM, Christian Gmeiner wrote: > ping > -- > Christian Gmeiner, MSc > > > 2013/2/23 Christian Gmeiner : >> 2013/2/15 Bryan Wu : >>> On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner >>> wrote: >>>> During the development of this driver an in-house register >>>> documentation was used. The last weeks some integration tests >>>> were done and this problem was found. It turned out that >>>> the released register documentation is wrong. >>>> >>>> The fix is very simple: shift all masks by one. >>>> >>>> Our customers can control LEDs from userspace via Java, >>>> C++ or what every. They have running/working applications where >>>> they want to control led_3 but led_2 get's used. >>>> I got a bug report in our in-house bug tracker so it would be >>>> great to fix this upstream. >>>> >>>> Signed-off-by: Christian Gmeiner >>> >>> Thanks, Christian. >>> >>> And Andrew, are you going to take care of this patch? Or I will merge this. >>> >> >> Whats the current state of the patch? Hope we can get it into 3.9 :) >> I think this patch is already in linux-next via Andrew's tree (commit 023206171f235f93f26c314f76f5405a3077aaba). So it will be merged into 3.10 I guess, but not 3.9. Or I can send out this patch to Linus as a fix and ask Andrew to drop this from his tree. Thanks, -Bryan