From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E81C31E49 for ; Wed, 19 Jun 2019 04:05:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB7642084B for ; Wed, 19 Jun 2019 04:05:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="njLHgxeA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725854AbfFSEFV (ORCPT ); Wed, 19 Jun 2019 00:05:21 -0400 Received: from condef-02.nifty.com ([202.248.20.67]:32889 "EHLO condef-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbfFSEFV (ORCPT ); Wed, 19 Jun 2019 00:05:21 -0400 Received: from conssluserg-04.nifty.com ([10.126.8.83])by condef-02.nifty.com with ESMTP id x5J435ZY020676 for ; Wed, 19 Jun 2019 13:03:05 +0900 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) (authenticated) by conssluserg-04.nifty.com with ESMTP id x5J42qB4032589; Wed, 19 Jun 2019 13:02:53 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com x5J42qB4032589 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1560916973; bh=tkjX5PNPrJPasCTxYHgyfQnyjLXksXDnK7VVj0pwtio=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=njLHgxeAGTZ5u0FEsPFhFCMOXl8f5pQ/EGbVZSeENKMHAWMQsfwCoTCWU/U7Ov5KU SFK3e3xhe+ovZc9jbwXYo7GvanaDCaRumyuRmyWf/X+6EIhpNvjC4FsXfsf4LXmiiO w9yv77nIuqOKlgPDlGhI4ePlpqpoZJpgbQ9X7kYCGemTTE5ZVCmVwX/j0FeEOU+Jyk HtCvJRWgPAiyf/ygzvbVNi56ywoBFvCBOxUDJhMzFhsHhr/+M4lYGwi5mWJQ/3UizI YxExw6VY/RMuDD9UNdLh9hbBSF+oDW+LwkjgVyCrBXf5xZfFUOGj3fBg3pqrChVB0g RqOJhZ6u5X+Lg== X-Nifty-SrcIP: [209.85.222.54] Received: by mail-ua1-f54.google.com with SMTP id v20so3021031uao.3; Tue, 18 Jun 2019 21:02:52 -0700 (PDT) X-Gm-Message-State: APjAAAXUfrKw3y3ZmopRuYu8DK2ocC8zDi+UmQZwwdArs7riTy/SoRmJ Rc9I+ewo2XiTU0wcu2OcH9KHlFDmdwlxhmQCmsM= X-Google-Smtp-Source: APXvYqyrqOA+mb7BvfFmB/sS1UkmNbUU4f3Y32P40E16rHImNQaL4GpzCijTQmg4Wje+hkLazBbiBWljAqa5DIzeWLA= X-Received: by 2002:a67:cd1a:: with SMTP id u26mr26623437vsl.155.1560916971750; Tue, 18 Jun 2019 21:02:51 -0700 (PDT) MIME-Version: 1.0 References: <20190619132326.1846345b@canb.auug.org.au> In-Reply-To: <20190619132326.1846345b@canb.auug.org.au> From: Masahiro Yamada Date: Wed, 19 Jun 2019 13:02:15 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure after merge of the net-next tree To: Stephen Rothwell Cc: David Miller , Networking , Linux Next Mailing List , Linux Kernel Mailing List , Kevin Darbyshire-Bryant Content-Type: text/plain; charset="UTF-8" Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hi. On Wed, Jun 19, 2019 at 12:23 PM Stephen Rothwell wrote: > > Hi all, > > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from usr/include/linux/tc_act/tc_ctinfo.hdrtest.c:1: > ./usr/include/linux/tc_act/tc_ctinfo.h:30:21: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration] > CTINFO_MODE_DSCP = BIT(0), > ^~~ > ./usr/include/linux/tc_act/tc_ctinfo.h:30:2: error: enumerator value for 'CTINFO_MODE_DSCP' is not an integer constant > CTINFO_MODE_DSCP = BIT(0), > ^~~~~~~~~~~~~~~~ > ./usr/include/linux/tc_act/tc_ctinfo.h:32:1: error: enumerator value for 'CTINFO_MODE_CPMARK' is not an integer constant > }; > ^ > > Caused by commit > > 24ec483cec98 ("net: sched: Introduce act_ctinfo action") > > Presumably exposed by commit > > b91976b7c0e3 ("kbuild: compile-test UAPI headers to ensure they are self-contained") > > from the kbuild tree. My commit correctly blocked the broken UAPI header, Hooray! People export more and more headers that are never able to compile in user-space. We must block new breakages from coming in. BIT() is not exported to user-space since it is not prefixed with underscore. You can use _BITUL() in user-space, which is available in include/uapi/linux/const.h Thanks. > I have applied the following (obvious) patch for today. > > From: Stephen Rothwell > Date: Wed, 19 Jun 2019 13:15:22 +1000 > Subject: [PATCH] net: sched: don't use BIT() in uapi headers > > Signed-off-by: Stephen Rothwell > --- > include/uapi/linux/tc_act/tc_ctinfo.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/tc_act/tc_ctinfo.h b/include/uapi/linux/tc_act/tc_ctinfo.h > index da803e05a89b..6166c62dd7dd 100644 > --- a/include/uapi/linux/tc_act/tc_ctinfo.h > +++ b/include/uapi/linux/tc_act/tc_ctinfo.h > @@ -27,8 +27,8 @@ enum { > #define TCA_CTINFO_MAX (__TCA_CTINFO_MAX - 1) > > enum { > - CTINFO_MODE_DSCP = BIT(0), > - CTINFO_MODE_CPMARK = BIT(1) > + CTINFO_MODE_DSCP = (1UL << 0), > + CTINFO_MODE_CPMARK = (1UL << 1) > }; > > #endif > -- > 2.20.1 > > -- > Cheers, > Stephen Rothwell -- Best Regards Masahiro Yamada