From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Aug 8
Date: Fri, 9 Aug 2019 13:44:19 +0900 [thread overview]
Message-ID: <CAK7LNASzxcicBPM5OkScnwHPef_7X=oiuO_0xCH3f55ACYZEWw@mail.gmail.com> (raw)
In-Reply-To: <20190808225316.GA3725@osiris>
Hi Heiko, Stephen,
On Fri, Aug 9, 2019 at 7:53 AM Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> On Thu, Aug 08, 2019 at 06:17:39PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20190807:
> >
> > I reverted a commit from the kbuild-current tree by request.
>
> Hello Masahiro,
>
> it looks like there is (another?) bug in kbuild. With your patch
>
> commit 421a15c167b2d1f43f287da5b75ef2704650640b (refs/bisect/bad)
> Author: Masahiro Yamada <yamada.masahiro@socionext.com>
> Date: Fri Jul 26 11:17:47 2019 +0900
>
> kbuild: clean-up subdir-ym computation
>
> The intermediate variables __subdir-{y,m} are unneeded.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> the file modules.builtin starts to miss a lot of entries when building
> the kernel tree. Reverting that patch on top of linux-next 20190808
> restores the old behaviour.
>
> This is the diff I get without and with the above commit (s390 with
> defconfig):
>
> --- modules.builtin.ok 2019-08-09 00:39:58.148624485 +0200
> +++ modules.builtin 2019-08-09 00:40:07.878637541 +0200
You are right. This commit is bad.
Stephen, could you revert this commit for today's linux-next ?
BTW, I had dropped this commit from my branch (with another reason),
but I forgot to push it to the public place...
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-08-09 4:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 8:17 linux-next: Tree for Aug 8 Stephen Rothwell
2019-08-08 22:53 ` Heiko Carstens
2019-08-09 4:44 ` Masahiro Yamada [this message]
2019-08-09 8:14 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2023-08-08 5:09 Stephen Rothwell
2022-08-08 3:47 Stephen Rothwell
2022-08-08 22:38 ` Stephen Rothwell
2018-08-08 7:53 Stephen Rothwell
2017-08-08 6:29 Stephen Rothwell
2016-08-08 3:17 Stephen Rothwell
2016-08-08 3:51 ` Andrew Donnellan
2016-08-08 4:21 ` Stephen Rothwell
2014-08-08 7:02 Stephen Rothwell
2013-08-08 7:08 Stephen Rothwell
2011-08-08 4:56 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNASzxcicBPM5OkScnwHPef_7X=oiuO_0xCH3f55ACYZEWw@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).