linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	NeilBrown <neilb@suse.com>
Subject: Re: linux-next: build warning after merge of the staging tree
Date: Tue, 16 Jan 2018 11:47:47 +0100	[thread overview]
Message-ID: <CAK8P3a1VeGAe5tE5rRcVT=VzoNidVVFvdNkMuZyGq9nqhRkZpA@mail.gmail.com> (raw)
In-Reply-To: <20180116055901.GA20154@kroah.com>

On Tue, Jan 16, 2018 at 6:59 AM, Greg KH <greg@kroah.com> wrote:
> On Tue, Jan 16, 2018 at 01:45:44PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the staging tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init':
>> drivers/staging/lustre/lnet/selftest/module.c:98:10: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>    return rc;
>>           ^~
>>
>> Introduced by commit
>>
>>   6106c0f82481 ("staging: lustre: lnet: convert selftest to use workqueues")
>
> Yeah, I told Neil about this, hopefully he sends me a fix soon :)

I sent a fix for that one, but now ran into another problem that I can't
easily figure out:

drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init':
drivers/staging/lustre/lnet/selftest/module.c:128:49: error: 'struct
cfs_cpt_table' has no member named 'ctb_parts'; did you mean
'ctb_nparts'?
   cpumask_copy(attrs.cpumask, lnet_cpt_table()->ctb_parts[i].cpt_cpumask);

I see that there are two definitions of 'struct cfs_cpt_table', and only
one of them has a ctb_parts member, but I don't know what this means
for its users.

The build regression also comes from commit 6106c0f82481 ("staging:
lustre: lnet: convert selftest to use workqueues"), and I see that all
other references to ctb_parts are in
drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c.

         Arnd

  reply	other threads:[~2018-01-16 10:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16  2:45 linux-next: build warning after merge of the staging tree Stephen Rothwell
2018-01-16  5:59 ` Greg KH
2018-01-16 10:47   ` Arnd Bergmann [this message]
2018-01-16 15:02     ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2020-09-09  7:16 Stephen Rothwell
2020-09-09  7:41 ` Greg KH
2019-12-13  1:10 Stephen Rothwell
2019-08-26  6:24 Stephen Rothwell
2019-08-26  6:30 ` Greg KH
2019-08-26  8:38   ` Gao Xiang
2019-08-26  8:54     ` Gao Xiang
2019-08-26  9:43       ` Gao Xiang
2019-08-26  9:53         ` Gao Xiang
2019-08-26 11:13           ` Gao Xiang
2019-08-14  6:08 Stephen Rothwell
2019-08-14  7:42 ` Greg KH
2019-04-23  5:13 Stephen Rothwell
2018-11-08  2:33 Stephen Rothwell
2018-11-08 11:17 ` Greg KH
2018-09-03  2:06 Stephen Rothwell
2018-09-04  9:04 ` John Whitmore
2018-05-14  4:37 Stephen Rothwell
2017-01-20  4:36 Stephen Rothwell
2017-01-20  8:37 ` Greg KH
2017-01-20  9:18   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a1VeGAe5tE5rRcVT=VzoNidVVFvdNkMuZyGq9nqhRkZpA@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).