linux-next: Fixes tags need some work in the arm-soc tree

linux-next: Fixes tags need some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]

Hi all,

In commit

  4f0f89dd9060 ("ARM: dts: stm32: add pwm cells to stm32f746")

Fixes tag

  Fixes: 9bd7b77af8e4 ("ARM: dts: stm32: add Timers driver for stm32f746

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  289459737869 ("ARM: dts: stm32: add pwm cells to stm32f429")

Fixes tag

  Fixes: c0e14fc712d9 ("ARM: dts: stm32: add Timers driver for stm32f429

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  493e84c5dc4d ("ARM: dts: stm32: add missing vdda-supply to adc on stm32h743i-eval")

Fixes tag

  Fixes: 090992a9ca54 ("ARM: dts: stm32: enable ADC on stm32h743i-eval

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  1425d00aff01 ("ARM: dts: stm32: add missing vdda-supply to adc on stm32429i-eval")

Fixes tag

  Fixes: 7465d81191a1 ("ARM: dts: stm32: enable ADC on stm32f429i-eval

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  bb06b54721fb ("ARM: dts: stm32: remove fixed regulator unit address on stm32429i-eval")

Fixes tag

  Fixes: 7465d81191a1 ("ARM: dts: stm32: enable ADC on stm32f429i-eval

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, please
keep them with the rest of the other tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the arm-soc tree

[Arnd Bergmann]

On Tue, Aug 13, 2019 at 4:28 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

>
> Please do not split Fixes tags over more than one line.  Also, please
> keep them with the rest of the other tags.

Thanks for the report. How bad is this? Should I undo the merge and
wait for an updated pull request?

      Arnd

Re: linux-next: Fixes tags need some work in the arm-soc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi Arnd,

On Tue, 13 Aug 2019 21:35:58 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Tue, Aug 13, 2019 at 4:28 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> >
> > Please do not split Fixes tags over more than one line.  Also, please
> > keep them with the rest of the other tags.  
> 
> Thanks for the report. How bad is this? Should I undo the merge and
> wait for an updated pull request?

Its probably ok to leave as long as lessons are learnt :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the arm-soc tree

[Alexandre Torgue]

Hi guys

On 8/13/19 11:47 PM, Stephen Rothwell wrote:
> Hi Arnd,
> 
> On Tue, 13 Aug 2019 21:35:58 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> On Tue, Aug 13, 2019 at 4:28 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>>>
>>> Please do not split Fixes tags over more than one line.  Also, please
>>> keep them with the rest of the other tags.
>>
>> Thanks for the report. How bad is this? Should I undo the merge and
>> wait for an updated pull request?
> 
> Its probably ok to leave as long as lessons are learnt :-)
> 

Sorry for my late answer.

Thanks Stephen for information. I'll take care next time before merging 
patches with "fixes" tag.

Arnd, no need to update the PR ?

regards

Alex

Re: linux-next: Fixes tags need some work in the arm-soc tree

[Arnd Bergmann]

On Mon, Aug 26, 2019 at 11:44 AM Alexandre Torgue
<alexandre.torgue@st.com> wrote:
> On 8/13/19 11:47 PM, Stephen Rothwell wrote:
> > Hi Arnd,
> >
> > On Tue, 13 Aug 2019 21:35:58 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> >>
> >> On Tue, Aug 13, 2019 at 4:28 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >>>
> >>> Please do not split Fixes tags over more than one line.  Also, please
> >>> keep them with the rest of the other tags.
> >>
> >> Thanks for the report. How bad is this? Should I undo the merge and
> >> wait for an updated pull request?
> >
> > Its probably ok to leave as long as lessons are learnt :-)
> >
>
> Sorry for my late answer.
>
> Thanks Stephen for information. I'll take care next time before merging
> patches with "fixes" tag.
>
> Arnd, no need to update the PR ?

No, since it's already pulled, just leave it for this time.

    Arnd