From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D46C433DB for ; Wed, 3 Feb 2021 17:11:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B70664DF0 for ; Wed, 3 Feb 2021 17:11:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232005AbhBCRKx (ORCPT ); Wed, 3 Feb 2021 12:10:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:37732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232013AbhBCRKt (ORCPT ); Wed, 3 Feb 2021 12:10:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B3E864F5D; Wed, 3 Feb 2021 17:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612372208; bh=nQETsKaXi6oufw4kuZ5Eytq8DCwUI85JEjUsc1C8gAg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cT/2B1eLsL61Ysv/HqMAouZ9kPQgzuSC9IratmGQtvH3wav/AMwc+FsiJqt1dEYYL fSV2v0y35CjEZSm8Y4jsWghL6W6vCrWxwEVWfUhIn6VmBmAJsE/H4K4oQQNdLnikGn CIgzTWKOPNa/3JIgPaA1oxOlCaTf/sN+4H8aB58ZF4y+sVJMbVxhqu+wNM2b5Qe+8o 9xWBR0uBjs9DVMTRX+r/z5ldvVPWLdQqfaExJjWIH7i+HoRIJK2EUN4ZGHi32cdodW wGNMVXlGcIjKu/ieI2CNWHk6igVwIV6Pu1ZL6bKVnRE47mGOQbuslavt7U/gIuCBW+ skz6ibf5Cr6AQ== Received: by mail-ot1-f44.google.com with SMTP id 36so578277otp.2; Wed, 03 Feb 2021 09:10:08 -0800 (PST) X-Gm-Message-State: AOAM530HpSsPDmvnZj1W6V1DOGW3/cKjPWRZTr3wv4AU8UZ9/g6t/uOD qE56sW80h2EDIOk07e2ZkIFrEJ8/9mgURm5DZbM= X-Google-Smtp-Source: ABdhPJzjecSPR278MfEY/4Nn2UgkqXfz70UdyPsqX527Cl5z6fwF0+HIHATVMkO9uhicOQGg8NqCJGxurPq4PvqsJAM= X-Received: by 2002:a05:6830:1256:: with SMTP id s22mr2788459otp.251.1612372207595; Wed, 03 Feb 2021 09:10:07 -0800 (PST) MIME-Version: 1.0 References: <20210202200324.5179db33@canb.auug.org.au> In-Reply-To: <20210202200324.5179db33@canb.auug.org.au> From: Arnd Bergmann Date: Wed, 3 Feb 2021 18:09:50 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure after merge of the akpm-current tree To: Stephen Rothwell Cc: Andrew Morton , Pavel Tatashin , Linux Kernel Mailing List , Linux Next Mailing List , Randy Dunlap Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, Feb 2, 2021 at 10:12 AM Stephen Rothwell wrote: > > 983cb10d3f90 ("mm/gup: do not migrate zero page") > > I have applied the following patch for today: > > From: Stephen Rothwell > Date: Tue, 2 Feb 2021 19:49:00 +1100 > Subject: [PATCH] make is_pinnable_page a macro > > As it is currently defined before page_to_section() which it needs. > > Signed-off-by: Stephen Rothwell I still see the same problem in next-20210203, and your patch below fixes it for me. Did you drop it from the latest build? Arnd > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 58f250cabea6..a608feb0d42e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1128,11 +1128,9 @@ static inline bool is_zone_movable_page(const struct page *page) > } > > /* MIGRATE_CMA and ZONE_MOVABLE do not allow pin pages */ > -static inline bool is_pinnable_page(struct page *page) > -{ > - return !(is_zone_movable_page(page) || is_migrate_cma_page(page)) || > - is_zero_pfn(page_to_pfn(page)); > -} > +#define is_pinnable_page(page) \ > + (!(is_zone_movable_page(page) || is_migrate_cma_page(page)) || \ > + is_zero_pfn(page_to_pfn(page))) > > #ifdef CONFIG_DEV_PAGEMAP_OPS > void free_devmap_managed_page(struct page *page);