From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0319C433FF for ; Thu, 1 Aug 2019 17:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBD2820838 for ; Thu, 1 Aug 2019 17:29:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WoHkVxtX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730008AbfHAR3J (ORCPT ); Thu, 1 Aug 2019 13:29:09 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46830 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729609AbfHAR3I (ORCPT ); Thu, 1 Aug 2019 13:29:08 -0400 Received: by mail-wr1-f67.google.com with SMTP id z1so74427463wru.13 for ; Thu, 01 Aug 2019 10:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V7iES048LQCKT01wi1ZH6mu+llZ9u5BBJ+ptxxo4m+U=; b=WoHkVxtXyOlDI8FIrsWX+mKng5MgkynwGfd/EiStmKxt5ZmRGwagRY65HZ1D/QQNaj v4dQ3o6i+FbowNs5iKg+uUWIfd1LDUikpWW4Stm6hL/a+dh8l98sjXdIoUQ2DGyWdW9D VwHTiK6m88q/cO6xDvrUQ3OVGBezKVCugRm52n40mmP1+TOql/Ahky5a7rBp1QesQTNr ygTczmDMsij0pflEsuxDve0CwQVXOUzBdxX9X7P85zCpzUJm9RBRhz9BJuFUaEuWCUHT KkHtw/5RQDWhEyUF3UuSCcNG0QKqk09Oq1fURsscjTBaMQlUlp96ZULSpZUEU0G2IdcC sziQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V7iES048LQCKT01wi1ZH6mu+llZ9u5BBJ+ptxxo4m+U=; b=t+B6TqN7dvQ9oeikfJEpRjNnxIIM9k1THmMPpPoCV3KjSlJVhkffGOipMIY0K7eYWW j6GOeuxSxhybtsTAOL1iSRq4wYlRNQ3VDB/EritfwwmvMpjpe4fjAdH5hyH7AJ4i5jwo jBBjqRAKyQAggSLCDZYVtBNa0icHi6ZBsBcj7Yx+5APa6RYfTR2nyCKnhKZGC/yCsoQ9 RDpqqXkl+XcItlE3TcaS1WRe+Kskw3Vjv38vdnGpk63EiRwk+uhcm7y5SHunYsjfbHG7 FWWjUeRXrwFaeTVSe9r2oZ2RLALBEtSV/n5BSVVPfGw54U+oy+cfmPnOL5ScFsZSz0lx x5QQ== X-Gm-Message-State: APjAAAVNi1gd58OBdXVuAuc3flqcBuX7RMIzgOulmOfxn78154RtjEnt iTdJfAhm+0PHfznDhPrPNyCHZQaw6se6TxyToWqp2A== X-Google-Smtp-Source: APXvYqwQ4BT46vMcwoHkV6Gc8YIsZiFmZw8/ASpSzzC9Tz3z1i9lnwO696CATx2wOyOHjR2u5qFB2fR3Zp04ForpvZs= X-Received: by 2002:a5d:6b07:: with SMTP id v7mr31905638wrw.169.1564680546461; Thu, 01 Aug 2019 10:29:06 -0700 (PDT) MIME-Version: 1.0 References: <20190731163915.3fdfcb14@canb.auug.org.au> <20190731085819.GA3488@osiris> <20190731110816.GA20753@gondor.apana.org.au> <20190731111520.GC3488@osiris> <20190731113216.GA21068@gondor.apana.org.au> <20190731114453.GD3488@osiris> <20190801122849.GB4163@osiris> In-Reply-To: <20190801122849.GB4163@osiris> From: Ard Biesheuvel Date: Thu, 1 Aug 2019 20:28:56 +0300 Message-ID: Subject: Re: linux-next: Tree for Jul 31 - s390 crypto build breakage To: Heiko Carstens Cc: Herbert Xu , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , linux-s390 , Harald Freudenberger , Patrick Steuer Content-Type: text/plain; charset="UTF-8" Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, 1 Aug 2019 at 15:28, Heiko Carstens wrote: > > On Wed, Jul 31, 2019 at 01:44:54PM +0200, Heiko Carstens wrote: > > On Wed, Jul 31, 2019 at 09:32:16PM +1000, Herbert Xu wrote: > > > On Wed, Jul 31, 2019 at 01:15:20PM +0200, Heiko Carstens wrote: > > > > > > > > However that doesn't fix the simd.h header file breakage with the > > > > second patch :) > > > > > > That fix should be there now too. > > > > Yes, works now. Thank you! > > Still not... with linux-next as of today I get this (s390 defconfig): > > ERROR: "crypto_aegis128_decrypt_chunk_simd" [crypto/aegis128.ko] undefined! > ERROR: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefined! > ERROR: "crypto_aegis128_encrypt_chunk_simd" [crypto/aegis128.ko] undefined! > scripts/Makefile.modpost:105: recipe for target 'modules-modpost' failed > Hello Heiko, Apologies for the breakage. The first two fixes addressed obvious shortcomings in my code, but with this issue, I'm a bit puzzled tbh. The calls to these missing functions should be optimized away, since have_simd never gets assigned if CONFIG_CRYPTO_AEGIS128_SIMD is not defined, but for some reason, this isn't working. Which version of GCC are you using? Also, could you please try whether the patch below fixes the problem? Thanks https://lore.kernel.org/linux-crypto/20190729074434.21064-1-ard.biesheuvel@linaro.org/