From: Nick Desaulniers <ndesaulniers@google.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: linux-next: build failure after merge of the compiler-attributes tree
Date: Thu, 29 Aug 2019 15:53:59 -0700 [thread overview]
Message-ID: <CAKwvOdkRMSy7tt5Ln5rZSB4+G7srvSUuAoCxgyNbnp3zp0VmEQ@mail.gmail.com> (raw)
In-Reply-To: <20190830085227.01676c93@canb.auug.org.au>
Thanks for the report, Miguel and I decided to drop the patch.
On Thu, Aug 29, 2019 at 3:52 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the compiler-attributes tree, today's linux-next build
> (powerpc ppc64_defconfig) failed like this:
>
> arch/powerpc/boot/main.c:153:45: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__section'
> 153 | static char cmdline[BOOT_COMMAND_LINE_SIZE] __section(__builtin_cmdline);
> | ^~~~~~~~~
> arch/powerpc/boot/main.c: In function 'prep_cmdline':
> arch/powerpc/boot/main.c:166:6: error: 'cmdline' undeclared (first use in this function)
> 166 | if (cmdline[0] == '\0')
> | ^~~~~~~
> arch/powerpc/boot/main.c:166:6: note: each undeclared identifier is reported only once for each function it appears in
> arch/powerpc/boot/main.c: In function 'start':
> arch/powerpc/boot/main.c:196:40: error: 'cmdline' undeclared (first use in this function)
> 196 | if ((loader_info.cmdline_len > 0) && (cmdline[0] == '\0'))
> | ^~~~~~~
>
> Caused by commit
>
> e81c903fb9e2 ("powerpc: prefer __section and __printf from compiler_attributes.h")
>
> I have reverted that commit for today.
>
> gcc v9.2.1 (in case that matters)
>
> The above error is from the PowerPC boot wrapper that is built without
> the kernel headers (mainly, I think).
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-08-29 22:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 22:52 linux-next: build failure after merge of the compiler-attributes tree Stephen Rothwell
2019-08-29 22:53 ` Nick Desaulniers [this message]
2019-08-29 22:54 ` Miguel Ojeda
2019-08-29 22:58 ` Miguel Ojeda
-- strict thread matches above, loose matches on Subject: below --
2019-02-06 21:30 Stephen Rothwell
2019-02-06 21:48 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdkRMSy7tt5Ln5rZSB4+G7srvSUuAoCxgyNbnp3zp0VmEQ@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).