From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02DB3C433F5 for ; Wed, 5 Oct 2022 16:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbiJEQiz (ORCPT ); Wed, 5 Oct 2022 12:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbiJEQiy (ORCPT ); Wed, 5 Oct 2022 12:38:54 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E99F1792C5 for ; Wed, 5 Oct 2022 09:38:50 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id i6so16297081pfb.2 for ; Wed, 05 Oct 2022 09:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=oQbM0nVWmaDXyk82cl6r367zDWVYGaPQODZVcdO+QZM=; b=Hvcb5sHqdru0SR4QpRIz/cd5ZjallOVpwA/Xe1rPLCdPvyRIAk3u2ZzmOM+RCSI4jO xwGVJxU60hIgDlibk/ghL6C0nR+WwOg3rwgU9dZ+xS3HmhEdtDucFiWz6Jh47/7Yarn8 mYpnPD5igo+2paasd/TO+B/9xkXR9uEHlwTrhKvIrvCTAOf2BXnATMSDQHxI7lKESOQd 77fdwtyclHf4iHYpXv1jqvj5lFtaIlvlg6qZrtUyopdTpppjkDJCMdC/xBgcTgbkQwFb /4mq3kG7xMSbvqgwG7o5F4vcnrLKamlu5jbzAh2W1lzrlQTZJ1Kwn8XUra5gHp91EhHi SSsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=oQbM0nVWmaDXyk82cl6r367zDWVYGaPQODZVcdO+QZM=; b=Pvuzwfnwd08SwNrDgx0Of5BstDg3RpgedQRTYXKHNDxJMJwu9Ms3Nnccx40cqudNZN /1RkGOu+uKoKbATNxe6yVLHB4yuVdeAxaym2QkCdJMhz3KkPDN+bHE3NP2Od1K9NXvj9 YwbfGVhU9/Dd1juX6oyVBklPrdlIpWN131qXRf8ZUI8n65CGztkLZXUz1iOqNF6T1bGp s7cpFcpl1iD6k5vU91N3/xG4kM8qkHX7Sq/z1du5HAO3FVV3LB+2LC3q4h2SS+j1RoWN LoGyx4nMLPvfhAKQblC8cN2tKNStMfJO/Xixly+qg66iH6sjJ20jD7bWvzb0dx0GSV1x majA== X-Gm-Message-State: ACrzQf1qSr6h+bxCXL5Cd/4AqpzyJD/ZduBK14+kDiFtgVuBq7aN+Dja stEWd2PxnA/mjpxKyIyjHfLGPVEE8jiao4A8YdiD8HXun/6sTA== X-Google-Smtp-Source: AMsMyM71N9pjV+owSSTwxxr2FguNkvc47wBKX2/glG8mXnLd5jbKpLUAq5gPGDnyOa8pNUB/CiA5HYCdi64kN1H1Gmw= X-Received: by 2002:a63:e709:0:b0:438:98e8:d1c with SMTP id b9-20020a63e709000000b0043898e80d1cmr555835pgi.403.1664987930207; Wed, 05 Oct 2022 09:38:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nick Desaulniers Date: Wed, 5 Oct 2022 09:38:38 -0700 Message-ID: Subject: Re: build failure of next-20221005 due to a3a956c78efa ("fs/ntfs3: Add option "nocase"") To: "Sudip Mukherjee (Codethink)" Cc: Konstantin Komarov , Nathan Chancellor , Tom Rix , ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-next@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Wed, Oct 5, 2022 at 4:19 AM Sudip Mukherjee (Codethink) wrote: > > Hi All, > > The builds of x86_84 allmodconfig with clang have failed to build > next-20221005 with the error: > > fs/ntfs3/namei.c:445:7: error: variable 'uni1' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] > if (toupper(c1) != toupper(c2)) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > ./include/linux/ctype.h:64:20: note: expanded from macro 'toupper' > #define toupper(c) __toupper(c) > ^ > fs/ntfs3/namei.c:487:12: note: uninitialized use occurs here > __putname(uni1); > ^~~~ > ./include/linux/fs.h:2803:65: note: expanded from macro '__putname' > #define __putname(name) kmem_cache_free(names_cachep, (void *)(name)) > ^~~~ > fs/ntfs3/namei.c:445:3: note: remove the 'if' if its condition is always false > if (toupper(c1) != toupper(c2)) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > fs/ntfs3/namei.c:434:7: error: variable 'uni1' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] > if (!lm--) { > ^~~~~ > fs/ntfs3/namei.c:487:12: note: uninitialized use occurs here > __putname(uni1); > ^~~~ > ./include/linux/fs.h:2803:65: note: expanded from macro '__putname' > #define __putname(name) kmem_cache_free(names_cachep, (void *)(name)) > ^~~~ > fs/ntfs3/namei.c:434:3: note: remove the 'if' if its condition is always false > if (!lm--) { > ^~~~~~~~~~~~ > fs/ntfs3/namei.c:430:22: note: initialize the variable 'uni1' to silence this warning > struct cpu_str *uni1, *uni2; > ^ > = NULL > 2 errors generated. > > git bisect pointed to a3a956c78efa ("fs/ntfs3: Add option "nocase""). > > I will be happy to test any patch or provide any extra log if needed. Hi Sudip, Thanks for the report. Please help review+test: https://lore.kernel.org/llvm/20221004232359.285685-1-nathan@kernel.org/. For future reports, please take the time to review: 1. Our issue tracker. Nathan had a bug filed about this yesterday. https://github.com/ClangBuiltLinux/linux/issues/1729 2. The mailing list archives on lore: https://lore.kernel.org/llvm/ If you search for -Wsometimes-uninitialized you'll see Nathan's report/patch as well as reports from KernelCI. I'll take more reports over no reports, but if we already have an open report, please take the time to participate in the existing threads rather than create new ones. That way, if an issue needs a discussion to resolve, it happens in one thread and not across multiple. -- Thanks, ~Nick Desaulniers